New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600497 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 600503
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Perf regressions in multiple encode perf tests around 384572:384575

Project Member Reported by tnakamura@chromium.org, Apr 4 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=600497

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgiIrvpAsM


Bot(s) for this bug's original alert(s):

chromium-webrtc-rel-linux
Cc: phoglund@chromium.org mflodman@chromium.org
Components: Blink>WebRTC>Video
Labels: -Pri-2 Pri-1
Owner: nisse@chromium.org
CL range:
http://test-results.appspot.com/revision_range?start=384572&end=384575

I see a WebRTC roll:
https://codereview.chromium.org/1850673003

There are 15 CLs in that roll, but nothing immediately stands out. nisse@, there are a couple CLs that look possibly related:
https://codereview.webrtc.org/1827023002
https://codereview.webrtc.org/1843413002

Can you take an initial look?
Issue 600515 has been merged into this issue.
Please note that other tests around the same range also alerted - see the graphs in https://chromeperf.appspot.com/group_report?bug_id=600515 (i.e. linked in duped bug 600515).
Labels: OS-Linux OS-Mac OS-Windows
Summary: Perf regressions in multiple encode perf tests around 384572:384575 (was: 2.3% regression in chromium-webrtc-rel-linux/browser_tests / PSNR / 360p_VP8 at 384572:384575)
Cc: sprang@chromium.org
This decreases at the same time as  http://crbug.com/600503 , so it's very likely the issues are related.
Mergedinto: 600503
Status: Duplicate (was: Assigned)
Spoke with perkj@, and it does make sense that turning on the denoiser reduces video quality. Basically, it denoises the barcoded frame from the ref video, then encodes/decodes and captures the frame. However, when we do the PSNR comparison between the captured frame and the source frame we do not apply the denoising step to the source frame, so there will be a quality cost for the denoiser.

Since the root cause is the same as 600503 I'm duping this to that bug.

Sign in to add a comment