New issue
Advanced search Search tips

Issue 600468 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 684849



Sign in to add a comment

Certificate manager, "Import and Bind to Device" button mocks.

Project Member Reported by dpa...@chromium.org, Apr 4 2016

Issue description

On ChromeOS the certificate manager has an extra import button, see attachment import_and_bind.png.

Simply putting a new button next to the existing "Import" button in the new UI would look as in import_and_bind_new.png.

@bettes: Could you provide mocks on how "Import and Bind to Device" should be displayed? Also what should be the exact string displayed?
 
import_and_bind.png
118 KB View Download
import_and_bind_new.png
63.6 KB View Download
Blocking: 547073
Labels: -Pri-2 Pri-3
Status: Assigned (was: Untriaged)
Labels: Hotlist-MD-Settings-Privacy-CertificateManager

Comment 4 by dbeam@chromium.org, May 31 2016

maybe we should make these buttons a separate row, like primary buttons in basic/advanced sections?
If we need to keep the existing strings, @dbeam's suggestion in #4 makes sense to me.

Can you help me understand what "Import and bind to device" does?

Comment 6 by dpa...@chromium.org, Jun 11 2016

"Import and Bind" imports a certificate and stores it in hardware on the device, on the TPM module, see more details at https://www.chromium.org/developers/design-documents/tpm-usage.

Comment 7 by dpa...@chromium.org, Jun 24 2016

Cc: steve...@chromium.org

Comment 8 by dbeam@chromium.org, Dec 9 2016

Cc: dpa...@chromium.org
how big of a deal is it to have "Import and bind"?

Comment 9 by bettes@chromium.org, Dec 13 2016

Seems fine with me
Labels: OS-Chrome
@dbeam: I don't know since I've never used this feature. AFAIU this is a ChromeOS only feature so @stevenjb might know.
Cc: -steve...@chromium.org
Owner: steve...@chromium.org
Blocking: 614589
Cc: tbuck...@chromium.org bettes@chromium.org
Labels: -Pri-3 M-58 Pri-1
Status: Started (was: Assigned)
This is very important and a MD Settings release blocker on Chrome OS.

It sounds like having 'Import and bind' next to 'Import' will be acceptable?

I will proceed with that unless I hear otherwise.

Blocking: -547073 -614589 684849
Status: Fixed (was: Started)
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bdd26b43756cb3fb97568d7f126359aff6a5904

commit 6bdd26b43756cb3fb97568d7f126359aff6a5904
Author: dpapad <dpapad@chromium.org>
Date: Sat Feb 18 00:31:03 2017

MD Settings: Should not show "Import and Bind" button on non-CrOS.

BUG= 600468 
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2704713002
Cr-Commit-Position: refs/heads/master@{#451407}

[modify] https://crrev.com/6bdd26b43756cb3fb97568d7f126359aff6a5904/chrome/browser/resources/settings/settings_resources.grd

Status: Verified (was: Fixed)

Sign in to add a comment