New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600465 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 596201



Sign in to add a comment

git.bat clean -dff fails on build_and_upload_clang bot

Project Member Reported by thakis@chromium.org, Apr 4 2016

Issue description

https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_clang_upload/builds/20/steps/bot_update/logs/stdio


warning: Could not stat path 'third_party/llvm-bootstrap/tools/clang/test/Modules/Output/dependency-dump.m.tmp/vfs/b/build/slave/build_and_upload_clang/build/src/third_party/llvm/tools/clang/test/Modules/Inputs/Module.framework/Headers/Buried': Filename too long
===Failed in 0.2 mins===

===backing off, sleeping for 4 secs===
===Running git.bat clean -dff (attempt #2)===
In directory: E:\b\build\slave\build_and_upload_clang\build\src
warning: Could not stat path 'third_party/llvm-bootstrap/test/ExecutionEngine/OrcMCJIT/Output/load-object-a.ll.tmp.cachedir/E/b/build/slave/build_and_upload_clang/build/src/third_party/llvm/test/ExecutionEngine/OrcMCJIT/Inputs/multi-module-b.o': Filename too long
warning: failed to remove third_party/llvm-bootstrap/tools/clang/test/Modules/Output/dependency-dump.m.tmp/vfs/b/build/slave/build_and_upload_clang/build/src/third_party/llvm/tools/clang/test/Modules/Inputs/Module.framework/Frameworks
warning: Could not stat path 'third_party/llvm-bootstrap/tools/clang/test/Modules/Output/dependency-dump.m.tmp/vfs/b/build/slave/build_and_upload_clang/build/src/third_party/llvm/tools/clang/test/Modules/Inputs/Module.framework/Headers/Buried': Filename too long
===Failed in 0.0 mins===


The vfs apparently repeats the whole current path again, which leads to a pretty long name.

We don't see this on other bots as far as I can tell (not even the clang tot bots, which also use Windows and the new git we pushed), so I guess this is the "bot name should be short, else things like this blow up" bug -- "win_chromium_clang_upload" is a relatively long bot name. See also this comment https://code.google.com/p/chromium/codesearch#chromium/build/masters/master.chromium.fyi/master.cfg&l=69 and  bug 399990 . Around 17 chars of bot name lengths should be safe; the current bot name length is 25.
 
Blocking: 596201
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/9dc23df9f0358bbb54829d06f77c660adee2eaec

commit 9dc23df9f0358bbb54829d06f77c660adee2eaec
Author: thakis@chromium.org <thakis@chromium.org>
Date: Tue Apr 05 20:14:20 2016

Give the clang upload bots shorter names.

Currently, git fails to delete files on these bots because path names
are too long (on Windows), and the bot / checkout name is part of the
path.  Our other bots don't have this problem, so try giving the bot
a shorter name (and rename the non-Win bots for consistency).

BUG= 600465 

Review URL: https://codereview.chromium.org/1858343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299707 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.linux/master.cfg
[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.linux/slaves.cfg
[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.mac/master.cfg
[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.mac/slaves.cfg
[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.win/master.cfg
[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.win/slaves.cfg
[rename] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_linux_linux_upload_clang.json
[rename] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_mac_mac_upload_clang.json
[rename] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_win_win_upload_clang.json
[rename] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/scripts/slave/recipes/chromium_upload_clang.py

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/9dc23df9f0358bbb54829d06f77c660adee2eaec

commit 9dc23df9f0358bbb54829d06f77c660adee2eaec
Author: thakis@chromium.org <thakis@chromium.org>
Date: Tue Apr 05 20:14:20 2016

Give the clang upload bots shorter names.

Currently, git fails to delete files on these bots because path names
are too long (on Windows), and the bot / checkout name is part of the
path.  Our other bots don't have this problem, so try giving the bot
a shorter name (and rename the non-Win bots for consistency).

BUG= 600465 

Review URL: https://codereview.chromium.org/1858343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299707 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.linux/master.cfg
[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.linux/slaves.cfg
[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.mac/master.cfg
[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.mac/slaves.cfg
[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.win/master.cfg
[modify] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/masters/master.tryserver.chromium.win/slaves.cfg
[rename] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_linux_linux_upload_clang.json
[rename] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_mac_mac_upload_clang.json
[rename] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_win_win_upload_clang.json
[rename] https://crrev.com/9dc23df9f0358bbb54829d06f77c660adee2eaec/scripts/slave/recipes/chromium_upload_clang.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/a035f73330c392b393cdb30249456df62c23e797

commit a035f73330c392b393cdb30249456df62c23e797
Author: thakis <thakis@google.com>
Date: Tue Apr 05 20:25:20 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/f4d8d27e1e89989bb54aade50cf05c3df425e79f

commit f4d8d27e1e89989bb54aade50cf05c3df425e79f
Author: thakis <thakis@google.com>
Date: Tue Apr 05 20:25:29 2016

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/6ea3e0a15fe5296c17805a6069b032edb815ebaa

commit 6ea3e0a15fe5296c17805a6069b032edb815ebaa
Author: thakis <thakis@google.com>
Date: Tue Apr 05 20:26:28 2016

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 8 2016

Comment 9 by thakis@chromium.org, Apr 11 2016

Owner: thakis@chromium.org
Status: Fixed (was: Untriaged)
As far as I can tell, this is better now, https://build.chromium.org/p/tryserver.chromium.win/builders/win_upload_clang/builds/1 had a green bot_update run (even though it was on the same slave as build step 0)
i guess the tot bots don't have an llvm-bootstrap dir, so git never tries to remove that. maybe we can add llvm-bootstrap to .gitignore to work around this.
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42943eacbb2da168f441b14c7432847b461b0e99

commit 42943eacbb2da168f441b14c7432847b461b0e99
Author: thakis <thakis@chromium.org>
Date: Tue Apr 12 19:45:47 2016

Add llvm-bootstrap to .gitignore.

This should only exist on the clang packaging bots, but not having this makes
the Win clang packaging build fail because git tries removing this directory
and then fails to do so because paths contained in it are too long.

BUG= 600465 

Review URL: https://codereview.chromium.org/1885503004

Cr-Commit-Position: refs/heads/master@{#386776}

[modify] https://crrev.com/42943eacbb2da168f441b14c7432847b461b0e99/.gitignore

Owner: thakis@chromium.org
Status: Fixed (was: Started)
https://build.chromium.org/p/tryserver.chromium.win/builders/win_upload_clang/builds/12 worked and was on the same slave as the failing step above. Let's declare victory again.

Sign in to add a comment