Update code under 1) https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/resources/settings/reset_page/, to not make directl calls to chrome.send() 2) C++ handler at https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/webui/settings/reset_settings_handler.cc to not call Javascript functions by name. 3) https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/webui/settings/reset_page_test.js to use a TestBrowserProxy. These were authored before we established the browser proxy pattern in MD Settings.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c32c1996cbb66fca2f4c6817e6ff7ef75b590718 commit c32c1996cbb66fca2f4c6817e6ff7ef75b590718 Author: dpapad <dpapad@chromium.org> Date: Tue Apr 05 21:26:56 2016 MD Settings: Convert reset_page/ to use browser proxy pattern. BUG= 600461 Review URL: https://codereview.chromium.org/1853413002 Cr-Commit-Position: refs/heads/master@{#385287} [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/resources/settings/reset_page/powerwash_dialog.html [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/resources/settings/reset_page/powerwash_dialog.js [add] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/resources/settings/reset_page/reset_browser_proxy.html [add] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/resources/settings/reset_page/reset_browser_proxy.js [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/resources/settings/reset_page/reset_page.html [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/resources/settings/reset_page/reset_profile_banner.html [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/resources/settings/reset_page/reset_profile_banner.js [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/ui/webui/settings/reset_settings_handler.cc [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/ui/webui/settings/reset_settings_handler.h [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/c32c1996cbb66fca2f4c6817e6ff7ef75b590718/chrome/test/data/webui/settings/reset_page_test.js
Comment 1 by dpa...@chromium.org
, Apr 4 2016