Move SpdySerializedFrame from heap to stack. |
||||
Issue descriptionSpdySerializedFrame is always used wrapped in a scoped_ptr<> to manage memory ownership: to make sure there is only one instance pointing to owned memory, and it always gets freed after destruction. However, the same thing could be enforced with move semantics, which would then allow SpdySerializedFrame to be always instantiated on the stack, providing slight performance improvements, as well as more readable code.
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 14 2016
This issue has been moved once and is lower than Pri-1. Removing the milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df80d44fd869b5a27871be4c5c1e0fdfd184d584 commit df80d44fd869b5a27871be4c5c1e0fdfd184d584 Author: bnc <bnc@chromium.org> Date: Fri Jul 15 20:27:41 2016 Move ~1000 SpdySerializedFrame instances from heap to stack in tests. * Return SpdySerializedFrame instead of SpdySerializedFrame* in SpdyTestUtil. * Move ~1000 SpdySerializedFrame local variables from heap to stack in tests, thus eliminating ~1000 unnecessary memory allocations. * Remove unused SpdyTestUtil::ConstructSpdyFrame() methods. * s/SpdyTestUtil::ConstructSpdyBodyFrame/SpdyTestUtil::ConstructSpdyDataFrame/ (Body is an application layer concept; data is a framing layer concept.) * Use SpdyTestUtil::ConstructSpdyDataFrame() instead of BufferedSpdyFramer::CreateDataFrame() in tests; remove unused BufferedSpdyFramer instances. * Remove one unused unique_ptr<SpdySerializedFrame> instance from BidirectionalStreamTest.CancelStreamDuringReadData. This change only affects tests, there is no functional change intended, and there is no move semantics involved. BUG=600438 Review-Url: https://codereview.chromium.org/2156643002 Cr-Commit-Position: refs/heads/master@{#405845} [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/http/bidirectional_stream_unittest.cc [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/http/http_network_transaction_unittest.cc [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/http/http_proxy_client_socket_pool_unittest.cc [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/spdy/bidirectional_stream_spdy_impl_unittest.cc [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/spdy/spdy_http_stream_unittest.cc [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/spdy/spdy_network_transaction_unittest.cc [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/spdy/spdy_proxy_client_socket_unittest.cc [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/spdy/spdy_session_pool_unittest.cc [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/spdy/spdy_session_unittest.cc [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/spdy/spdy_stream_unittest.cc [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/spdy/spdy_test_util_common.cc [modify] https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584/net/spdy/spdy_test_util_common.h
,
Aug 2 2017
This is marked "started", yet hasn't been updated in a long time. Changing back to assigned.
,
Feb 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcb30096edc00cebf7aff7ec50cdfcfc2d5e9125 commit dcb30096edc00cebf7aff7ec50cdfcfc2d5e9125 Author: Bence Béky <bnc@chromium.org> Date: Sun Feb 11 01:32:29 2018 Misc cleanup: remove unused, fix comment, improve logging. Change logging in StaticSocketDataHelper::VerifyWriteData() such that if writted data does not match mock write, then print actual written data in full length, not only truncated to the length of the mock write data. Remove unused StaticSocketDataProvider:CompleteRead(). The rest of this CL belongs to https://crbug.com/810752: Inline ConstructSpdyGoAway() as ConstructSpdyGoAway(0). Remove unused struct SpdyHeaderInfo. Remove obsolete "The caller takes ownership of the frame." comment from spdy_test_util_common.h, leftover from when methods used to return raw pointers. This is a follow-up to https://crrev.com/2156643002/diff/1/net/spdy/spdy_test_util_common.h. Also remove useless "Returns a SpdySerializedFrame." comments from the line above the definition showing return type SpdySerializedFrame. Bug: 600438, 810752 Change-Id: I1f3471f4e4a9b71603257cf82986d0efe0288c7f Reviewed-on: https://chromium-review.googlesource.com/912013 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#535993} [modify] https://crrev.com/dcb30096edc00cebf7aff7ec50cdfcfc2d5e9125/net/http/http_network_transaction_unittest.cc [modify] https://crrev.com/dcb30096edc00cebf7aff7ec50cdfcfc2d5e9125/net/socket/socket_test_util.cc [modify] https://crrev.com/dcb30096edc00cebf7aff7ec50cdfcfc2d5e9125/net/socket/socket_test_util.h [modify] https://crrev.com/dcb30096edc00cebf7aff7ec50cdfcfc2d5e9125/net/spdy/chromium/spdy_session_unittest.cc [modify] https://crrev.com/dcb30096edc00cebf7aff7ec50cdfcfc2d5e9125/net/spdy/chromium/spdy_test_util_common.cc [modify] https://crrev.com/dcb30096edc00cebf7aff7ec50cdfcfc2d5e9125/net/spdy/chromium/spdy_test_util_common.h |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Apr 6 2016