New issue
Advanced search Search tips

Issue 600434 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove dead code found by Scythe

Project Member Reported by lukasza@chromium.org, Apr 4 2016

Issue description

Let me try to remove some dead code, starting in components/test_runner and using Scythe (Googlers only tool... :-(  more details at go/scythe).
 
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/959fb256dce4f0b1dffa1df094cdff0fc3c7040c

commit 959fb256dce4f0b1dffa1df094cdff0fc3c7040c
Author: lukasza <lukasza@chromium.org>
Date: Mon Apr 18 20:00:14 2016

Remove unused fields from //content.

This CL was created using Scythe (Googlers only tool, sorry...).
See go/scythe for more details.

BUG=600434
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1875463002

Cr-Commit-Position: refs/heads/master@{#387990}

[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/appcache/appcache_internals_ui.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/bluetooth/bluetooth_dispatcher_host.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/compositor/reflector_impl_unittest.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/download/save_package.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/download/save_package.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/fileapi/sandbox_file_system_backend_unittest.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/frame_host/frame_tree.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/frame_host/frame_tree_node.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/gpu/gpu_data_manager_impl_private.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/media/capture/web_contents_video_capture_device_unittest.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/input/synthetic_mouse_pointer.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/pepper/pepper_file_io_host.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/pepper/pepper_file_io_host.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/render_view_host_impl.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/tracing/tracing_controller_impl.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/browser/zygote_host/zygote_communication_linux.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/common/host_shared_bitmap_manager.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/common/host_shared_bitmap_manager.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/common/host_shared_bitmap_manager_unittest.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/public/browser/load_notification_details.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/renderer/child_frame_compositing_helper.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/renderer/media/media_stream_dispatcher_unittest.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/renderer/media/webaudio_capturer_source.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/renderer/media/webrtc_audio_device_impl.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/renderer/media/webrtc_audio_device_impl.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/renderer/pepper/pepper_graphics_2d_host.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/renderer/render_thread_impl.h
[modify] https://crrev.com/959fb256dce4f0b1dffa1df094cdff0fc3c7040c/content/renderer/scheduler/resource_dispatch_throttler_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cb60b7462c7cb00758eb6108385c86e689e375b

commit 9cb60b7462c7cb00758eb6108385c86e689e375b
Author: lukasza <lukasza@chromium.org>
Date: Tue Apr 19 22:59:48 2016

Removing unused field - AppCacheResponseIO::group_id_.

Removing the unused field allows cascading removals of other code that used to
pass group id value around (but not actually using the value).

BUG=600434

Review URL: https://codereview.chromium.org/1887153002

Cr-Commit-Position: refs/heads/master@{#388343}

[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_internals_ui.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_request_handler.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_request_handler.h
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_response.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_response.h
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_response_unittest.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_service_impl.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_service_unittest.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_storage.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_storage.h
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_storage_impl.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_storage_impl.h
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_update_job.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_url_request_job.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_url_request_job.h
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/appcache_url_request_job_unittest.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/mock_appcache_storage.cc
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/appcache/mock_appcache_storage.h
[modify] https://crrev.com/9cb60b7462c7cb00758eb6108385c86e689e375b/content/browser/service_worker/service_worker_disk_cache.cc

Status: Assigned (was: Started)

Sign in to add a comment