New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600428 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Task


Previous locations:
monorail:769


Sign in to add a comment

Switch to New External Codesearch

Project Member Reported by aga...@chromium.org, Feb 4 2016

Issue description

See launch plan doc here:
https://docs.google.com/document/d/1-7k5VE5TtSIEzffQ972m-Ekf-XKblKUy6X-jqHSjaDg/edit

We need to:
1) Do a release (agable)
2) Prepare all necessary DNS changes (seanmccullough)
3) Pick a date (all)
4) Ensure bugs.chromium.org/p/chromium/codesearch redirects to cs.chromium.org
5) Send an email announcing the date
6) Commit the DNS changes
7) Wave our hands in the air like we just don't care

This must be completed before the chromium migration, because otherwise code.google.com/p/chromium/codesearch will stop working on that date.
 
This plan looks good, but regarding
>This must be completed before the chromium migration, because otherwise
> code.google.com/p/chromium/codesearch will stop working on that date.

It looks like code.google.com/p/[project]/codesearch is routed to a backend by a L2 GFE rather than the codesite binary.  So, setting the project state to MOVED in codesite will not redirect those URLs to Monorail.  You will need a codesite CL. 
I don't think we actually need a codesite CL; we just need to update some DNS as described in b/26103955#comment24.

But first, we still need to set a date, so we can coordinate that with sliesenberger.
OK, great.  But, then do you still need step 4 in this issue?  I suppose there is no harm in it.
I've gone through a deployment of codesearch. It's easy, and makes sense.

This seems like a very simple switch: we're already using these jobs to serve codesearch, all we're migrating is the DNS configs so that it will be served under cs.chromium.org instead of code.google.com. I propose we set a migration date for Tuesday, Feb 9th.

If we get consensus on that date, I'll put it in b/26103955 and get their feedback.
Small correction: we are not yet using these jobs to serve codesearch, at least if I can trust the monitoring. Codesearch still uses the old codesite jobs, monitoring shows activity there but no activity on the new jobs. As far as I understand, the redirect from cs.chromium.org to code.google.com/p/chromium/codesearch is still active, because cs.chromium.org still maps to the ip address of the apache server that does the redirect.

Comment 6 by aga...@chromium.org, Feb 11 2016

Cc: jparent@chromium.org
Labels: -Priority-High Priority-Medium
jrobbins and akuegel are right -- the /p/chromium/codesearch url is handled by a totally different service, and won't start redirecting to monorail on migration day. As such, this can be pushed until after the migration.

I'm going to leave this in the current milestone so it stays in front of my eyes, but know that it isn't a real blocker.
People will lose the <a> link in the codesite tabs that navigates to /p/chromium/codesearch.
You guys may already know this, but cs.chromium.org still redirects to https://code.google.com/p/chromium/codesearch. It will be awesome when cs.chromium.org does not redirect to code.google.com anymore! Looking forward for when the DNS change will take effect :)

Comment 9 by aga...@chromium.org, Feb 19 2016

Yep, we know this. code.google.com/p/chromium/codesearch is served by a wholly different set of backends than the rest of code.google.com/p/chromium, so switching it is not urgent. But yes, we'll be really excited when it is served directly off of cs.chromium.org as well :)
Labels: -Milestone-Launch Milestone-Afterglow
Friendly ping. What is the latest plan when to get this done? Right now, any changes (like new location of the archives) need to be done to the old version and the new version, and I still need to restart the old jobs to pick up such configuration changes. I cannot really support the old version beyond occasional restarts, and even that I would like to avoid.
Cc: jem@chromium.org philwright@chromium.org
+philwright who might be taking this on.
Cc: aga...@chromium.org dsansome@chromium.org
Owner: dsansome@chromium.org
Had a bunch of discussions, and it looks like dsansome@ is going to be the one who actually executes the steps in https://docs.google.com/document/d/1-7k5VE5TtSIEzffQ972m-Ekf-XKblKUy6X-jqHSjaDg/edit. philwright@ is going through the PRR process for codesearch, and making sure we have all the nice monitoring (both of the frontends and of the processing pipeline) to make this easily maintainable. I'll be working with both of them and with Emma on improvements to both the pipeline and to the display.

Huge thanks to the SYD SRE team for stepping forward and supporting codesite so much!
Sounds great :)
Just to make sure there are no misunderstandings: improving monitoring should not block the transition; the old instance is not kept up-to-date and is essentially unsupported. But I guess you are already aware of that :)
Yep :) dsansome is working on the transition and philwright is working on the PRR in parallel.
Project: chromium
Moved issue monorail:769 to now be  issue chromium:600428 .

Comment 17 Deleted

Comment 18 Deleted

Status: Fixed (was: Accepted)
Wohooo :)
Have an annuncement been sent to chromium-dev? Is the code still private? In practice what the new external codesearch means?
I sent an announcement to chrome-infra-announce when I set up cs-staging.chromium.org, but that was mainly to get people to test I hadn't broken something.  I don't think this needs a broader announcement at this point - there aren't many user-visible changes, it's mostly backend stuff.

Unfortunately the code is still private, yes.  Sadly I don't see that changing since it has lots of internal google-specific dependencies.

In practice this new codesearch means:
1) No more fragment URLs - paths look like /chromium/src/foo instead of /#chromium/src/foo.
2) Pages are served off cs.chromium.org rather than redirecting to code.google.com.
3) There's now a call hierarchy in the xrefs panel.
4) Slightly lower latency if you're in Europe.

But more importantly there are now actually people working on Chromium's codesearch, so you can expect more changes in the future.  In particular I'm currently working on getting git history and a blame layer into the UI.

Sign in to add a comment