ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop fails when run locally on Linux |
||||
Issue descriptionHEAD at 7b1d959bc4e1cae64abdeff2c5baeb9c38c3813b = 384918 gn args: is_component_build = true use_goma = true target_os = "chromeos" enable_nacl = false ninja -C out/Default -j 1000 -l 20 ash_unittests out/Default/ash_unittests --gtest_filter="ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop" [ RUN ] ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop Xlib: extension "RANDR" missing on display ":99". [18546:18546:0404/092655:408285248160:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0x3418f7fde360 Xlib: extension "RANDR" missing on display ":99". Xlib: extension "RANDR" missing on display ":99". ../../ash/shelf/shelf_layout_manager_unittest.cc:2366: Failure Value of: status_area_widget->GetWindowBoundsInScreen().ToString() Actual: "362,453 138x47" Expected: "353,453 147x47" [18546:18546:0404/092655:408285604933:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0x3418f7fde360 [ FAILED ] ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop (459 ms) [----------] 1 test from ShelfLayoutManagerTest (460 ms total) The test looks a little fragile: // Shelf should be in the first display's area. // TODO: make this test more robust against changes in font, font size. EXPECT_EQ("353,453 147x47", status_area_widget->GetWindowBoundsInScreen().ToString()); It passes on the bots. I'm not sure why. I wonder if the assertion could be changed to be more liberal, like checking that the status area widget's right edge is < 500, or some such.
,
Apr 5 2016
It failed for me with 1280x800x24 with xvfb-run. It also failed for me when I just ran it on desktop, without Xvfb. I can try it again tomorrow. Maybe I'm doing something wrong.
,
Apr 5 2016
I actually built using gyp, not gn, and also using chromoting. I'll test gn and/or desktop tomorrow.
,
Apr 5 2016
Yeah, still fails for me this morning, both under xvfb-run 1280x800x24 and running without xvfb.
,
Apr 7 2016
Doh, that DCHECK error was because I was building without target_os (which means I was running linux build). It still works for me. Let's look into this together tomorrow.
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8c18394d174db7d105416a87115131a13e1bbb1 commit e8c18394d174db7d105416a87115131a13e1bbb1 Author: oshima <oshima@chromium.org> Date: Thu Apr 07 16:13:47 2016 Make ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop font config independent BUG= 600404 R=jamescook@chromium.org Review URL: https://codereview.chromium.org/1869723002 Cr-Commit-Position: refs/heads/master@{#385774} [modify] https://crrev.com/e8c18394d174db7d105416a87115131a13e1bbb1/ash/shelf/shelf_layout_manager_unittest.cc
,
Apr 7 2016
,
Apr 11 2016
,
May 23 2016
Bulk verified |
||||
►
Sign in to add a comment |
||||
Comment 1 by osh...@chromium.org
, Apr 5 2016