Request to show a password on chrome://settings/passwords that has just deleted from the store crashed the browser |
|||||
Issue descriptionWhat steps will reproduce the problem? (1) Removed a saved password with omnibox icon. (2) Rapidly go to chrome://settings/passwords and remove this password there again (or request to show this password). What is the expected output? Browser crashed. [33199:33199:0404/154239:FATAL:password_manager_presenter.cc(225)] Check failed: false. #0 0x7fec3a9ce69e base::debug::StackTrace::StackTrace() #1 0x7fec3aa29d0f logging::LogMessage::~LogMessage() #2 0x7fec3cdf2b30 PasswordManagerPresenter::RequestShowPassword() #3 0x7fec3cd7460d options::PasswordManagerHandler::HandleRequestShowPassword() What do you see instead? Browser shouldn't crash.
,
Apr 4 2016
If user tries to see a password that has just deleted from store, the check "index >= password_list_.size()" in PasswordManagerPresenter::RequestShowPassword failed. PasswordManagerPresenter have already received a ping to update the lists |password_list_| and |password_exception_list_| (see PasswordManagerPresenter::UpdatePasswordLists), i.e. the lists were cleared, but the login request to the store hasn't finished. So that, the user requests to see some entry, but |password_list_.size()| is zero.
,
Apr 4 2016
I suppose we should remove NOTREACHED()'s (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/passwords/password_manager_presenter.cc&l=223).
,
Apr 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5aba8a4194a67a712de8cf784dd626e9e6809e53 commit 5aba8a4194a67a712de8cf784dd626e9e6809e53 Author: kolos <kolos@chromium.org> Date: Mon Apr 04 15:41:48 2016 [Password Manager] |index| in requests to PasswordManagerPresenter might be out of bounds, because of recent changes in the password store. This CL removes |NOTREACHED()| for such cases. BUG= 600374 Review URL: https://codereview.chromium.org/1855973002 Cr-Commit-Position: refs/heads/master@{#384915} [modify] https://crrev.com/5aba8a4194a67a712de8cf784dd626e9e6809e53/chrome/browser/ui/passwords/password_manager_presenter.cc
,
Apr 4 2016
,
Nov 29
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tkent@chromium.org
, Apr 4 2016