New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 600295 link

Starred by 2 users
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Apr 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
erikc...@chromium.org
█ ashej...@chromium.org
mac-bugs-priority@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to drag and drop bookmarked url.

Reported by dmascare...@etouch.net, Apr 4 2016 
Chrome Version:51.0.2699.0 Revision ced319c78e3f9acc95394d81cc6763ed9a9e8371-refs/heads/master@{#384828}(64 bit)
OS: Mac

What steps will reproduce the problem?
1. Launch chrome and bookmark any webpage.
2. Try to drag the bookmarked url to omnibox or at tabstrip.
3. Observe.

Actual: Unable to drag  and drop bookmarked url.
Expected: Drag and drop of the bookmarked url should be proper (i.e After drag and drop the bookmarked page should get opened)

This is regression issue,broken in ‘M 51’ and below is narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/cd42ba75341213b8995a88274f1858a5274a11a3..c28d985e1f60cece099c984f1e1f8cd0c33c0e14?pretty=fuller&n=100

Suspecting: r 382722 ?

Good build: 51.0.2687.0
Bad build: 51.0.2688.0

Note: Issue is not seen on Windows and Linux OS.
Actual_bookmark.mov
2.5 MB Download
Expected_bookmark.mov
1.9 MB Download

Comment 1 by nyerramilli@chromium.org, Apr 4 2016

Labels: ReleaseBlock-Stable
adding RB-label as this is recent regression, please change if required.

Comment 2 by erikc...@chromium.org, Apr 4 2016

Status: Started (was: Assigned)

Comment 3 by erikc...@chromium.org, Apr 4 2016

Cc: ashej...@chromium.org tkonch...@chromium.org erikc...@chromium.org
 Issue 599522  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6

commit 5c3e79fe151cef7f1ca259a81a655131fdb8b8d6
Author: erikchen <erikchen@chromium.org>
Date: Tue Apr 05 17:32:50 2016

mac: Fix bookmark drag and drop.

The NSPasteboardItem that represents the dragged item needs to include all the
usual pasteboard types associated with URLs. This was broken in a recent
refactor that removed the use of a deprecated APIs.

BUG= 600295 

Review URL: https://codereview.chromium.org/1854223002

Cr-Commit-Position: refs/heads/master@{#385210}

[modify] https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[modify] https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h
[modify] https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm
[modify] https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm
[modify] https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.h
[modify] https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6/chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.mm
[modify] https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6/components/bookmarks/browser/bookmark_pasteboard_helper_mac.h
[modify] https://crrev.com/5c3e79fe151cef7f1ca259a81a655131fdb8b8d6/components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm

Comment 5 by erikc...@chromium.org, Apr 5 2016

Status: Fixed (was: Started)
►

Sign in to add a comment