Most test files added by this patch have been added with an -expected file (which indicates just how many of these tests we are currently failing!). In addition, some tests have been added to the TestExpectations file:
imported/web-platform-tests/web-animations/keyframe-effect/getComputedTiming-progress.html [ Crash Failure ]
imported/web-platform-tests/web-animations/keyframe-effect/getComputedTiming-currentIteration.html [ Crash Failure ]
imported/web-platform-tests/web-animations/animation-effect-timing/endDelay.html [ Failure ]
imported/web-platform-tests/web-animations/animation/constructor.html [ Failure Timeout ]
imported/web-platform-tests/web-animations/animation-node/idlharness.html [ Failure Timeout ]
These five failures are the highest priority to fix.
The current set of TestExpectations failures is:
[ Linux Mac ] imported/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html [ Failure Pass ]
imported/wpt/web-animations/interfaces/AnimationEffectTiming/endDelay.html [ Failure ]
imported/wpt/web-animations/interfaces/Animation/constructor.html [ Failure Timeout ]
imported/wpt/web-animations/interfaces/Animation/finished.html [ Pass Failure ]
imported/wpt/web-animations/interfaces/Animation/oncancel.html [ Pass Failure ]
imported/wpt/web-animations/interfaces/Animation/onfinish.html [ Pass Failure ]
There has not been much progress on this recently due to other project work but I expect to come back to this in the next 2-4 weeks.
imported/wpt/web-animations/interfaces/AnimationEffectTiming/endDelay.html
This failure is because Animation.timeline is not exposed and so a timeline value is undefined (and its expected value changes from run to run, so is not predictable). I prepared a patch (https://codereview.chromium.org/2094213002) which gives us the dubious improvement of making this and another test go from failing to flakily failing.
... And, looking back, I see we had attempted to do this before, but it was reverted due to a test failure which should be covered by the TestExpectation changes in my new patch.
From investigation I did a while ago, I think we need to go over and potentially rewrite our finished promises & event code to make sure that the promises/events are triggering when they are supposed to. I believe all of the pass/fail flakes here are likely to be related to this.
---
imported/wpt/web-animations/interfaces/Animation/constructor.html
This is failing in Debug and timing out elsewhere because KeyframeEffectReadOnly is not defined. Really this should just be failing consistently (the fact that it isn't is I guess due to issue 602886 ). Implementing KeyframeEffectReadOnly will be a fairly substantial patch.
Rechecking expectations:
Looks like interfaces/AnimationTimeline/document-timeline.html is no longer failing. I'll send a CL to remove that line.
No update on the other tests.
From the duplicate bug, the following tests fail on Chrome, pass in Firefox and Edge. Since Edge has not shipped Web Animations support, that's not perhaps as useful an indication as it might otherwise be, but these might still be low-hanging fruit worth looking at:
/web-animations/interfaces/Animatable/animate.html Element.animate() does not accept keyframes with an invalid composite value
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using empty string
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident string with an invalid escape (LF)
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident string with an invalid escape (CR)
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident string with an invalid escape (FF)
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident string with an invalid escape
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident started string with a leading minus and an invalid name-start code point
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident string with an invalid name code point
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident started string with an invalid escape (LF)
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident started string with an invalid escape (CR)
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident started string with an invalid escape (FF)
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident started string with a leading minus and an invalid escape (LF)
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident started string with a leading minus and an invalid escape (CR)
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident started string with a leading minus and an invalid escape (FF)
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident started string with a leading minus and an invalid escape
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if adding leading spaces before the paced property
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if adding trailing spaces
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if adding leading spaces
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if not using the correct keyword
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident started string with an invalid escape
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if using a non-ident started string
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if these is no paced property
/web-animations/interfaces/KeyframeEffectReadOnly/spacing.html Test throwing TypeError if adding trailing spaces after the paced property
Comment 1 by suzyh@chromium.org
, Apr 4 2016