New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 600234 link

Starred by 2 users
Status: Fixed
Owner:
cbiesin...@chromium.org
Closed: Apr 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ tkonch...@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:[Devtools] Some of the types in the sidebar are not visible on collapsing the eventlisteners type in sources tab.

Project Member Reported by radhakri...@techmahindra.com, Apr 4 2016 
Chrome Version       : 51.0.2699.0 (Official Build)
OS Version : Ubuntu 14.04

What steps will reproduce the problem?
(1)Launch chrome and open Devtools on any page.
(2)Open sources tab and expand eventlisteners type in the sidebar until a scrollbar appears.
(3)Now scroll the sidebar down and collapse the eventlisteners type.(please refer video)
(4)now observe the types in the sidebar.

What is the expected result?
After step-3, the total contents of the sidebar should be visible to the user.

What happens instead?
Some of the contents of the sidebar are not visible on collapsing the eventlisteners type.

This is a regression issue broken in M-51.

This issue is seen on windows also.
actual.mp4
1.7 MB Download
expected.mp4
1.2 MB Download

Comment 1 by radhakri...@techmahindra.com, Apr 4 2016

Labels: hasbisect
Owner: cbiesin...@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build:51.0.2697.0
Bad Build :51.0.2698.0

CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/b2c5c9d8120abd6dd8605ab430ad557857f75bda..048b30171ae6db3249101801d814b8f7a4b21c53

Suspecting https://codereview.chromium.org/1846023003 from changelog.

@cbiesinger: Please re-assign if the issue is not related to your change.

Comment 2 by kavvaru@chromium.org, Apr 4 2016

Labels: OS-Mac
Able to reproduce the issue on Mac 10.11.3 using chrome version 51.0.2699.0

Comment 3 by cbiesin...@chromium.org, Apr 4 2016

Status: Started (was: Assigned)
Stupid mistake, helped by a poorly named enum :(

https://codereview.chromium.org/1852293002/
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87c6ba998684a8e2f6866e55e8d6ee5229cbde36

commit 87c6ba998684a8e2f6866e55e8d6ee5229cbde36
Author: cbiesinger <cbiesinger@chromium.org>
Date: Mon Apr 04 18:20:27 2016

Make sure to clamp scroll positions when restoring them

This was an oversight from https://codereview.chromium.org/1846023003

R=leviw@chromium.org
BUG= 600234 

Review URL: https://codereview.chromium.org/1852293002

Cr-Commit-Position: refs/heads/master@{#384957}

[modify] https://crrev.com/87c6ba998684a8e2f6866e55e8d6ee5229cbde36/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Comment 5 by cbiesin...@chromium.org, Apr 4 2016

Labels: Merge-Request-50
Status: Fixed (was: Started)

Comment 6 by cbiesin...@chromium.org, Apr 5 2016

Labels: -M-51 M-50

Comment 7 by tin...@google.com, Apr 5 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)

Comment 8 by gov...@chromium.org, Apr 5 2016 

Please merge your change to M50 branch 2661 before 4:00 PM PST, Today if you like to make it to this week beta. We're cutting Beta candidate today.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 5 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/692af2b8e32dfa078cd26f649e93f560cb5093e1

commit 692af2b8e32dfa078cd26f649e93f560cb5093e1
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Tue Apr 05 17:28:06 2016

Make sure to clamp scroll positions when restoring them

This was an oversight from https://codereview.chromium.org/1846023003

R=leviw@chromium.org
BUG= 600234 

Review URL: https://codereview.chromium.org/1852293002

Cr-Commit-Position: refs/heads/master@{#384957}
(cherry picked from commit 87c6ba998684a8e2f6866e55e8d6ee5229cbde36)

Review URL: https://codereview.chromium.org/1857323002 .

Cr-Commit-Position: refs/branch-heads/2661@{#493}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/692af2b8e32dfa078cd26f649e93f560cb5093e1/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Comment 10 by tkonch...@chromium.org, Apr 6 2016

Cc: tkonch...@chromium.org
Labels: TE-Verified-50.0.2661.66 TE-Verified-M51
Tested the same on win8.1, mac 10.11 and Linux 14.04 chrome version 50.0.2661.66 - All the contents of the sidebar are visible on collapsing the eventlisteners type.

Fix works as expected

Please find the screencast
Recording #29.mp4
497 KB Download

Comment 11 by tkonch...@chromium.org, Apr 6 2016

Labels: -TE-Verified-M51 TE-Verified-M50
Typo in verified label. Correcting it
►

Sign in to add a comment