New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600221 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
hobby only
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 554298



Sign in to add a comment

Rewrite scoped_ptr to unique_ptr in autofill and password manager code

Project Member Reported by vabr@chromium.org, Apr 4 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f8f835affcbb95189c2c6abf6a0811cdbd8347

commit 90f8f835affcbb95189c2c6abf6a0811cdbd8347
Author: vabr <vabr@chromium.org>
Date: Mon Apr 04 11:17:52 2016

components/password_manager: scoped_ptr -> unique_ptr

In response to https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-QucCgAJ, which I hope was not an April Fool's joke. :)

BUG= 600221 

Review URL: https://codereview.chromium.org/1852093002

Cr-Commit-Position: refs/heads/master@{#384881}

[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/content/browser/content_password_manager_driver_factory.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/content/browser/content_password_manager_driver_factory.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/content/browser/content_password_manager_driver_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/content/browser/credential_manager_dispatcher.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/content/browser/credential_manager_dispatcher.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/content/renderer/credential_manager_client.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/content/renderer/credential_manager_client_browsertest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliated_match_helper.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliated_match_helper.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliated_match_helper_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_backend.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_backend.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_backend_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_database.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_database_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_fetch_throttler.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_fetch_throttler_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_fetcher.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_fetcher.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_fetcher_delegate.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_fetcher_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_service.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/affiliation_service_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/credential_manager_pending_request_task.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/facet_manager_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/fake_affiliation_api.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/fake_affiliation_fetcher.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/fake_affiliation_fetcher.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/log_manager.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/log_manager.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/log_manager_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/login_database_ios.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/login_database_ios_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/mock_affiliated_match_helper.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/mock_password_store.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/mock_password_store.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_autofill_manager_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_generation_manager_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_manager.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_manager_client.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_manager_test_utils.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_manager_test_utils.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_manager_util.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_store.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_store.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_store_consumer.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_store_consumer.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_store_default.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_store_default.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_store_default_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_store_factory_util.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_store_factory_util.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_store_origin_unittest.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_store_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_syncable_service.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_syncable_service.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/password_syncable_service_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/psl_matching_helper.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/statistics_table.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/statistics_table.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/statistics_table_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/stub_password_manager_client.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/stub_password_manager_client.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/test_password_store.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/test_password_store.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/webdata/password_web_data_service_win.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/browser/webdata/password_web_data_service_win.h
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/common/credential_manager_types.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/core/common/credential_manager_types_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
[modify] https://crrev.com/90f8f835affcbb95189c2c6abf6a0811cdbd8347/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d1dc9fc06a6f267611fefc9a76032ec29a18015

commit 1d1dc9fc06a6f267611fefc9a76032ec29a18015
Author: vabr <vabr@chromium.org>
Date: Mon Apr 04 12:03:11 2016

chrome/browser/password_manager: scoped_ptr -> unique_ptr

In response to
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-QucCgAJ,
which I hope was not an April Fool's joke. :)

BUG= 600221 

Review URL: https://codereview.chromium.org/1858513002

Cr-Commit-Position: refs/heads/master@{#384885}

[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/native_backend_gnome_x.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/native_backend_kwallet_x.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/native_backend_libsecret.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_manager_interactive_uitest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_manager_internals_service_unittest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_manager_test_base.h
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_manager_util_win.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_factory.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_mac.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_mac.h
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_mac_unittest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_proxy_mac.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_proxy_mac.h
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_win.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_win.h
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_win_unittest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_x.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_x.h
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/password_store_x_unittest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/save_password_infobar_delegate.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/save_password_infobar_delegate.h
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/simple_password_store_mac.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/simple_password_store_mac.h
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/simple_password_store_mac_unittest.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/update_password_infobar_delegate.cc
[modify] https://crrev.com/1d1dc9fc06a6f267611fefc9a76032ec29a18015/chrome/browser/password_manager/update_password_infobar_delegate.h

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967

commit 55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967
Author: vabr <vabr@chromium.org>
Date: Mon Apr 04 14:08:39 2016

chrome/browser/autofill: scoped_ptr -> unique_ptr

In response to
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-QucCgAJ,
which I hope was not an April Fool's joke. :)

BUG= 600221 

Review URL: https://codereview.chromium.org/1857663002

Cr-Commit-Position: refs/heads/master@{#384900}

[modify] https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967/chrome/browser/autofill/autofill_browsertest.cc
[modify] https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967/chrome/browser/autofill/autofill_server_browsertest.cc
[modify] https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967/chrome/browser/autofill/content_autofill_driver_browsertest.cc
[modify] https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967/chrome/browser/autofill/personal_data_manager_factory.cc
[modify] https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967/chrome/browser/autofill/risk_util.cc
[modify] https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967/chrome/browser/autofill/risk_util.h
[modify] https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967/chrome/browser/autofill/validation_rules_storage_factory.cc
[modify] https://crrev.com/55b6132aa2d5d7ebdbfc6f4f6e1cc20ed77e5967/chrome/browser/autofill/validation_rules_storage_factory.h

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0233748dd66fe1517f6a336b559152f2991771c8

commit 0233748dd66fe1517f6a336b559152f2991771c8
Author: vabr <vabr@chromium.org>
Date: Mon Apr 04 15:39:07 2016

components/autofill: scoped_ptr -> unique_ptr

In response to
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/roY78iTblYc/6juu-QucCgAJ,
which I hope was not an April Fool's joke. :)

BUG= 600221 

Review URL: https://codereview.chromium.org/1859453002

Cr-Commit-Position: refs/heads/master@{#384914}

[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/content_autofill_driver.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/content_autofill_driver.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/content_autofill_driver_factory.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/content_autofill_driver_factory.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/content_autofill_driver_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/request_autocomplete_manager_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/risk/fingerprint.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/risk/fingerprint_browsertest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/wallet/full_wallet.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/wallet/full_wallet.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/wallet/full_wallet_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/wallet/payments_client_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/wallet/wallet_address.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/wallet/wallet_address.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/wallet/wallet_address_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/wallet/wallet_test_util.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/browser/wallet/wallet_test_util.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/renderer/password_autofill_agent.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/renderer/password_form_conversion_utils.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/content/renderer/password_generation_agent.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/address_field.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/address_field.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/address_field_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/address_i18n.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/address_i18n.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/address_i18n_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autocomplete_history_manager_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_download_manager_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_merge_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_profile.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_profile_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_save_card_infobar_mobile.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_test_utils.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/autofill_xml_parser_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/country_names.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/country_names.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/credit_card_field.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/credit_card_field.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/credit_card_field_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/crypto/rc4_decryptor.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/email_field.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/email_field.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/form_field.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/form_field.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/legal_message_line.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/legal_message_line_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/name_field.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/name_field.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/name_field_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/payments/payments_client.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/payments/payments_request.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/phone_field.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/phone_field.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/phone_field_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/phone_number_i18n.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/phone_number_i18n.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autocomplete_syncable_service.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autocomplete_syncable_service.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_data_type_controller_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_profile_syncable_service.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_profile_syncable_service_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_table.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_table_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_webdata.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/browser/webdata/web_data_service_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/common/autofill_l10n_util.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/common/autofill_l10n_util.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/common/autofill_regexes.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/common/password_form.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/common/password_form_fill_data.h
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/common/password_form_fill_data_unittest.cc
[modify] https://crrev.com/0233748dd66fe1517f6a336b559152f2991771c8/components/autofill/core/common/save_password_progress_logger_unittest.cc

Comment 5 by vabr@chromium.org, Apr 4 2016

Status: Fixed (was: Started)

Comment 6 by vabr@chromium.org, Jun 6 2016

Labels: -refactoring Hotlist-Refactoring

Sign in to add a comment