New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600214 link

Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 659750
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Use a virtual URL instead of a PluginDocument for loading the PDF extension

Project Member Reported by raymes@chromium.org, Apr 3 2016

Issue description

Currently we load the PDF extension inside a PluginDocument, which triggers loading a mime handler process. This extra process introduces memory and performance overhead. 

In addition to fixing up the virtual URL, we would also have to do a bit of work to pass the original request through to the extension and make saving work. I don't think it would be too hard though. You can see that most things just work by visiting the extension directly:
chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?http://www.cbu.edu.zm/downloads/pdf-sample.pdf
 
Cc: dsinclair@chromium.org

Comment 2 by rob@robwu.nl, Apr 4 2016

Labels: -Type-Bug Type-Feature
Have you already thought about how you're going to synchronize the virtual URL and the committed URL?

This is the flow of opening a PDF URL with an extension:
1. Redirect .pdf URL to chrome-extension://
2. Replace the chrome-extension:// URL in the omnibox with the original URL
3. Process virtual URL changes (by the user) and/or committed URL changes (by the extension).

Last year I proposed an API for step 2, but there are still some open questions concerning step 3: https://groups.google.com/a/chromium.org/forum/#!msg/apps-dev/95IVTx4AiFU/gax8vKlbTD4J
Thanks Rob - I haven't thought about the details and don't really have the time to take this up but some others were interested. I remember you having a proposal - it may well be that we just need to find consensus on what you have :)
Cc: wjmaclean@chromium.org mknowles@chromium.org
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 5 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: ekaramad@chromium.org
Assigning this to ekaramad@ who is already working on the PDF re-design work ... feel free to merge it into any existing tracking bug you may have.
Components: Platform>Apps>BrowserTag Internals>Sandbox>SiteIsolation
Mergedinto: 659750
Status: Duplicate (was: Untriaged)
We are trying to load the PDF extension directly inside the ContentFrame of <ebmed> which means we can keep PluginDocument (we need to support <embed>-ed PDF anyway). Right now we are working on the best design to properly support postMessaging.

Marking this as duplicate of the tracking bug for reworking/removing MimeHandlerViewGuest.

Sign in to add a comment