MacViews: Bookmarks bubble is anchored in the wrong place (top-center instead of top-right) |
|||||||||||
Issue descriptionVersion: Canary 51.0.2698.0 OS: 10.11 What steps will reproduce the problem? (1) Turn on Toolkit-Views Browser Dialogs (Mac) in chrome://flags (2) Click the star icon in the bookmarks bar What is the expected output? The bookmarks bubble/dialog should have an arrow positioned near its top-right corner pointing at the star icon. What do you see instead? There is no arrow. The arrow's position and alignment with the star icon prevents the bubble from overlapping the browser window's right edge. With MacViews enabled, the dialog straddles the window's right edge.
,
Apr 4 2016
There are some recently updated MD mocks for the bubbles in Issue 566115
,
Apr 4 2016
Ugh - I see. I'm not sure that's a great design but I will reserve full judgement until I see it in action. Currently the MD buttons don't maintain their pressed state while the bubble is visible, so that will need to be changed. I will create a separate bug for that. For this bug I guess the bubble still needs to be moved further left, per issue 566115 .
,
Apr 11 2016
,
Apr 14 2016
,
Apr 19 2016
Issue 603394 has been merged into this issue.
,
Apr 20 2016
,
May 18 2016
,
Aug 12 2016
See also Issue 625247 ("MacViews: bubbles should always appear inside the work area") and Issue 603394 ("Regression: Misalignment of Bookmark bubble"). r380411 tickled some codepath to make this happen, but we need to figure out only MacViews was affected. I'll close Issue 625247 , since the new anchoring methodology doesn't involve arrows, and is very specific about alignment with the anchor view (See Issue 635172 and, e.g., http://go/aymwc ).
,
Aug 30 2016
It looks like the bubbles can also fall off the edge of the screen right now — try bookmarking something with the right edge of the window near the right edge of the screen.
,
Sep 14 2016
+elly - see #c9 for context/history/related stuff.
,
Sep 19 2016
Are we going to support RTL for toolbar or anchor point should always be top-right?
,
Sep 19 2016
,
Sep 19 2016
ooer - RTL is a good question. RTL on ChromeCocoa is currently a mess, but it's being worked on. E.g. Currently the bookmark star is on the right on Mac, even in RTL locales, but that may change. See e.g. Issue 642732 ... I couldn't find one discussing the omnibox, but it should probably converge on what RTL does on other platforms already. Toolkit-views should already have some cross-platform anchoring logic in BubbleDialogDelegateView or similar to handle RTL which will do the Right Thing (pun!) without having to add additional logic.
,
Sep 20 2016
,
Sep 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9f2053a36b4899fb312bec01a3362f65eafe785 commit a9f2053a36b4899fb312bec01a3362f65eafe785 Author: eugenebut <eugenebut@chromium.org> Date: Tue Sep 20 22:37:06 2016 [MacViews] Anchor Bookmarks bubble to top-right corner. Currently Bookmarks bubble is anchored to center-top, so its right part may be displayed offscreen. Regression happened after this CL: https://codereview.chromium.org/1759453002/patch/240001/250007 which defer anchoring to LocationBarBubbleDelegateView (which in it's turn uses NONE arrow, and makes center-top anchoring). bookmark_bubble_view.cc was the only bubble that lost its explicit TOP_RIGHT. So other bubbles don't need a similar update. Regression affects MacViews, but not other platforms, because other platforms infer a TOP_RIGHT in location_bar_bubble_delegate_view.cc. MacViews does not, because it's anchored to a point, not a View. This change restores anchoring to top right and does not impact other platforms (tested on Windows). The change makes MacViews version worse in RTL, because omnibox is not mirrored on mac. Since omnibox will be mirrored eventually, leaving it as it is. BUG= 600209 Review-Url: https://codereview.chromium.org/2351593002 Cr-Commit-Position: refs/heads/master@{#419877} [modify] https://crrev.com/a9f2053a36b4899fb312bec01a3362f65eafe785/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by tapted@chromium.org
, Apr 4 2016