New issue
Advanced search Search tips

Issue 600201 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 29
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 525075



Sign in to add a comment

BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor flaky on Win 10

Project Member Reported by wfh@chromium.org, Apr 3 2016

Issue description

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor

fails 50% of the time on win10.

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/101/steps/browser_tests%20on%20Windows-10-10586/logs/BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor

BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor (run #1):
[ RUN      ] BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor
[3012:3368:0403/101508:WARNING:shell.cc(299)] Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
c:uild\slave\win_x64_builderuild\src\chromerowser\uiiewsramerowser_non_client_frame_view_browsertest.cc(43): error: Value of: browser_view->IsActive()
  Actual: true
Expected: false
c:uild\slave\win_x64_builderuild\src\chromerowser\uiiewsramerowser_non_client_frame_view_browsertest.cc(46): error: Value of: frame_inactive_color
  Actual: 1073741824
Expected: theme_inactive_color
Which is: 1560281088
[  FAILED  ] BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor, where TypeParam =  and GetParam() =  (2238 ms)
 
Looks like I need to do something like WidgetActivationWaiter in widget_interactive_uitest.cc.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c15c402bb15f5587b760340e06b0751966dda9da

commit c15c402bb15f5587b760340e06b0751966dda9da
Author: wfh <wfh@chromium.org>
Date: Tue Apr 05 01:30:16 2016

Mark BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor as Flaky on Windows.

BUG= 600201 

Review URL: https://codereview.chromium.org/1857623002

Cr-Commit-Position: refs/heads/master@{#385073}

[modify] https://crrev.com/c15c402bb15f5587b760340e06b0751966dda9da/chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76d646a71434f1ecf0096c7db6fd44b0fe97a7d2

commit 76d646a71434f1ecf0096c7db6fd44b0fe97a7d2
Author: wfh <wfh@chromium.org>
Date: Sat Apr 09 00:16:51 2016

Change a flaky to Disabled.

FLAKY_ prefix seems to do absolutely nothing on the bots, and still turns the bot red, which makes it less easy to know when a real failure happens.

BUG= 600201 
TBR=pkasting

Review URL: https://codereview.chromium.org/1871243002

Cr-Commit-Position: refs/heads/master@{#386258}

[modify] https://crrev.com/76d646a71434f1ecf0096c7db6fd44b0fe97a7d2/chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc

Blocking: 525075
Status: WontFix (was: Assigned)
Dead in refresh.

Sign in to add a comment