New issue
Advanced search Search tips

Issue 600153 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

SpellcheckServiceBrowserTest.StartWithoutLanguages flaky

Project Member Reported by thakis@chromium.org, Apr 2 2016

Issue description

Flaked for me on this try job: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/198481

SpellcheckServiceBrowserTest.StartWithoutLanguages (run #1):
[ RUN      ] SpellcheckServiceBrowserTest.StartWithoutLanguages
[1956:4888:0402/111223:WARNING:shell.cc(299)] Instance: exe:chrome attempting to register an instance for a process it created for target: exe:chrome_renderer without the mojo:shell{client_process} capability class.
e:uild\slave\winuild\src\chromerowser\spellchecker\spellcheck_service_browsertest.cc(148): error: Expected: (nullptr) != (message), actual: 4-byte object <00-00 00-00> vs NULL
e:uild\slave\winuild\src\chromerowser\spellchecker\spellcheck_service_browsertest.cc(241): error: Value of: GetFirstEnableSpellcheckMessageParam()
  Actual: false
Expected: true
[  FAILED  ] SpellcheckServiceBrowserTest.StartWithoutLanguages, where TypeParam =  and GetParam() =  (1275 ms)

(I don't know what the right label for spellcheck service bugs is)
 
Components: UI>Browser>Spellcheck
Labels: OS-Windows
Status: Available (was: Untriaged)
Project "Labels" moved into "Components" field. Spellcheck service bugs go into "UI>Browser>Spellcheck" component.

Comment 2 by groby@chromium.org, Apr 4 2016

While I'm glad it's now properly labeled... Why would this flake at that point? 

InitForRenderer will _always_ send the message, unless there's a context mismatch between RPH and spellcheck, which I really can't see...

My wild guess: MockRPH doesn't properly set the render_process_handle_, which means InitForAllRenderers skips the process?
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 5 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by groby@google.com, Apr 5 2017

Status: Available (was: Untriaged)
FWIW - flakes/fails on Linux too. No time to tackle right now, but should stay around.
 Issue 611029  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69c21abf3a2cf63abbb0adf8dd75cbc06fbab50b

commit 69c21abf3a2cf63abbb0adf8dd75cbc06fbab50b
Author: jkrcal <jkrcal@chromium.org>
Date: Fri Apr 07 15:03:22 2017

[Spellcheck] Disable SpellcheckServiceBrowserTest.StartWithoutLanguages

The test was previously disabled on Windows. It is flaky also on linux.
This CL disables the test fully.

BUG=600153
TBR=rouslan@chromium.org

Review-Url: https://codereview.chromium.org/2803983003
Cr-Commit-Position: refs/heads/master@{#462862}

[modify] https://crrev.com/69c21abf3a2cf63abbb0adf8dd75cbc06fbab50b/chrome/browser/spellchecker/spellcheck_service_browsertest.cc

Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 27 2018

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment