New issue
Advanced search Search tips

Issue 600038 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

git cl patch url fails due to a typo

Project Member Reported by cbiesin...@chromium.org, Apr 2 2016

Issue description

$ git cl patch https://codereview.chromium.org/download/issue1846023003_20001.diff
Traceback (most recent call last):
  File "/usr/local/google/home/cbiesinger/depot_tools/git_cl.py", line 4332, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/cbiesinger/depot_tools/git_cl.py", line 4314, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/cbiesinger/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/cbiesinger/depot_tools/git_cl.py", line 3531, in CMDpatch
    options.directory, auth_config)
  File "/usr/local/google/home/cbiesinger/depot_tools/git_cl.py", line 3556, in PatchIssue
    rietvled_server=match.group(1), auth_config=auth_config)
  File "/usr/local/google/home/cbiesinger/depot_tools/git_cl.py", line 884, in __init__
    self._load_codereview_impl(codereview, **kwargs)
  File "/usr/local/google/home/cbiesinger/depot_tools/git_cl.py", line 892, in _load_codereview_impl
    self._codereview_impl = _RietveldChangelistImpl(self, **kwargs)
TypeError: __init__() got an unexpected keyword argument 'rietvled_server'

Note the typo for rietveld :)
 
Components: -Infra Infra>Git
Owner: serg...@chromium.org
Status: Assigned (was: Unconfirmed)
Sergiy - I assume this has been fixed. Please confirm.
Cc: tandrii@chromium.org
Status: Fixed (was: Assigned)
tandrii fixed it in bf8f75119b79936db6f7acf70aa4e3e55da148b5
Owner: tandrii@chromium.org

Sign in to add a comment