New issue
Advanced search Search tips

Issue 600032 link

Starred by 1 user
Status: Assigned
Owner:
sergeyu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature



Sign in to add a comment

Implement TCP support in ChromiumPacketSocketFactory

Project Member Reported by jamiewa...@chromium.org, Apr 1 2016 
Version: 51.0.2697.0
OS: Linux

What steps will reproduce the problem?
(1) Connect to remoting host using webrtc.

What do you see instead?
[0401/164657:FATAL:chromium_socket_factory.cc(402)] Check failed: false.

Comment 1 by sergeyu@chromium.org, Apr 2 2016 

ChromiumSocketFactory doesn't support TCP sockets. Network traversal API started serving ICE config with TCP-enabled TURN servers, so WebRTC now tries to allocate TCP sockets and fails. To workaround the issue just comment that NOTREACHED() statement. Everything should still work as long as UDP isn't blocked.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae912cd1b889cdfdc5cd85d4878e929dc7d6b3e2

commit ae912cd1b889cdfdc5cd85d4878e929dc7d6b3e2
Author: sergeyu <sergeyu@chromium.org>
Date: Sat Apr 02 01:42:25 2016

Replace NOTREACHED() with NOTIMPLEMENTED() for TCP sockets in ChromiumPacketSocketFactory.

Previously chromoting host wasn't using TCP. Now it may use it for
WebRTC-based connections. Replaced NOTREACHED() with NOTIMPLEMENTED(),
so Debug builds don't crash until TCP support is implemented.

BUG=600032

Review URL: https://codereview.chromium.org/1846133003

Cr-Commit-Position: refs/heads/master@{#384780}

[modify] https://crrev.com/ae912cd1b889cdfdc5cd85d4878e929dc7d6b3e2/remoting/protocol/chromium_socket_factory.cc

Comment 3 by sergeyu@chromium.org, Apr 4 2016

Labels: -Pri-1 -Type-Bug Pri-2 Type-Feature
Summary: Implement TCP support in ChromiumPacketSocketFactory (was: NOTREACHED reached in chromium_socket_factory.cc)
►

Sign in to add a comment