New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 600008 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Remove LayoutView::doingFullPaintInvalidation()

Project Member Reported by wangxianzhu@chromium.org, Apr 1 2016

Issue description

LayoutView::doingFullPaintInvalidation() was an optimization before slimming paint to short-cut per-object paint invalidation. It doesn't make much sense with slimming paint because we do need per-object paint invalidation. Should remove it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c612643f5283dc92d261ca2b359e918b8b9343e4

commit c612643f5283dc92d261ca2b359e918b8b9343e4
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Jun 09 20:50:17 2016

Convert fast/repaint/window-resize*.html into reftests

to make rect under-invalidations more visible, and show
painting/rasterization errors if any.

BUG= 600008 

Review-Url: https://codereview.chromium.org/2039943003
Cr-Commit-Position: refs/heads/master@{#399007}

[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-generated-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-generated-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-non-fixed-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.html
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-media-query-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-media-query-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change1-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change1-expected.txt
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change1.html
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change2-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change2-expected.txt
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change2.html
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-html-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-html-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-width-height-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-width-height-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-bottom-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-bottom-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-percent-top-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-percent-top-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-vertical-writing-mode-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-vertical-writing-mode.html
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-viewport-percent-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-viewport-percent-expected.txt
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-vertical-writing-mode-expected.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f91342dcb2688abf7a5279e35f3d51a9339b0809

commit f91342dcb2688abf7a5279e35f3d51a9339b0809
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Jun 09 22:17:54 2016

Auto-rebaseline for r399007

https://chromium.googlesource.com/chromium/src/+/c612643f5

BUG= 600008 
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2052083002 .

Cr-Commit-Position: refs/heads/master@{#399037}

[modify] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[rename] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/window-resize-vertical-writing-mode-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-vertical-writing-mode-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-vertical-writing-mode-expected.txt

Comment 3 by perkj@chromium.org, Jun 10 2016

Some tests fail on Win and Mac. I will disable 

 crbug.com/600008  [ Win ] fast/repaint/window-resize-centered-inline-under-fixed-pos.html
 crbug.com/600008  [ Win ] fast/repaint/window-resize-vertical-writing-mode.html
 crbug.com/600008  [ Mac Win ] fast/repaint/window-resize-background-image-non-fixed.html 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43175
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/33022


Project Member

Comment 4 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2941d91794aefae42f9ed4c0bf306854799206e3

commit 2941d91794aefae42f9ed4c0bf306854799206e3
Author: Per <perkj@chromium.org>
Date: Fri Jun 10 13:35:28 2016

Disable tests blink LayoutTests
[ Win ] fast/repaint/window-resize-centered-inline-under-fixed-pos.html
[ Win ] fast/repaint/window-resize-vertical-writing-mode.html
[ Mac Win ] fast/repaint/window-resize-background-image-non-fixed.html

BUG= 600008 
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2058743002 .

Cr-Commit-Position: refs/heads/master@{#399173}

[modify] https://crrev.com/2941d91794aefae42f9ed4c0bf306854799206e3/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c612643f5283dc92d261ca2b359e918b8b9343e4

commit c612643f5283dc92d261ca2b359e918b8b9343e4
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Jun 09 20:50:17 2016

Convert fast/repaint/window-resize*.html into reftests

to make rect under-invalidations more visible, and show
painting/rasterization errors if any.

BUG= 600008 

Review-Url: https://codereview.chromium.org/2039943003
Cr-Commit-Position: refs/heads/master@{#399007}

[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-generated-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-generated-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-non-fixed-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.html
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-media-query-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-media-query-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change1-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change1-expected.txt
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change1.html
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change2-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change2-expected.txt
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change2.html
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-html-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-html-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-width-height-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-width-height-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-bottom-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-bottom-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-percent-top-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-percent-top-expected.txt
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-vertical-writing-mode-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-vertical-writing-mode.html
[add] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-viewport-percent-expected.html
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/fast/repaint/window-resize-viewport-percent-expected.txt
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-vertical-writing-mode-expected.txt

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f91342dcb2688abf7a5279e35f3d51a9339b0809

commit f91342dcb2688abf7a5279e35f3d51a9339b0809
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Jun 09 22:17:54 2016

Auto-rebaseline for r399007

https://chromium.googlesource.com/chromium/src/+/c612643f5

BUG= 600008 
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2052083002 .

Cr-Commit-Position: refs/heads/master@{#399037}

[modify] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[rename] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/window-resize-vertical-writing-mode-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-vertical-writing-mode-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[add] https://crrev.com/f91342dcb2688abf7a5279e35f3d51a9339b0809/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-vertical-writing-mode-expected.txt

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2941d91794aefae42f9ed4c0bf306854799206e3

commit 2941d91794aefae42f9ed4c0bf306854799206e3
Author: Per <perkj@chromium.org>
Date: Fri Jun 10 13:35:28 2016

Disable tests blink LayoutTests
[ Win ] fast/repaint/window-resize-centered-inline-under-fixed-pos.html
[ Win ] fast/repaint/window-resize-vertical-writing-mode.html
[ Mac Win ] fast/repaint/window-resize-background-image-non-fixed.html

BUG= 600008 
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2058743002 .

Cr-Commit-Position: refs/heads/master@{#399173}

[modify] https://crrev.com/2941d91794aefae42f9ed4c0bf306854799206e3/third_party/WebKit/LayoutTests/TestExpectations

Cc: wangxianzhu@chromium.org petermayo@chromium.org vasi...@chromium.org wkorman@chromium.org
 Issue 621639  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6967ddd36e55bb1d75ef9f15f64d033a7d27177d

commit 6967ddd36e55bb1d75ef9f15f64d033a7d27177d
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Mon Jun 20 21:23:33 2016

Mark two fast/repaint/window-resize-* tests flaky

BUG= 600008 

Review URL: https://codereview.chromium.org/2082593003 .

Cr-Commit-Position: refs/heads/master@{#400787}

[modify] https://crrev.com/6967ddd36e55bb1d75ef9f15f64d033a7d27177d/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c31119bc5e336b3f827f7c0ad5425b35fa5216f4

commit c31119bc5e336b3f827f7c0ad5425b35fa5216f4
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Jun 23 20:13:20 2016

Remove LayoutView::doingFullPaintInvalidation()

It was an optimization before slimming paint to shortcut per-object
paint invalidation. Remove it because we do need per-object paint
invalidation.

BUG= 600008 

Review-Url: https://codereview.chromium.org/2084723002
Cr-Commit-Position: refs/heads/master@{#401697}

[modify] https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4/third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js
[modify] https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4/third_party/WebKit/Source/core/layout/LayoutView.h
[modify] https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4/third_party/WebKit/Source/core/layout/api/LayoutViewItem.h

Cc: -petermayo@chromium.org -vasi...@chromium.org
Status: Fixed (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71bd10be6ccfe9e388a883b5de368ed2fe43f36d

commit 71bd10be6ccfe9e388a883b5de368ed2fe43f36d
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Jun 23 21:40:41 2016

Auto-rebaseline for r401697

https://chromium.googlesource.com/chromium/src/+/c31119bc5

BUG= 600008 
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2091123002 .

Cr-Commit-Position: refs/heads/master@{#401731}

[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-body-appear-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/scrolled-iframe-scrollbar-change-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/shift-relative-positioned-container-with-image-addition-expected.txt
[copy] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-generated-expected.txt
[delete] https://crrev.com/7406e5cc96b7860cfbd508f4e0338dc35fce9d15/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/window-resize-media-query-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change1-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change2-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-html-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-width-height-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-bottom-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-percent-top-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/fast/repaint/window-resize-viewport-percent-expected.txt
[add] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/android/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/linux-precise/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/linux/compositing/squashing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/overflow-scroll-body-appear-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-scrollable-iframe-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/shift-relative-positioned-container-with-image-addition-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[rename] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-vertical-writing-mode-expected.txt
[delete] https://crrev.com/7406e5cc96b7860cfbd508f4e0338dc35fce9d15/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/window-resize-background-image-fixed-centered-expected.txt
[delete] https://crrev.com/7406e5cc96b7860cfbd508f4e0338dc35fce9d15/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[delete] https://crrev.com/7406e5cc96b7860cfbd508f4e0338dc35fce9d15/third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/mac/compositing/squashing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/resize-scrollable-iframe-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[rename] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/win/compositing/squashing/iframe-inside-squashed-layer-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/win/fast/repaint/line-flow-with-floats-9-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/win/fast/repaint/resize-scrollable-iframe-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[delete] https://crrev.com/7406e5cc96b7860cfbd508f4e0338dc35fce9d15/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-background-image-fixed-centered-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-background-image-fixed-centered-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[delete] https://crrev.com/7406e5cc96b7860cfbd508f4e0338dc35fce9d15/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt
[delete] https://crrev.com/7406e5cc96b7860cfbd508f4e0338dc35fce9d15/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-vertical-writing-mode-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt
[modify] https://crrev.com/71bd10be6ccfe9e388a883b5de368ed2fe43f36d/third_party/WebKit/LayoutTests/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt

Labels: -Pri-3 Pri-1
Status: Assigned (was: Fixed)
This test is flaky now:  https://crbug.com/622892 
Cc: kochi@chromium.org
 Issue 622892  has been merged into this issue.
Status: Fixed (was: Assigned)
Let's track the flaky test in  bug 622892 .
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c2c10a176436c4be12b4a7f02741656415c98c4

commit 1c2c10a176436c4be12b4a7f02741656415c98c4
Author: ellyjones <ellyjones@chromium.org>
Date: Fri Jun 24 19:37:40 2016

Mark focus-controller-recursion-crash.html as flaky

BUG= 600008 

Review-Url: https://codereview.chromium.org/2091363002
Cr-Commit-Position: refs/heads/master@{#401934}

[modify] https://crrev.com/1c2c10a176436c4be12b4a7f02741656415c98c4/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccdbeb9ac61c65a33065a79314868bceb59a864d

commit ccdbeb9ac61c65a33065a79314868bceb59a864d
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Jun 24 21:25:55 2016

Deal with my NeedsManualRebaselines

Rebaseline paint/invalidation/animated-gif* and restore the original
expectations. Just remove NeedsManualRebaselines for the tests that
have been passing on all bots for some time.

TBR=wangxianzhu@chromium.org
BUG= 622892 , 600008 ,619103, 619630 , 617799 

Review URL: https://codereview.chromium.org/2097173002 .

Cr-Commit-Position: refs/heads/master@{#401978}

[modify] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-expected.txt
[modify] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-offscreen-expected.txt
[modify] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-expected.txt
[add] https://crrev.com/ccdbeb9ac61c65a33065a79314868bceb59a864d/third_party/WebKit/LayoutTests/platform/android/paint/invalidation/animated-gif-background-offscreen-expected.txt

Sign in to add a comment