New issue
Advanced search Search tips

Issue 60 link

Starred by 228 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2009
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Add "Remove" to the menu on items in the download bar

Reported by evgeny.z...@gmail.com, Sep 2 2008

Issue description

Product Version      : 0.2.149.27 build 1583
URLs (if applicable) :

What steps will reproduce the problem?
1. Download any file
2. Click the down arrow near the file
3. ooops ... no way to get rid of it

What is the expected result?
Some method to get rid of downloaded files. Common use case is downloading 
a file, running it, then trashing it -- there is no way to trash files from 
within chrome. It requires opening the folder where it downloaded the files 
and deleting it from there.


 
1) With the download bar open, click "Show all downloads..."
2) Right-click on a specific download and choose "Remove"

But maybe the "Show all downloads..." step could be avoided.
As in Firefox, this will remove the listing, not the file itself. But an option to 
remove the file would be apreciated.
Agreed, an option to remove the file (from the list, with perhaps an optional prompt 
to delete the file from the hard drive) should be in the list of options for every 
download.  While we're on that subject, a "Delete All" option should be present, with 
predictable functionality.

Comment 4 by deanm@chromium.org, Sep 3 2008

Labels: -Type-Bug Type-Feature
Maybe a button along the download toolbar that says "Remove Recent Downloads" would 
be good ?
Agreed, bottom download bar feels 'incomplete' without a quick method to remove 
individual items or clear all.

Comment 7 by sbtk...@gmail.com, Sep 3 2008

+1
It could even be implemented as a menu option when right clicking the file, but some 
method is required. 
+1, a 'clear all finished' option or 'delete from disk' option would be nice

Comment 9 by Deleted ...@, Sep 3 2008

you should be able to select from a menu.

remove->from list
      ->file

choosing file would obviously remove from list.
Labels: -Pri-2 -Area-Unknown Pri-3 Area-BrowserUI
Status: Untriaged
+1
Star the issue instead of saying +1
Since  issue 892  was duped to this one, I'll put the relevant details here:

Problem: Chrome automatically downloads a file right away without prompting the user.

(This is *not* the same as "Ask before download where to save file".)

Currently, download links already work under the assumption that the file *will*
be downloaded, only with the option to specify the location as opposed to the default
download folder.

There should be a step before, which clearly prompts if the file will be downloaded
at all, either to my computer, Open, Save, or Cancel.

With respect to other browsers:  Safari 3 - OK, Firefox 3 - OK, IE 7 - OK.
@bksening
actually you can change that under options in chrome, so it asks whether you want to download a file or not
@evgeny
No, you cannot change that.  I specifically said: This is *not* the same as "Ask 
before download where to save file".  (Specifically Chrome calls it: "Ask where to 
save each file before downloading".)

The option is asking for *where* to save the file.

I'm saying Chrome needs to ask *permission* to save the file or not.
Firefox actually does exactly the same thing (begins downloading the file before you 
pick where to save it to.)

-[Unknown]
I just re-tested this again for FF 3.0.1.

When clicking a ZIP download link, the first thing that happens is a popup that says 
"What should Firefox do?" Open , Save, or Cancel.

When clicking an EXE download link, the first thing that happens is a popup that says 
"You have chosen to open" Save or Cancel.

To me, that seems like prompt before *any downloading* even happens.

@unknownbrackets
I know that is not exactly what you said, which is "begin downloading before you pick 
*where* to save".
But I don't think Chrome does the same thing as Firefox.
bksening,

As soon as you click on a download link, the contents (entity body) start downloading.  Firefox puts this 
in a file in the temp dir.  I'm almost certain Opera does the same (and has done since before Firefox.)  
Chrome acts similarly.

This is usually considered a positive feature, because it means that even if it takes you a minute to 
figure out where you want the file, it was already downloading during that time.  It may already be done 
even!

Since it's saved to a temporary file, with an obfusicated name like 1234.tmp, I don't understand the 
worry about allowing the download.  If you cancel it, the temporary file is deleted, and no harm done.  
The file is never marked executable or given an executable extension.

Again, this is exactly the behavior of Firefox.  In fact, my concern is that Chrome may suffer from this 
bug (which is a common downfall of this behavior):

https://bugzilla.mozilla.org/show_bug.cgi?id=224692

-[Unknown]
I totally agree and understand what unknownbrackets is saying about the temp file 
downloads, and I have no problem with that.

However, that is not my bug report, which is: Chrome automatically downloads a file 
right away -->as the actual, *REAL* download<-- without first prompting the user.

Let's put it this way: (assuming the "ask where to save downloads" is OFF)

Expected result: (Safari, Firefox, IE all OK for this)
1. Click on a link that downloads a file.
2. A clear *popup* appears: Do you want to Open, Save, or Cancel.
     (YES, this *still* needs to happen even if "ask where to save" is OFF)
3. If Save is selected, file is saved to default download folder (or, Open from temp 
copy, or Cancel).

Actual result:
1. Click on a link that downloads a file.
2. File is saved right away to default download folder.

As well, for "ask where to save downloads" is ON:

Expected result: (Safari, Firefox, IE all OK for this)
1. Click on a link that downloads a file.
2. A clear *popup* appears: Do you want to Open, Save, or Cancel.
3. If Save is selected, a second popup asks for the save location.
4. File is saved to selected location (or, Open from temp copy, or Cancel).

Actual result:
1. Click on a link that downloads a file.
2. A popup asks for the save location.
3. File is saved to selected location.


Comment 20 by Deleted ...@, Sep 6 2008

Not a bug, just a little feature that would make a difference. I should be able to 
use de DELETE key to delete a download list entry.
bksening,

Okay.  I understand now, and I think that's a separate bug from this one (which might 
be solved by this one.)

Either the developer who duped it misunderstood you, as I did, or thought the best 
resolution was to allow you to delete it afterward (maintaining the quick/dialog-less 
downloading feature.)

IMHO it was better as a separate bug, which might depend on this one.  Once this was 
fixed it could be revisited to ensure and verify the separate use case.

-[Unknown]

Comment 22 by Deleted ...@, Sep 14 2008

Hi,

 First, downloading when a user clicks on a file is exactly what it should happen, no 
extra questions, just download the file.

 Second, deleting the file from the hard disk should not be a feature in chrome, 
leave this stuff to a file manager (windows explore, totalcmd)

Calin,

Comment 23 by Deleted ...@, Sep 14 2008

Hi,

 First, downloading when a user clicks on a file is exactly what it should happen, no 
extra questions, just download the file.

 Second, deleting the file from the hard disk should not be a feature in chrome, 
leave this stuff to a file manager (windows explore, totalcmd). 
 Delete the file from the delete list when you press delete that is nice, same should 
happen to recent history.

Calin,

Comment 24 by Deleted ...@, Sep 21 2008

downloading sometimes doesn't resume and there is no way I could delete a brocken 
download in a straight way ...I hap to open the folder and delete that specific file 
.
That's bad UI :(
I would prefer a separate extension for chrome which handles downloads like https://addons.mozilla.org/en-US/firefox/search?q=download+manager&cat=all 

Comment 25 by Deleted ...@, Sep 26 2008

@bksening

I totally Agree With this. Would stop Accidental downloads or even forced downloads 
when you visit a web page.



I just wish there was a way to set it so that the downloads to clear off the bottom 
of my screen when they're done. 
Labels: Mstone-X
Status: Available

Comment 29 by brian@chromium.org, Oct 16 2008

Labels: -Pri-3 Pri-2
I'm interpreting this as a feature request to add a "Remove" option to the pulldown 
on items in the download bar. It's a relatively small change and one that might be 
pretty useful so I'm bumping to P2.

Comment 30 by brian@chromium.org, Oct 16 2008

Summary: Add "Remove" to the menu on items in the download bar
Please give the user the option to make downloads clear from that bar automatically 
when they're done ... that would be nice.

Comment 32 by deze...@gmail.com, Oct 20 2008

This issue is waiting for the review.
http://codereview.chromium.org/7525/show

Best regards
Need function to clear download list. May be variants: delete all successfully 
downloaded items, delete all successfully downloaded and cancelled items (i.e. items 
that currently isn't being downloaded) and may be delete all items. First variant is 
most necesary.
Also ability to delete items from download list with "Delete" or "Backspace" key will 
be nice.
No doubt, it will be usefull for some one if all delete functions (existing and 
described above) has to options: delete only items from list and delete files from 
disc also. But it can be realised crearly, without annoying questions and so on.

Comment 34 by pil...@gmail.com, Jan 3 2009

Would be nice if the current downloads were always moved to the top like in most 
other browsers so it was easier to keep track / remove invalid ones.

A Clear all finished type button would be helpful too.

Comment 35 by sco...@gmail.com, Jan 5 2009

I, personally, would prefer if the download tab was kept 1:1 with the files in the 
downloads folder. Instead of removing items from the download tab, the user could 
just delete from the filesystem.

Most of the files I download are installers, and I almost always want to trash the 
files when I'm done installing. An option to 'archive' files to a separate folder 
should mitigate any alternate use cases.

Comment 36 by Deleted ...@, Feb 16 2009

There should be a "remove all completed downloads" option,

Comment 37 Deleted

Labels: HelpWanted
I am supporting the possibility of removing the history of downloaded files behind the 
mediation of clicking with mouse. In the bookmark of downloaded files to add options 
"Remove all remove all completed downloads". I thank and I am greeting. 
This issue is a mess. It contains three separate issues:
1. request for an option to delete downloaded *file* (as in "the actual physical file 
on the hard disc"), which is the original issue
2. request for an option to remove an item from download history. Only an individual 
item, not the entire download history (which exists in "Clear browsing data")
3. request for an option to ask users before downloading. Someone merged it here, but 
it has nothing to do with the above. I really don't know why it was merged here.

All in all, those are three separate issue which have (almost) nothing in common, and 
should therefore be separated.

Now, regarding the original issue (my number 1 - deleting the downloaded file) - I 
would agree with it. It would also be a convenient workaround for the numerous "save 
or open a download" questions, because it will allow a fast way to delete 
"temporarily" downloaded files.
Summary: Add "Delete from disk" to the menu on items in the download shelf
this should be more clear now
....
this issue is only about deleting *from disk* using the *download shelf*

for "Remove from list"/"Delete from disk"/"Locate on disk" in the *Downloads page*, see 
 Issue 15551 

for opening a download instead of saving, see  Issue 9023 

Comment 42 by mhm@chromium.org, Jun 29 2009

Summary: Add "Remove" to the menu on items in the download bar
The summary should still be the same, "Delete from disk" isn't a proper term for 
downloads, our UI team decided to use "Remove", please check with the UI team before 
making UI naming decision changes. 

Keeping the old summary of what Brian (one of our UI engineers) stated. This is about 
removing an item from the download shelf not deleting. For deleting refer to another 
 issue 15551  (for a feature request).


The original request in this issue is deleting the downloaded file:
(quoting the OP) "there is no way to trash files from within chrome. It requires opening 
the folder where it downloaded the files and deleting it from there."

So, apparently, this issue is about "deleting the file by using the download shelf". (or 
at least it was about that at the moment it was written). "Removing an item from the 
download shelf" should be a separate issue.

Comment 44 by rcdai...@gmail.com, Jun 30 2009

I agree that this particular issue is in regards to removing the physical file from 
the filesystem through Chromium's interface (More specifically, the download bar). 
However, I do not believe "Remove" is a good name for that menu item. "Remove" 
implies to me that only the history item will be removed (The button itself), and the 
file will remain on the system. Something like "Delete File" would be more 
appropriate. Don't forget to provide a confirmation dialog:

"Are you sure you want to delete this file from the filesystem?"
"Yes"     "No"
 Issue 1651  is the RFE to drop items from the download shelf.

Comment 46 by Deleted ...@, Jul 13 2009

http://docs.google.com/View?docID=ddwscr86_3gf6phhv6
Here is a good design doc, imo
Taken from  issue 4715 
I think it might be risky (at least for novice users who might inadvertently delete 
files). May be a "Locate/show on disk" option would be good -- it'll open the folder & 
show the file, and the user can decide what to do with it. Just my opinion.
To clarify, I'm commenting about the "delete from filesystem" option, and not the 
"remove from list" option.
I believe it's not the browser's job to remove files from the filesystem. The "remove" 
option should only clear items from the browser's download list.

Comment 50 by rcdai...@gmail.com, Jul 15 2009

zugurudumba:

If it's not the browser's job to remove files from the FS, I guess it shouldn't be 
adding files either? I do not agree with you. I think if the browser has taken it 
upon itself to interact with the filesystem to create files (When downloading), then 
it should have the privilege of removing those files that it created as well.

You speak of this issue as if the browser can remove *any* file from the filesystem, 
when this is in fact not true. Its interaction with the filesystem is limited to only 
those things that it has control over (Its own data files, user downloads, etc).

If the browser cannot remove files from the filesystem, then it cannot manage its own 
data, you cannot clear the cache and temporary files, or anything else.
> May[]be a "Locate/show on disk" option would be good

I guess there is already an open folder option: if that could
highlight the file it would be an improvement.

If you delete the file there it will typically be moved to Trash
and so still be around a bit longer if the user changes their mind.
@rcdailey: I'm sorry, I should have said "it's not the browser's job to remove user 
downloads from the filesystem". Just like in Firefox. Or just as Chrome's current 
behaviour: clearing the download list does not remove the downloaded files from the 
disk.
I'd rather add an option named "Move to trash" that would simply put the file into
the trash... no confusion, when clicking on the option you would know exactly what to do.

I pass my days "opening the containing folder" and deleting by hand the installation
programs I download. I don't have to explain that it's a pain in the a** to do this
every time I download a file.

Comment 54 by rcdai...@gmail.com, Jul 16 2009

@zugurudumba:
I still don't agree. If the browser is already removing files from the FS at your 
request, such as the cache, then it obviously has the right to remove other files at 
the user's request, such as their downloaded files. I think this is a fairly black & 
white issue (For consistency's sake)

Also, it's a bit irrelevant as to what other browsers do. Chromium is independent and 
I would prefer the developers choose to be innovators instead of duplicators. Just 
because Firefox, IE, or Opera don't do it doesn't mean that Chromium shouldn't do it.

Now if Chromium never gave the user a reason to want to delete files, then this 
wouldn't be an issue. For example, give the user an option to just *open* a download 
and not actually persist it to the user's download directory. This doesn't completely 
eliminate the need to delete files through Chromium (Every user is different), but it 
substantially reduces the need.

@emmanuel.cron

I don't think that's possible. There is no 'trash' on Linux. And if Chromium is to be 
portable it can't support that. It could either implement its own "trash" feature 
(Which I don't recommend), or it could special-case Windows and use the recycle-bin 
where it is available on a particular platform.
@rcdailey
there is no Trash on windows too.. its just an ordinary directory where the 
windowmanager moves files the user wants to be "deleted".
On both big Windowmanagers (KDE and Gnome) this is used in similar ways.. of course, if 
you use something really usefull like Windowmaker you will be doomed to either create 
your own trash-dir or really delete the files
> There is no 'trash' on Linux.

Well yes and no: the major desktops like GNOME and KDE, etc all support "~/.Trash/".

"Open" is good to have yes, though to be honest with Firefox I often find myself
downloading files again which I opened once before: also I wish browsers would
know that I have already download a file which I am attempting to download again
rather than downloading again but that is harder I guess.
> also I wish browsers would know that I have already download a file which I am 
attempting to download again

oh by eris.. how i wish i could continue files by clicking on the same links instead of 
saving them again as <filename>(n+1).<ext> -.-
@ rcdailey: Totally agree on the 'trash' support. Chromium could offer the
possibility to move the file to the trash if the system (desktop) supports it.

By the way, as you say, every user is different: I actually never use the 'Open'
option since I want to be sure that the file is really deleted after I have reviewed
it. And I am not pretty sure this is the case if your browser crashes for example;
thus, I prefer downloading the file first and opening/deleting it afterward manually.

Comment 59 by rcdai...@gmail.com, Jul 16 2009

@drazraeltod
Yes, there is a "Trash" concept on Windows, and it's called Recycle Bin. It's just a 
concept, after all. The implementation obviously may vary and can take many forms. 
How Windows implements this feature is irrelevant. What matters is that the OS 
provides support for this feature.

On Linux, yes, it's supported through the desktop environments. I was thinking about 
linux as a single entity though. When you install the Linux kernel, you do not get 
this feature out of the box. Doesn't matter, though, because you can't use Chrome 
without a desktop manager anyway. Good point, though!

Anyway, this is getting a bit off-topic so I do apologize. End of conversation :)
@rcdailey

Cache files and/or temporary files are disposable. They're created by the browser as 
it sees fit in order to provide the best experience for the user. User downloaded 
files are not the same as cache files. These are files the user specifically directs 
the browser to download. While cache files are a means to an end, user downloaded 
files are an end by themselves.

I agree with you that this is a black and white issue, because different people have 
different needs. However, it matters what other browsers do, if Chrome wishes to 
compete with them. People are mostly switching to Chrome, so it's fairly safe to 
assume Chrome users are accustomed with browsing conventions used by other browsers. 
One such unwritten rule is that removing a file from the download list does not 
remove it from the filesystem and does not even send it to the Recycle Bin. Changing 
such an old unwritten rule just "because" cannot be labeled as innovation, especially 
since we're dealing with potential data loss. Imagine the discomfort and unknowing 
user might experience when it is revealed that the file that has just been downloaded 
and cleared from the list has in fact been moved to the Trash or worse, permanently 
removed from the filesystem (there are people who disable the Trash feature). This is 
an unacceptable outcome and I can see no advantage to counter it. I suggest you offer 
a good, solid reason to empower Chrome with this feature. Otherwise, it's not safe at 
all to do things differently without gaining something.

You might be familiar with the Alt+D keyboard shortcut. It works in Internet 
Explorer, Mozilla Firefox and Google Chrome. When Alt+D is pressed, it changes focus 
to the address bar while selecting the whole text inside. IE was the first to 
implement it. The Firefox team decided to do the same thing, even if it violated the 
GNOME Human Interface Guidelines, just because too many people were used to it. 
Chrome did the same, I assume for the same reasons. Changing the keyboard shortcut to 
something else in Chrome would have been detrimental. Same with the issue we're 
discussing here. There might be no apparent reason browsers today cannot remove user 
downloaded files from the filesystem, but implementing this might make a lot of 
people unhappy.

Having an "Open" or "Run" option could be a nice touch, but removing the download 
list altogether would be IMHO a crippling move. Please be aware that I might have 
misunderstood your last paragraph.
@ zugurudumba: I don't understand why you want to change the behavior of the "Remove
from list" option. I was not talking about this option, but rather a new one called
"Move to trash" (for example) on desktops that support this feature and that would
completely remove any ambiguity between the two options.

It may even be an activable option ("Allow downloaded files to be moved to trash").

Comment 62 by rcdai...@gmail.com, Jul 16 2009

@zugurudumba

Yes, Cache files are disposable. But if you mean to imply that user downloaded files 
are not disposable, you would be only half correct. By default, the browser should 
treat all user downloaded files as non-disposable. However, it should NOT enforce 
this. It is up to the user to decide of a file is disposable or not.

Furthermore, it only makes sense for the browser to provide an intuitive and 
convenient method of deleting disposable user downloads, since it already provides 
convenient support for creating them (Downloads).

If the browser does not support deleting files it placed on the filesystem, that's 
border-lined malware. This may seem extreme, but think about the principles for a 
minute. It's placing files on your hard drive without giving you any other option. 
It's FORCING you to place downloads on your hard drive and not giving you any ability 
to remove it through that program. While its intentions are obviously not malicious, 
the functionality itself is very similar to what typical malware will do.

The point is, it's annoying. I don't want to have to pull up a third-party FS 
browser, locate the directory the file is in, and have to delete it. I don't even 
want to have to click an "Open containing directory" feature in Chromium to 
conveniently take me there. There's a lot of tedious steps involved, and for quick 
accidental downloads or temporary files, it makes perfect sense to have a "Delete 
from Filesystem" option available through chromium.

In conclusion, user downloaded files have a more dynamic and globally undefined 
meaning compared to something like cache files. Having said this, Chromium can not as 
easily make assumptions about how to handle these files. The best thing Chromium can 
do for this situation is provide an abundant set of practical options and let the 
user decide what path is best taken for that file. Keep in mind that what is 
"practical" here is defined by the community. Obviously if 70% of the Chromium 
community find that a "Remove from Filesystem" option would be useful, then that's a 
practical feature.

In terms of competition, the only reason competition exists is due to differences in 
goals and feature sets. Having said that, if Chromium made ever effort to be like 
other browsers it would not compete very well. Conceptually, there is a certain 
feature set expected from a browser. Obviously it needs to parse HTML, render web 
pages, and so on. Outside of those expectations, however, Chromium is in its own 
right. It can do whatever it wants. What I mentioned earlier was not to ignore other 
browsers completely, but to not duplicate their feature sets. If the Chromium 
community happens to "vote" for a specific feature and it gets implemented in 
Chromium, then it wasn't because the chromium developers duplicated a feature from 
another browser- it was because the community asked for it.

You seem to imply that one bad thing about allowing chromium to delete user downloads 
is that it is error prone and potentially dangerous. It doesn't have to be. Keep in 
mind that removing the file is not a replacement of removing the item from the 
download list. It's a supplement. I would expect both features to be available. 
Additionally, the "Remove from Filesystem" feature should be made fairly accident-
proof. Confirmation dialogs are a good example of how to make it a bit fool-proof.

You asked me to find a good solid reason to want this feature. There's two 
fundamental reasons. First off, as far as principles go it doesn't hurt. I've already 
established that Chromium is already deleting/modifying data in such a way that 
justifies the addition of this feature. You worry that deleting a file through 
chromium is dangerous, but I can just as easily delete my bookmarks on accident and 
never get them back, or delete my saved passwords and not be able to get them back. 
Secondly, because I want it. Keep in mind that Chromium's features are highly based 
on community needs, which I think is great. While I personally would find value in 
this feature, not everyone will. I expect that if enough people like this feature 
that it should be implemented. And those that did not vote for it can simply ignore 
it and it won't bother their daily use of the browser.

Also, your CTRL+D example is backwards. That was a feature that existed in Firefox 
but did not exist in IE. This is similar to a feature that would only exist in 
Firefox and not in IE. Not the same at all. Someone moving to Chromium from Firefox 
isn't going to be expecting Chromium to have the ability to remove user downloads 
from the FS because it was never in Firefox. This is not to say that they will be 
surprised in a bad way, it just means they will have that one new feature available 
to them if they choose to use it. But if they choose not to use it, it will not 
interfere with the user experience.

I can't (and don't want to) change your mind. I only argue for this feature out of 
passion and nothing more. I only expect this feature to get implemented if the 
community feels it is important as a whole.

Comment 63 by rossc...@gmail.com, Jul 16 2009

Just to add to the conversation my own $0.02...

"Moving to trash" might be annoying for people (like me), who have the option set in 
windows which says "Do not move items to the trash, just delete them immediately".  
I personally hate that "recycle bin" junk, and would disable it completely if there were 
such an option.   "Delete from Disk" would be very useful, and I would use that often.

Maybe if we can detect if that option is set, and if it is, rename the "Move to Trash" 
option to "Delete From Disk".

Another option is to just move the file into the cache instead of deleting it, and 
treated it just like any other cached file?

Just ideas...

Labels: Downloads
@rcdailey

I appreciate your position and I can see why you want this feature. I stand by my position and will 
continue to argue that a "delete from disk" option in Chrome/Chromium would be dangerous and against 
current browsing habits of most users.

Ultimately, the decision is Chromium developers' to make, based on community feedback or on what 
they think it's best for the users. I'm eager to find out what the outcome will be. I'm sure the 
developers will try to please everyone.

As a note, I clearly remember the "Alt+D" shortcut (not "Ctrl+D") and its function being present in 
Internet Explorer 6 since its release in 2001. Maybe it was present in 5.5 too. First Firefox public 
binaries appeared in 2002, so there's no way the IE people copied the feature from Firefox.

@emmanuel.cron

I'm very comfortable with the "Clear list" option in the Download Manager, in its current 
incarnation. rcdailey is the one who purposed this feature be changed so that files can also be 
removed form the disk / sent to trash directly from within Chrome.

Cheers.

Comment 66 by rcdai...@gmail.com, Jul 16 2009

@zugurudumba

Sorry, I typed it backwards. I meant to say that IE had the feature before Firefox, 
so users going from IE -> Firefox would have expected the feature. This specific 
feature is like something that exists only in Firefox and not in IE (Like addons for 
example). Someone going from IE -> Firefox would not be expecting the addons feature 
since it did not exist in IE, and this is more or less like what is happening here.

Also, keep in mind that if you cancel a download in progress the browser removes the 
file from the filesystem. This is probably the best example of why removing a 
completed download is justified.

The developers have been pretty good about implementing a feature and keeping it 
around for a while to see how good it does. Then, later, they may remove it or keep 
it depending on results. I like this aspect of Chromium's development.

Comment 67 by brian@chromium.org, Jul 17 2009

To further clarify on comment 29, this menu item would merely remove the item from the 
download shelf and the downloads list in Chrome. To make it clear that this does not 
delete from the user's disk, the menu item should be called "Remove from list". The 
downloads page (ctrl+d) should have the same function with the same name.

Comment 68 by brian@chromium.org, Jul 17 2009

 Issue 1651  has been merged into this issue.

Comment 69 by mhm@chromium.org, Jul 18 2009

Labels: -HelpWanted Size-Small
Status: Started
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=22138 

------------------------------------------------------------------------
r22138 | mhm@chromium.org | 2009-07-30 19:54:54 -0700 (Thu, 30 Jul 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=22138&r2=22137
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/downloads_dom_handler.cc?r1=22138&r2=22137
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/downloads_dom_handler.h?r1=22138&r2=22137
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/downloads_ui.cc?r1=22138&r2=22137
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/downloads.html?r1=22138&r2=22137

Add "Remove from list" for each download in domui page.

A "Remove from list" link would be added to the download items and once clicked, it will remove it from the shelf and list.

BUG= 60  ( http://crbug.com/60 )
TEST=Download a file from the net, CTRL+J. Click on "Remove from list".  The item removes from the list and download shelf.

Review URL: http://codereview.chromium.org/155750
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=22143 

------------------------------------------------------------------------
r22143 | mhm@chromium.org | 2009-07-30 22:28:29 -0700 (Thu, 30 Jul 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf.cc?r1=22143&r2=22142
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_shelf.h?r1=22143&r2=22142
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/download_item_gtk.cc?r1=22143&r2=22142
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/download_item_view.cc?r1=22143&r2=22142

Add "Remove from list" for download item in the download shelf.

This would remove the download list (CTRL+J) as well.

BUG= 60  ( http://crbug.com/60 )
TEST=Download a file from the net, download shelf appears, click the download item's arrow and "Remove from list". The item removes from the shelf and list.
Review URL: http://codereview.chromium.org/155749
------------------------------------------------------------------------

Comment 72 by mhm@chromium.org, Jul 31 2009

Status: Fixed
There is a problem to remove items downloaded from a long Downloads List 
(chrome://downloads/), in version 3.0.197.11. The page doesn't remain in that 
location was. 
For example, I downloaded a lot of files since June. Then, I remove a file downloaded 
on June 21th. After I clicked "remove from list" I was sent quickly to above in the 
page, to view files downloaded in July. 
This is bad, because it's messy to locate where I was scroll point, after removing an 
item.

Anyway, thanks for this feature.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=22893 

------------------------------------------------------------------------
r22893 | thakis@chromium.org | 2009-08-09 21:30:39 -0700 (Sun, 09 Aug 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/DownloadItem.xib?r1=22893&r2=22892
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/download_item_controller.h?r1=22893&r2=22892
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/download_item_controller.mm?r1=22893&r2=22892

add "remove" to download item context menu on mac

BUG= 60 
TEST=Download something, open context menu, click "remove" -- item should be removed from shelf. It leaves a hole behind right now ( bug 17831 ), will fix that later.

Review URL: http://codereview.chromium.org/160444
------------------------------------------------------------------------

Comment 75 by phistuck@gmail.com, Aug 16 2009

But "Remove from list" is not very intuitive. To me it means, remove from the download shelf 
only, while keeping it in the downloads page.
Notes or comments?

Comment 76 by prog...@gmail.com, Aug 16 2009

i agree with your comment phistuck
how about changing the text to "Remove from shelf" and only remove the item from the 
shelf (leave it on the downloads page)?

Comment 78 by rcdai...@gmail.com, Aug 16 2009

Great idea nick. 'Remove from shelf' would be a substantial improvement.
I agree with Comment 77 by Nick. It would be a marvellous improvement.
@phistuck: I don't see your point. "Remove from list" doesn't mean remove from 
*shelf*. We're here talking about a *list*, so anybody should be able to determine 
that it will not only remove the download from the shelf, but also from the downloads 
list.

The problem with your solution is that it would lead to a modification of the current 
behavior of the feature. Either the Chromium team is ready to change its behavior and 
then your suggestion would be OK, either the menu item could be renamed to "Remove 
from downloads list". But in that case, how would the user guess that the download 
will also be removed from the shelf?
Phistuck and others: Open a new bug for "download item context menu should remove 
only from shelf, not from list". This one is marked as fixed and is too long to be useful 
anyway.

Comment 82 by phistuck@gmail.com, Aug 20 2009

Done.  Issue 19838 .
I don't see the menu "remove" in the shelf menu anymore. It seems that this is a bug.

version 4.0.220.1 (Official Build 27713)

SO it's a confirmed bug that was made consciously? strange. still, it means that this 
issue is not fixed anymore.

and should be fixed - 'remove' was very useful.

Comment 86 by prog...@gmail.com, Oct 7 2009

see  Issue 23078 
Project Member

Comment 87 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Sign in to add a comment