[Language] Cosmetic changes for multi-lingual spell check |
|||||||
Issue descriptionSpell check is now multi-lingual: you can enable or disable spell check for any language that supports it, instead of having to choose only one language to use spell check for. See chrome://settings/languages, where the language detail pane has a checkbox for enabling spell check if the language supports it. We should do something similar for the spell check section of MD Settings. Feel free to swing by for a demo instead of reading this wall of text: For lack of a more creative option, I have two proposals: 1A. List all languages that support spell check in the spell check section. Use a green check-mark icon next to the ones that have spell check enabled. The Settings cogwheel goes to the language detail page. 1B. Same as 1A, but instead of the Settings cogwheel, use a toggle button to represent spell check status and allow enabling/disabling from the list directly. 2. Only list the languages that have spell check enabled in the spell check section. 1 may be confusing because languages that have spell check disabled are listed under "Spell check" (but with no check-mark). 2 is annoying because you can't change the spell check language from the spell check section -- you would have to go into the details for a language in the Languages section and enable it from there.
,
Apr 12 2016
Note that chrome://settings/languages shows your Accept-Languages: https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.4 Some of these can be selected to be user's spellcheck languages.
,
Apr 13 2016
Okay, SGTM. The latest page is partway to 1B anyway, so I'll update this bug when it's finished.
,
May 24 2016
,
Jun 4 2016
Still need to: 1. adjust placeholder text 2. show languages that don't support spell check, with a tooltip 3. switch checkbox to toggle button The placeholder text is clearly blocking issue 614588 so I've separated that out into issue 617364 .
,
Jun 8 2016
tbuckley/bettes: Here's a screenshot of the toggle buttons: https://screenshot.googleplex.com/Wm72JHa5Eov Here's the old version for comparison: https://screenshot.googleplex.com/VL3VqfazbUt Does that look okay? Might be a bit odd seeing that many toggle buttons on top of each other (also the color is probably wrong)
,
Jun 8 2016
Toggle switches should be at the far-right of each row, just like the gear icons were. The colors/sizing of the toggle switches is incorrect, but that's tracked in Issue 597879
,
Jun 9 2016
,
Jun 20 2016
Looks good, thanks!
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40aea5f055f5ad469dc3692db2cc3c42eb520f09 commit 40aea5f055f5ad469dc3692db2cc3c42eb520f09 Author: michaelpg <michaelpg@chromium.org> Date: Tue Jun 21 04:04:44 2016 MD Settings: Update spell check section to spec Replaces paper-checkboxes with paper-toggle-buttons. Shows all languages and disables the ones that don't support spell check. Adds some common label styling to settings_shared_css.html. Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=239710&inline=1 BUG= 599993 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2052573003 Cr-Commit-Position: refs/heads/master@{#400888} [modify] https://crrev.com/40aea5f055f5ad469dc3692db2cc3c42eb520f09/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/40aea5f055f5ad469dc3692db2cc3c42eb520f09/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/40aea5f055f5ad469dc3692db2cc3c42eb520f09/chrome/browser/resources/settings/settings_shared_css.html
,
Jun 22 2016
,
Oct 20 2016
In m55 dev the spell check section lists all of the languages but they use a check box instead of a toggle button. Was this changed?
,
Oct 21 2016
Yes, in https://codereview.chromium.org/2359353002 Many of the settings bugs are used to track in-progress work on the settings pages, with often quickly changing design specs. Is there any way we can flag those as not needing QA attention, so we don't waste your time?
,
Oct 21 2016
Either a comment on the bug or a TEST= line in the CL is fine. I'll mark this as verified so it is out of our queue.
,
Oct 21 2016
Excellent, thank you! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tbuck...@chromium.org
, Apr 12 2016Owner: michae...@chromium.org
Summary: [Language] Changes for multi-lingual spell check (was: MD Settings: changes for multi-lingual spell check )