Issue 599974 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	sunxd@chromium.org
Closed:	Apr 2016
Cc:	weiliangc@chromium.org █ vollick@chromium.org ajuma@chromium.org enne@chromium.org █ jaydasika@chromium.org
Components:	Internals>Compositing
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Feature

Blocking:
issue 504464

Remove usage of Layer draw_transform

Project Member Reported by ajuma@chromium.org, Apr 1 2016

Issue description

Once render surface determination moves to the compositor thread, it won't be possible to compute the draw transform of a Layer (since that requires knowing the Layer's target). 

Tests that depend on draw_transform should probably be converted to use LayerImpls.

Where we're using draw_transform to determine contents scale, we can use screen space transform instead.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd920f3f1f0bde7bb5838cb8feb1131928a22fd5

commit fd920f3f1f0bde7bb5838cb8feb1131928a22fd5
Author: sunxd <sunxd@chromium.org>
Date: Tue Apr 05 16:17:51 2016

cc: Remove usage of Layer draw_transform

Remove the Layer version of DrawPropertyUtils::DrawTransform, remove
Layer::draw_transform.

Convert tests that use Layer's draw_transform to LayerImpl tests.

BUG= 599974 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1859733002

Cr-Commit-Position: refs/heads/master@{#385184}

[modify] https://crrev.com/fd920f3f1f0bde7bb5838cb8feb1131928a22fd5/cc/blink/web_layer_impl_fixed_bounds_unittest.cc
[modify] https://crrev.com/fd920f3f1f0bde7bb5838cb8feb1131928a22fd5/cc/layers/layer.cc
[modify] https://crrev.com/fd920f3f1f0bde7bb5838cb8feb1131928a22fd5/cc/layers/layer.h
[modify] https://crrev.com/fd920f3f1f0bde7bb5838cb8feb1131928a22fd5/cc/layers/painted_scrollbar_layer.cc
[modify] https://crrev.com/fd920f3f1f0bde7bb5838cb8feb1131928a22fd5/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/fd920f3f1f0bde7bb5838cb8feb1131928a22fd5/cc/trees/draw_property_utils.h
[modify] https://crrev.com/fd920f3f1f0bde7bb5838cb8feb1131928a22fd5/cc/trees/layer_tree_host_common_unittest.cc

Comment 2 by sunxd@chromium.org, Apr 5 2016

Status: Fixed (was: Assigned)

►

Issue 599974 link

Issue metadata

Remove usage of Layer draw_transform

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 5 2016

Comment 1 Deleted

Comment 2 by sunxd@chromium.org, Apr 5 2016

Comment 2 Deleted

Sign in to add a comment