Issue 599973 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	xiy...@chromium.org
Closed:	Apr 2016
Cc:	abodenha@chromium.org jen...@chromium.org █ blumberg@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
VerifyIn-52 VerifyIn-53 VerifyIn-54 Bulk-Verified

Kiosk session is not properly started when there are flags set

Project Member Reported by xiy...@chromium.org, Apr 1 2016

Issue description

When there are flags set (by owner or from policy), Chrome needs to be restarted before entering the kiosk session. Right now, the restarted chrome does not resume the kiosk session properly. We end up in a restart loop if there is an auto launched kiosk app.

Repro:
1. Set login screen flags (either as owner in about:flags or push down via policy);
2. Set an auto launched kiosk app;

Upon device reboot, it enters a restart loop. Most of time, user just sees a black screen.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef

commit d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef
Author: xiyuan <xiyuan@chromium.org>
Date: Tue Apr 19 18:22:53 2016

kiosk: Fix kiosk session restart

Make kiosk apps part of IsKnownUser. Otherwise, a kiosk session
is terminated in the crash-and-restart case.

BUG= 599973 
TEST=KioskCrashRestoreTest.Basic

Review URL: https://codereview.chromium.org/1865133002

Cr-Commit-Position: refs/heads/master@{#388249}

[add] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/chrome/browser/chromeos/login/users/chrome_user_manager_impl.h
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/chrome/browser/chromeos/login/users/mock_user_manager.h
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/chrome/browser/extensions/api/file_system/file_system_api_unittest.cc
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/chrome/chrome_tests.gypi
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/components/user_manager/fake_user_manager.cc
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/components/user_manager/fake_user_manager.h
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/components/user_manager/user.cc
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/components/user_manager/user.h
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/components/user_manager/user_manager_base.cc
[modify] https://crrev.com/d4f0457c76a3bf8bd98a75a220bd5fb9475b51ef/components/user_manager/user_manager_base.h