New issue
Advanced search Search tips

Issue 599950 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 611911

Blocking:
issue 431177



Sign in to add a comment

Mac GN build is missing verify_order step

Project Member Reported by thakis@chromium.org, Apr 1 2016

Issue description

The gyp bot runs verify_order to check that no unwanted exports appear. This bug reminds us to add that to the gn build.
 
Components: Build
Labels: Build
Cc: rsesek@chromium.org
Labels: -Build Build-Tools-GN Proj-GN-Migration
Status: Available (was: Unconfirmed)
Labels: -Pri-3 Pri-2

Comment 5 by rsesek@chromium.org, May 16 2016

Cc: -rsesek@chromium.org
Owner: rsesek@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, May 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d852f7e89168e0a1d6f7da22ddc3b5317fe3ec6

commit 8d852f7e89168e0a1d6f7da22ddc3b5317fe3ec6
Author: rsesek <rsesek@chromium.org>
Date: Mon May 16 21:15:42 2016

[Mac/GN] Do not EXPORT_SYMBOLS in //media/base/simd unless is_component_build.

BUG= 431177 , 599950 
R=sandersd@chromium.org

Review-Url: https://codereview.chromium.org/1979263002
Cr-Commit-Position: refs/heads/master@{#393926}

[modify] https://crrev.com/8d852f7e89168e0a1d6f7da22ddc3b5317fe3ec6/media/base/BUILD.gn

Comment 7 by rsesek@chromium.org, May 16 2016

Blockedon: 611911
Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e42e1567d64b5397e1757384752873e3c6b4e6e5

commit e42e1567d64b5397e1757384752873e3c6b4e6e5
Author: nacl-deps-roller <nacl-deps-roller@chromium.org>
Date: Tue May 17 21:40:19 2016

Roll src/native_client/ 7965517f3..7975b186d (1 commit).

https://chromium.googlesource.com/native_client/src/native_client.git/+log/7965517f3877..7975b186d213

$ git log 7965517f3..7975b186d --date=short --no-merges --format='%ad %ae %s'
2016-05-17 rsesek Delete shared/platform/osx/strnlen_osx.c.

BUG= 599950 

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review-Url: https://codereview.chromium.org/1987793003
Cr-Commit-Position: refs/heads/master@{#394235}

[modify] https://crrev.com/e42e1567d64b5397e1757384752873e3c6b4e6e5/DEPS

Status: Fixed (was: Started)

Comment 12 Deleted

Sign in to add a comment