New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599946 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Use other robhogan account instead.
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Printing-related layout tests have regressed on Win10

Project Member Reported by lukasza@chromium.org, Apr 1 2016

Issue description

The tests started failing in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8300

One CL that stands out on the blamelist is https://codereview.chromium.org/1848263002 which has changed test expectations for some of the failing tests (i.e. quirks-percentage-height-body-expected.txt).

Failing tests:

printing/quirks-percentage-height-body.html
printing/quirks-percentage-height.html
printing/standards-percentage-heights.html
printing/subframes-percentage-height.html
virtual/threaded/printing/quirks-percentage-height-body.html
virtual/threaded/printing/quirks-percentage-height.html
virtual/threaded/printing/standards-percentage-heights.html
virtual/threaded/printing/subframes-percentage-height.html



 
Labels: -Pri-3 Pri-1
This made Win10 bot red - bumping up the priority.

Comment 2 Deleted

Oh - one more thing - it seems that the tests are simply missing test expectations.
Cc: wkorman@chromium.org
cc wkorman, who owns the rebaseline bot

Comment 5 by wfh@chromium.org, Apr 1 2016

Cc: dpranke@chromium.org wfh@chromium.org
Labels: Proj-Windows10
The same set of tests was also failing yesterday - see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8221 for example. Not sure how they were fixed since then.
If you could add expectations that would be great. I'll double check tomorrow. Zero reason why Win 10 would be uniquely wrong here. I think its just an expectations issue.

I'd add them myself but am away from a desk until tomorrow. Please don't revert!

This is a reland if a CL yesterday that had the same problem. I think it fails to generate new results when converting reft tests to PNG tests.
In case this is useful, I have kicked off some win trybots on a change that adds expectations of missing files at https://crrev.com/1847893004
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9734969664006ba46709b27a91d7f4c7be4829ea

commit 9734969664006ba46709b27a91d7f4c7be4829ea
Author: lukasza <lukasza@chromium.org>
Date: Fri Apr 01 23:54:25 2016

Mark missing expectations for Win10 printing layout tests.

BUG= 599946 
TBR=robhogan@chromium.org

Review URL: https://codereview.chromium.org/1847893004

Cr-Commit-Position: refs/heads/master@{#384729}

[modify] https://crrev.com/9734969664006ba46709b27a91d7f4c7be4829ea/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f7a3482d589225bbab665865c9a9ed1a9f6a645

commit 3f7a3482d589225bbab665865c9a9ed1a9f6a645
Author: robhogan <robhogan@gmail.com>
Date: Sat Apr 02 22:43:45 2016

Rebaseline Win10 layout test results from r384518

Attempt to rebaseline win10 results after https://codereview.chromium.org/1817873002.

TBR=eae@chromium.org

BUG= 599946 ,  273306 

Review URL: https://codereview.chromium.org/1858443002

Cr-Commit-Position: refs/heads/master@{#384816}

[modify] https://crrev.com/3f7a3482d589225bbab665865c9a9ed1a9f6a645/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/3f7a3482d589225bbab665865c9a9ed1a9f6a645/third_party/WebKit/LayoutTests/platform/win/printing/quirks-percentage-height-body-expected.png
[add] https://crrev.com/3f7a3482d589225bbab665865c9a9ed1a9f6a645/third_party/WebKit/LayoutTests/platform/win/printing/quirks-percentage-height-expected.png
[add] https://crrev.com/3f7a3482d589225bbab665865c9a9ed1a9f6a645/third_party/WebKit/LayoutTests/platform/win/printing/standards-percentage-heights-expected.png
[add] https://crrev.com/3f7a3482d589225bbab665865c9a9ed1a9f6a645/third_party/WebKit/LayoutTests/platform/win/printing/subframes-percentage-height-expected.png
[add] https://crrev.com/3f7a3482d589225bbab665865c9a9ed1a9f6a645/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/quirks-percentage-height-body-expected.png
[add] https://crrev.com/3f7a3482d589225bbab665865c9a9ed1a9f6a645/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/quirks-percentage-height-expected.png
[add] https://crrev.com/3f7a3482d589225bbab665865c9a9ed1a9f6a645/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/standards-percentage-heights-expected.png
[add] https://crrev.com/3f7a3482d589225bbab665865c9a9ed1a9f6a645/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/subframes-percentage-height-expected.png

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a41fed86d649088204d80608e6855ac4c7ac293c

commit a41fed86d649088204d80608e6855ac4c7ac293c
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Sun Apr 03 00:36:08 2016

Auto-rebaseline for r384816

https://chromium.googlesource.com/chromium/src/+/3f7a3482d

BUG= 599946 
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/1853013002 .

Cr-Commit-Position: refs/heads/master@{#384818}

[modify] https://crrev.com/a41fed86d649088204d80608e6855ac4c7ac293c/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/quirks-percentage-height-body-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/quirks-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/subframes-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/mac/printing/quirks-percentage-height-body-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/mac/printing/quirks-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/mac/printing/subframes-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/quirks-percentage-height-body-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/quirks-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/subframes-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win/printing/quirks-percentage-height-body-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win/printing/quirks-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win/printing/standards-percentage-heights-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win/printing/subframes-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/quirks-percentage-height-body-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/quirks-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/standards-percentage-heights-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/subframes-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win7/printing/quirks-percentage-height-body-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win7/printing/quirks-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win7/printing/standards-percentage-heights-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win7/printing/subframes-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/quirks-percentage-height-body-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/quirks-percentage-height-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/standards-percentage-heights-expected.png
[delete] https://crrev.com/d0d08465fa2d09abf4b3001e0c3f61efbd56f9b2/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/subframes-percentage-height-expected.png
[rename] https://crrev.com/a41fed86d649088204d80608e6855ac4c7ac293c/third_party/WebKit/LayoutTests/printing/quirks-percentage-height-body-expected.png
[rename] https://crrev.com/a41fed86d649088204d80608e6855ac4c7ac293c/third_party/WebKit/LayoutTests/printing/quirks-percentage-height-expected.png
[rename] https://crrev.com/a41fed86d649088204d80608e6855ac4c7ac293c/third_party/WebKit/LayoutTests/printing/standards-percentage-heights-expected.png
[rename] https://crrev.com/a41fed86d649088204d80608e6855ac4c7ac293c/third_party/WebKit/LayoutTests/printing/subframes-percentage-height-expected.png
[rename] https://crrev.com/a41fed86d649088204d80608e6855ac4c7ac293c/third_party/WebKit/LayoutTests/virtual/threaded/printing/standards-percentage-heights-expected.png

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a0b418a172aabf323b92f8756abf3b768f5faea

commit 5a0b418a172aabf323b92f8756abf3b768f5faea
Author: robhogan <robhogan@gmail.com>
Date: Sun Apr 03 08:33:18 2016

Mark Win10 printing tests as failing

It's not possible to rebaseline specific win10 results after
https://codereview.chromium.org/1817873002, so mark them as failing.

 Bug 521730  is tracking adding Win10 specific results, so add the exepectations
to the other layout tests awaiting a Win10-specific rebaseline.

TBR=eae@chromium.org

BUG= 599946 ,  273306 ,  521730 

Review URL: https://codereview.chromium.org/1851313002

Cr-Commit-Position: refs/heads/master@{#384827}

[modify] https://crrev.com/5a0b418a172aabf323b92f8756abf3b768f5faea/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Untriaged)
Labels: Test-Layout

Sign in to add a comment