New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599940 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

CLD2 validates incorrect language

Project Member Reported by rkaplow@chromium.org, Apr 1 2016

Issue description

CLD2 implementation only checks the summary language for valid_language and not the actual language applied.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80f25b767e1a4b060f085b82e32f016ea4db881e

commit 80f25b767e1a4b060f085b82e32f016ea4db881e
Author: rkaplow <rkaplow@chromium.org>
Date: Tue May 03 16:21:19 2016

Adjusted to check language3[0] only and ignore the summary return.
Currently the is_valid_language check is on the summary language.

I'm trying to fix what seems to be a bug introduced here:
https://codereview.chromium.org/1263613002

When that change switched from the summary language to language3[0] (The
description shows this was intentional, with "Edit CLD2 result to return top
language instead of summary language.")

When mcindy@ switched from summary language to top language, shouldn't they have
also used that language to validate unknownness? I don't understand why you
currently want to check the summary language when you're returning the
language3[0] as the result.

BUG= 599940 

Review-Url: https://codereview.chromium.org/1849323002
Cr-Commit-Position: refs/heads/master@{#391255}

[modify] https://crrev.com/80f25b767e1a4b060f085b82e32f016ea4db881e/components/translate/core/language_detection/language_detection_util.cc

Status: Fixed (was: Assigned)

Sign in to add a comment