Apply control clip and css clip on paint invalidation rects |
|||||||
Issue descriptionFor now we ignore them when calculating paint invalidation rects.
,
Apr 4 2016
Sorry, I put a wrong bug number for the NeedsRebaseline entries. The bug number should be bug 599935 .
,
Apr 20 2016
,
Aug 12 2016
chrishtr@'s ongoing work for bug 611379 may fix part or all of this bug.
,
Aug 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d30a67e378ec3fcaac5809305584bbabca88e18 commit 3d30a67e378ec3fcaac5809305584bbabca88e18 Author: chrishtr <chrishtr@chromium.org> Date: Sat Aug 13 01:17:59 2016 Take CSS Clip and contain: paint into account when computing visual rects. BUG= 611379 , 599939 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2241663002 Cr-Commit-Position: refs/heads/master@{#411843} [modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/LayoutBox.cpp [modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/LayoutBox.h [modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/LayoutObject.h [modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp [modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp [modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
,
Aug 13 2016
Added support for CSS clip. We concluded control clip does not need to be added, not worth the effort. But note that control clip is correctly implemented in paint property trees already.
,
Aug 16 2016
Now css clip is still not fully supported yet. Szager@ pointed out some problem in bug 638386 . The remaining issues are not critical for paint invalidation, but have the following issues: - IntersectionObserver needs more accurate clipping; - We should be aware of this when writing unit tests when comparing results of different methods which create results of different accuracy.
,
Aug 18 2016
I'm reopening this bug because of the remaining issues: - Self css clip is not applied in mapToVisualRectInAncestorSpace(); - The issue about css-clip of fixed-position in mapToVisualRectInAncestorSpace(). (Let's use bug 638386 to track the same issue in GeometryMapper.)
,
Aug 22 2016
I don't think we should fix the second bullet. Will look into the other one.
,
Aug 23 2016
Possibly related -- it looks like the scrolled content offset may be being incorrectly applied to the inner-editor paint invalidation rect (or, we also need to apply it to the clip rect before clipping). See http://crbug.com/634094#c15
,
Mar 30 2018
SPv175 gives us this for free. Let's lose this bug. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Apr 4 2016