New issue
Advanced search Search tips

Issue 599939 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Apply control clip and css clip on paint invalidation rects

Project Member Reported by wangxianzhu@chromium.org, Apr 1 2016

Issue description

For now we ignore them when calculating paint invalidation rects.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4fb954cf8901d7cc84d06698a14bf66c309ea93

commit d4fb954cf8901d7cc84d06698a14bf66c309ea93
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Apr 04 21:06:14 2016

Auto-rebaseline for r384977

https://chromium.googlesource.com/chromium/src/+/ce52a4011

BUG= 599939 
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/1856983002 .

Cr-Commit-Position: refs/heads/master@{#385004}

[modify] https://crrev.com/d4fb954cf8901d7cc84d06698a14bf66c309ea93/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/4bdf946cb5e01a3165fbe4e64ca15ff5aaa2ef5f/third_party/WebKit/LayoutTests/platform/mac-mac10.9/compositing/overflow/text-color-change-expected.txt
[delete] https://crrev.com/4bdf946cb5e01a3165fbe4e64ca15ff5aaa2ef5f/third_party/WebKit/LayoutTests/platform/mac-mac10.9/compositing/overflow/updating-scrolling-container-and-content-expected.txt
[modify] https://crrev.com/d4fb954cf8901d7cc84d06698a14bf66c309ea93/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/text-color-change-expected.txt
[modify] https://crrev.com/d4fb954cf8901d7cc84d06698a14bf66c309ea93/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/updating-scrolling-container-and-content-expected.txt
[modify] https://crrev.com/d4fb954cf8901d7cc84d06698a14bf66c309ea93/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt
[modify] https://crrev.com/d4fb954cf8901d7cc84d06698a14bf66c309ea93/third_party/WebKit/LayoutTests/platform/mac/svg/custom/invisible-text-after-scrolling-expected.txt
[modify] https://crrev.com/d4fb954cf8901d7cc84d06698a14bf66c309ea93/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/text-color-change-expected.txt
[modify] https://crrev.com/d4fb954cf8901d7cc84d06698a14bf66c309ea93/third_party/WebKit/LayoutTests/platform/win/fast/repaint/layout-state-scrolloffset3-expected.txt
[modify] https://crrev.com/d4fb954cf8901d7cc84d06698a14bf66c309ea93/third_party/WebKit/LayoutTests/platform/win/svg/custom/invisible-text-after-scrolling-expected.txt

Sorry, I put a wrong bug number for the NeedsRebaseline entries. The bug number should be  bug 599935 .
Status: WontFix (was: Assigned)
Owner: chrishtr@chromium.org
Status: Assigned (was: WontFix)
chrishtr@'s ongoing work for  bug 611379  may fix part or all of this bug.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d30a67e378ec3fcaac5809305584bbabca88e18

commit 3d30a67e378ec3fcaac5809305584bbabca88e18
Author: chrishtr <chrishtr@chromium.org>
Date: Sat Aug 13 01:17:59 2016

Take CSS Clip and contain: paint into account when computing visual rects.

BUG= 611379 , 599939 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2241663002
Cr-Commit-Position: refs/heads/master@{#411843}

[modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
[modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
[modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/3d30a67e378ec3fcaac5809305584bbabca88e18/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Status: Fixed (was: Assigned)
Added support for CSS clip. We concluded control clip does not need to be added, not
worth the effort. But note that control clip is correctly implemented in paint
property trees already.
Cc: szager@chromium.org
Now css clip is still not fully supported yet. Szager@ pointed out some problem in  bug 638386 . The remaining issues are not critical for paint invalidation, but have the following issues:

- IntersectionObserver needs more accurate clipping;
- We should be aware of this when writing unit tests when comparing results of different methods which create results of different accuracy. 
Status: Assigned (was: Fixed)
I'm reopening this bug because of the remaining issues:
- Self css clip is not applied in mapToVisualRectInAncestorSpace();
- The issue about css-clip of fixed-position in mapToVisualRectInAncestorSpace(). (Let's use  bug 638386  to track the same issue in GeometryMapper.) 
I don't think we should fix the second bullet. Will look into the other one.
Possibly related -- it looks like the scrolled content offset may be being incorrectly applied to the inner-editor paint invalidation rect (or, we also need to apply it to the clip rect before clipping). See  http://crbug.com/634094#c15 
Status: WontFix (was: Assigned)
SPv175 gives us this for free. Let's lose this bug.

Sign in to add a comment