New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599937 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 600396

Blocking:
issue 601463



Sign in to add a comment

Update media notification to use MediaStyle

Project Member Reported by mlamouri@chromium.org, Apr 1 2016

Issue description

The current media notifications are using a custom layout. It does not render very well with the latest Android NYC Dev Preview. We should switch to MediaStyle to have a more streamlined design.
 
Blockedon: 600396
Blocking: 601463
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fe77672d634a7b0adb11d2c11f166be282da012

commit 6fe77672d634a7b0adb11d2c11f166be282da012
Author: zqzhang <zqzhang@chromium.org>
Date: Thu Apr 14 14:02:19 2016

[Media, UI] Change MediaNotification style to MediaStyle

This patch changes the MediaNotification style from a custom layout into
the MediaStyle using NotificationCompat.

BUG= 599937 

Review URL: https://codereview.chromium.org/1847063005

Cr-Commit-Position: refs/heads/master@{#387302}

[modify] https://crrev.com/6fe77672d634a7b0adb11d2c11f166be282da012/chrome/android/java/proguard.flags
[modify] https://crrev.com/6fe77672d634a7b0adb11d2c11f166be282da012/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/6fe77672d634a7b0adb11d2c11f166be282da012/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java
[modify] https://crrev.com/6fe77672d634a7b0adb11d2c11f166be282da012/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java
[modify] https://crrev.com/6fe77672d634a7b0adb11d2c11f166be282da012/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/6fe77672d634a7b0adb11d2c11f166be282da012/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
[modify] https://crrev.com/6fe77672d634a7b0adb11d2c11f166be282da012/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java
[modify] https://crrev.com/6fe77672d634a7b0adb11d2c11f166be282da012/chrome/app/generated_resources.grd
[modify] https://crrev.com/6fe77672d634a7b0adb11d2c11f166be282da012/chrome/browser/about_flags.cc
[modify] https://crrev.com/6fe77672d634a7b0adb11d2c11f166be282da012/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/6fe77672d634a7b0adb11d2c11f166be282da012/chrome/browser/android/chrome_feature_list.h

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/874b02830b1b3f56f5aac6fd341b0ed4a07ebb84

commit 874b02830b1b3f56f5aac6fd341b0ed4a07ebb84
Author: zqzhang <zqzhang@chromium.org>
Date: Thu Apr 21 20:33:27 2016

[Media, UI] Use 3-line style to show metadata in MediaNotification

This CL uses the 3-line style in MediaNotification to better present
media metadata.

BUG= 599937 

Review URL: https://codereview.chromium.org/1896543002

Cr-Commit-Position: refs/heads/master@{#388879}

[modify] https://crrev.com/874b02830b1b3f56f5aac6fd341b0ed4a07ebb84/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

Project Member

Comment 5 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b08510c91c582eec094f03a1230b6f12158019a8

commit b08510c91c582eec094f03a1230b6f12158019a8
Author: zqzhang <zqzhang@chromium.org>
Date: Fri May 06 13:47:19 2016

[Media, UI] Improve large icon in MediaNotification

This CL sets a new minimal favicon size to be used as MediaNotification
large icon. Also, this CL removes the media session image since they
usually look bad on lockscreen.

BUG= 599937 

Review-Url: https://codereview.chromium.org/1948123004
Cr-Commit-Position: refs/heads/master@{#392047}

[modify] https://crrev.com/b08510c91c582eec094f03a1230b6f12158019a8/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/b08510c91c582eec094f03a1230b6f12158019a8/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

Status: Fixed (was: Assigned)
I think we are done here. We still need to pick the right asset for the default icon, but that's bug 600396.

Sign in to add a comment