Devtool tracing doesn't send all tracing data to client in streaming mode |
||||||||
Issue description
Tracing data produced by chrome looks s.t like:
{
"traceEvents": [...],
"displayTimeUnit": "ns",
"systemTraceEvents": "SystemTraceData",
"otherData": {
"version": "My Application v1.0"
},
"stackFrames": {...}
"samples": [...],
"metadata": {...}
}
It looks like devtool only sends data in the "traceEvents" field to client (https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/devtools/protocol/tracing_handler.cc&q=tracing_handler&l=107) in streaming mode.
This is problematic for telemetry & trace-viewer because in order for clock syncing to work, the receiver sites need to know the clock domain of chrome, which is recorder in 'metadata' field.
,
Apr 4 2016
,
Apr 7 2016
The new spec for traces container format is in: https://docs.google.com/document/d/1a8c0tQGlwQapTruWoJTQz8n3kjwIcPnx4mnCBvi_guI/edit?pref=2&pli=1 Please let us know if you have any further question.
,
Apr 22 2016
,
May 5 2016
This is becoming more urgent because it's causing benchmark failure flakily ( issue 605089 ).
,
May 31 2016
,
Jun 3 2016
,
Jun 17 2016
Andrey: any activity on this bug? It's biting us again because we need to surface some extra information in the trace metadata to telemetry's metrics results.
,
Jul 19 2016
,
Jul 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e573d8a81a95fd3b98faf9f7bb45cb7683d86f4 commit 8e573d8a81a95fd3b98faf9f7bb45cb7683d86f4 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Sat Jul 30 00:08:07 2016 Roll src/third_party/catapult/ 395e5365f..a6464cb62 (2 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/395e5365f02a..a6464cb626ec $ git log 395e5365f..a6464cb62 --date=short --no-merges --format='%ad %ae %s' BUG= 599932 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2195913002 Cr-Commit-Position: refs/heads/master@{#408814} [modify] https://crrev.com/8e573d8a81a95fd3b98faf9f7bb45cb7683d86f4/DEPS
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ca7f52df3354ba8ebb672c63b853cb23d737227 commit 4ca7f52df3354ba8ebb672c63b853cb23d737227 Author: caseq <caseq@chromium.org> Date: Mon Aug 01 17:17:05 2016 Tracing: re-use JSONTraceDataSink in DevTools' tracing handler... ... so that we return traces from all agents and metadata to clients. This depens on https://codereview.chromium.org/2160793003/ on the Telemetry side. BUG= 599932 Review-Url: https://codereview.chromium.org/2161583004 Cr-Commit-Position: refs/heads/master@{#408988} [modify] https://crrev.com/4ca7f52df3354ba8ebb672c63b853cb23d737227/content/browser/devtools/devtools_io_context.cc [modify] https://crrev.com/4ca7f52df3354ba8ebb672c63b853cb23d737227/content/browser/devtools/devtools_io_context.h [modify] https://crrev.com/4ca7f52df3354ba8ebb672c63b853cb23d737227/content/browser/devtools/protocol/tracing_handler.cc [modify] https://crrev.com/4ca7f52df3354ba8ebb672c63b853cb23d737227/content/browser/tracing/tracing_controller_impl.h [modify] https://crrev.com/4ca7f52df3354ba8ebb672c63b853cb23d737227/content/browser/tracing/tracing_controller_impl_data_sinks.cc [modify] https://crrev.com/4ca7f52df3354ba8ebb672c63b853cb23d737227/third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream-expected.txt [modify] https://crrev.com/4ca7f52df3354ba8ebb672c63b853cb23d737227/third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html
,
Aug 1 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by nedngu...@google.com
, Apr 1 2016