New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599927 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 3
Type: Feature



Sign in to add a comment

Do not show loading indicator for (some) iframe loads

Project Member Reported by malteubl@google.com, Apr 1 2016

Issue description

Version: All
OS: Android, possibly iOS


Currently all iframe document load on Android trigger a loading indicator.

To repro, scroll down on this page
http://output.jsbin.com/liqunebaxu/quiet
Then quickly scroll up to show the address bar.

In particular when the current screen has fully loaded already, this leads to perceived slowness (in particular if for some reason the address bar did not scroll away) with the progress indicator indicating something is loading with no actual changes on the screen.

Proposal:
Only show the loading indicator if the iframe is navigated by the user.
 
Cc: dcheng@chromium.org
Components: Blink>Architecture Blink>Loader
Labels: OS-Windows
Owner: japhet@chromium.org
japhet@ do you know how we would go about doing this? You don't need to actually make the change, but if you or dcheng@ knows where to start and could explain it here we could find someone. :)

Comment 2 by dcheng@chromium.org, Apr 20 2016

Cc: nasko@chromium.org
For experimentation, we could just try not calling ProgressTracker::progressStarted() or have it return early without doing anything. The main advantage is this should require very few changes. But there are disadvantages as well:
- The frame load might not get recorded in the inspector instrumentation.
- This won't fire the FrameHostMsg_DidStartLoading IPC, which means a lot of things like https://code.google.com/p/chromium/codesearch#chromium/src/content/public/browser/web_contents_observer.h&l=185&gs=cpp:content::class-WebContentsObserver::DidStartLoading()@chromium/../../content/public/browser/web_contents_observer.h%257Cdef&gsn=DidStartLoading&ct=xref_usages won't run.

Another alternative is to try tweaking the bits in https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/frame_host/frame_tree_node.cc&rcl=1461107913&l=382 and https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/frame_host/frame_tree.cc&rcl=1461107913&l=407 so it only affects the UI, but it gets more complicated.

Comment 3 by nasko@chromium.org, Apr 20 2016

Is this similar to issue 573177?

I'm a bit concerned about hiding loading indicators. It is reality that the page might be navigating/loading an iframe, which can be off-screen. I doubt hiding this fact from the user is a good UX as clearly we are transferring data/loading document.

Comment 4 by creis@chromium.org, Apr 20 2016

Components: UI>Browser>Navigation

Comment 5 by japhet@chromium.org, Apr 20 2016

https://codereview.chromium.org/1860743002/ is my WIP for making the loading progress bar main-frame-only (and stopping after DOMContentLoaded instead of load). I believe this *only* changes the progress bar, so the stop button will still be shown until everything in all the iframes are done.

Comment 6 by kinuko@chromium.org, Apr 27 2016

Status: Assigned (was: Untriaged)
Cc: rsch...@chromium.org

Comment 8 by k...@chromium.org, May 20 2016

Cc: k...@chromium.org
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 3 2016

Labels: Hotlist-Google

Comment 10 by tkent@chromium.org, Jun 23 2016

Components: -Blink>Architecture Blink>Internals
Renaming Blink>Architecture to Blink>Internals

Cc: -rsch...@chromium.org

Comment 12 by ojan@chromium.org, Jan 5 2018

Status: WontFix (was: Assigned)
This is shipped.

Sign in to add a comment