Do not show loading indicator for (some) iframe loads |
||||||||||
Issue descriptionVersion: All OS: Android, possibly iOS Currently all iframe document load on Android trigger a loading indicator. To repro, scroll down on this page http://output.jsbin.com/liqunebaxu/quiet Then quickly scroll up to show the address bar. In particular when the current screen has fully loaded already, this leads to perceived slowness (in particular if for some reason the address bar did not scroll away) with the progress indicator indicating something is loading with no actual changes on the screen. Proposal: Only show the loading indicator if the iframe is navigated by the user.
,
Apr 20 2016
For experimentation, we could just try not calling ProgressTracker::progressStarted() or have it return early without doing anything. The main advantage is this should require very few changes. But there are disadvantages as well: - The frame load might not get recorded in the inspector instrumentation. - This won't fire the FrameHostMsg_DidStartLoading IPC, which means a lot of things like https://code.google.com/p/chromium/codesearch#chromium/src/content/public/browser/web_contents_observer.h&l=185&gs=cpp:content::class-WebContentsObserver::DidStartLoading()@chromium/../../content/public/browser/web_contents_observer.h%257Cdef&gsn=DidStartLoading&ct=xref_usages won't run. Another alternative is to try tweaking the bits in https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/frame_host/frame_tree_node.cc&rcl=1461107913&l=382 and https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/frame_host/frame_tree.cc&rcl=1461107913&l=407 so it only affects the UI, but it gets more complicated.
,
Apr 20 2016
Is this similar to issue 573177? I'm a bit concerned about hiding loading indicators. It is reality that the page might be navigating/loading an iframe, which can be off-screen. I doubt hiding this fact from the user is a good UX as clearly we are transferring data/loading document.
,
Apr 20 2016
,
Apr 20 2016
https://codereview.chromium.org/1860743002/ is my WIP for making the loading progress bar main-frame-only (and stopping after DOMContentLoaded instead of load). I believe this *only* changes the progress bar, so the stop button will still be shown until everything in all the iframes are done.
,
Apr 27 2016
,
May 9 2016
,
May 20 2016
,
Jun 3 2016
,
Jun 23 2016
Renaming Blink>Architecture to Blink>Internals
,
Sep 20 2017
,
Jan 5 2018
This is shipped. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by esprehn@chromium.org
, Apr 20 2016Components: Blink>Architecture Blink>Loader
Labels: OS-Windows
Owner: japhet@chromium.org