New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 599917 link

Starred by 3 users
Status: Fixed
Owner:
█ msarett@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Cc:
noel@chromium.org
█ robert.b...@intel.com
scroggo@chromium.org
█ mdempsky@chromium.org
█ bulach@chromium.org
vapier@chromium.org
mtklein@chromium.org
█ ctr...@blackberry.com
peter@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Upgrade libpng to 1.6.22

Project Member Reported by msarett@chromium.org, Apr 1 2016 
I think it's time to make this update.

The 1.6 branch has NEON optimized filtering functions for Arm, improving decode performance by about 28% on average.

In addition, Skia has upstreamed SSE optimized filtering functions to 1.6.22, meaning that we see about a 34% performance improvement on Intel.
https://docs.google.com/a/google.com/spreadsheets/d/1Xv3TlgwDwnyOKdBrdzQeibz1oaeBQm6_cpPP0Wu0ou0/edit?usp=sharing

Skia has been testing with this code since January, and it will ship in Android N.

In terms of security, I don't think this makes much of a difference.  libpng fixes security vulnerabilites as they arise for both 1.6 and 1.2.  Both branches seem to be affected every once in a while.
http://www.libpng.org/pub/png/libpng.html

I'd be happy to take this on.  I think it makes sense to wait until 1.6.22 is no longer in beta.

Comment 1 by noel@chromium.org, Apr 1 2016 

Speed improvements sound good.  Re: "Skia has upstreamed SSE optimized filtering functions to 1.6.22", got a URL reference to that upstreaming work?

Comment 2 by msarett@chromium.org, Apr 1 2016 

Sure here it is:
https://github.com/glennrp/libpng/pull/88

Comment 3 by noel@chromium.org, Apr 4 2016

Cc: robert.b...@intel.com
Thank you.  I believe some folks at Intel had fixes in this area too.

> I'd be happy to take this on.  I think it makes sense to wait until 1.6.22 is no longer in beta.

Agree.  I wrote down some points on how to proceed changing from 1.2.X to 1.6.X before [1], which might help you.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=351032#c10

Comment 4 by noel@chromium.org, May 17 2016

Cc: bulach@chromium.org peter@chromium.org vapier@chromium.org ctr...@blackberry.com
 Issue 351032  has been merged into this issue.

Comment 6 by msar...@google.com, May 17 2016 

Thanks Noel!

Tentative release date is May 26, so I should be able to get going on this soon.

Comment 7 by msarett@chromium.org, May 31 2016

Cc: mdempsky@chromium.org

Comment 8 by msarett@chromium.org, May 31 2016

Status: Started (was: Assigned)

Comment 9 by mtklein@chromium.org, Jun 12 2016

Cc: -mtkl...@chormium.org mtklein@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c0ac8d882561cca77d5184248708b0ce9c851d4

commit 8c0ac8d882561cca77d5184248708b0ce9c851d4
Author: msarett <msarett@google.com>
Date: Mon Jun 13 16:17:33 2016

Update libpng to 1.6.22

BUG= 599917 
BUG= 618061 

Review-Url: https://codereview.chromium.org/2021403002
Cr-Commit-Position: refs/heads/master@{#399464}

[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/BUILD.gn
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/LICENSE
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/README
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/README.chromium
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/arm/arm_init.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/arm/filter_neon.S
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/arm/filter_neon_intrinsics.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/contrib/intel/INSTALL
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/contrib/intel/filter_sse2_intrinsics.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/contrib/intel/intel_init.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/contrib/intel/intel_sse.patch
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/libpng.gyp
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/png.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/png.h
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngconf.h
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngdebug.h
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngerror.c
[delete] https://crrev.com/71c71a677ae0a8e0004a561f6d558b33ae9c1af3/third_party/libpng/pnggccrd.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngget.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pnginfo.h
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pnglibconf.h
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngmem.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngpread.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngprefix.h
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngpriv.h
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngread.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngrio.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngrtran.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngrutil.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngset.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngstruct.h
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngtest.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngtrans.c
[delete] https://crrev.com/71c71a677ae0a8e0004a561f6d558b33ae9c1af3/third_party/libpng/pngusr.h
[delete] https://crrev.com/71c71a677ae0a8e0004a561f6d558b33ae9c1af3/third_party/libpng/pngvcrd.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngwio.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngwrite.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngwtran.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngwutil.c
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9

commit ffdedd97ebaf2df7537a66eb53ac94a2299de6e9
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Jun 13 18:10:40 2016

Auto-rebaseline for r399464

https://chromium.googlesource.com/chromium/src/+/8c0ac8d88

BUG= 599917 
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/2066483003 .

Cr-Commit-Position: refs/heads/master@{#399485}

[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/fast/images/drag-image-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/fast/images/paint-subrect-grid-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/fast/images/repaint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/css2.1/20110323/inline-replaced-width-014-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/fast/images/drag-image-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/fast/images/paint-subrect-grid-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/fast/images/png-suite/test-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/fast/images/repaint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/paint/selection/selection-drag-image-in-iframe-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/drag-image-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/paint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/png-color-profile-ignore-gamma-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/png-suite/test-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/repaint-subrect-grid-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/inline-replaced-width-014-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/fast/images/png-suite/test-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/paint/selection/selection-drag-image-in-iframe-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/masking-path-04-b-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/png-suite/test-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/selection/selection-drag-image-in-iframe-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/selection/selection-drag-image-in-iframe-expected.txt
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/css2.1/20110323/inline-replaced-width-014-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/fast/images/png-suite/test-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/paint/selection/selection-drag-image-in-iframe-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/png-suite/test-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/css2.1/20110323/inline-replaced-width-014-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/fast/images/png-color-profile-ignore-gamma-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/fast/images/png-suite/test-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/paint/selection/selection-drag-image-in-iframe-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/masking-path-04-b-expected.png
[rename] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/png-color-profile-ignore-gamma-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/png-suite/test-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/fast/images/drag-image-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/fast/images/paint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/fast/images/png-color-profile-ignore-gamma-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/fast/images/png-suite/test-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/fast/images/repaint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/paint/selection/selection-drag-image-in-iframe-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/drag-image-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/paint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/png-color-profile-ignore-gamma-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/png-suite/test-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/repaint-subrect-grid-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/drag-image-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/paint-subrect-grid-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/repaint-subrect-grid-expected.png
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66b307a3e6a01abc681849e161cd39299ddf3791

commit 66b307a3e6a01abc681849e161cd39299ddf3791
Author: msarett <msarett@google.com>
Date: Tue Jun 14 17:55:24 2016

Suppress libpng clang warning on GYP

The BUILD.gn already has this flag.

BUG= 599917 
NOTRY=true

Review-Url: https://codereview.chromium.org/2069593002
Cr-Commit-Position: refs/heads/master@{#399744}

[modify] https://crrev.com/66b307a3e6a01abc681849e161cd39299ddf3791/third_party/libpng/libpng.gyp
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c0ac8d882561cca77d5184248708b0ce9c851d4

commit 8c0ac8d882561cca77d5184248708b0ce9c851d4
Author: msarett <msarett@google.com>
Date: Mon Jun 13 16:17:33 2016

Update libpng to 1.6.22

BUG= 599917 
BUG= 618061 

Review-Url: https://codereview.chromium.org/2021403002
Cr-Commit-Position: refs/heads/master@{#399464}

[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/testing/libfuzzer/fuzzers/libpng_read_fuzzer.cc
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/BUILD.gn
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/LICENSE
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/README
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/README.chromium
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/arm/arm_init.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/arm/filter_neon.S
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/arm/filter_neon_intrinsics.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/contrib/intel/INSTALL
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/contrib/intel/filter_sse2_intrinsics.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/contrib/intel/intel_init.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/contrib/intel/intel_sse.patch
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/libpng.gyp
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/png.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/png.h
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngconf.h
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngdebug.h
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngerror.c
[delete] https://crrev.com/71c71a677ae0a8e0004a561f6d558b33ae9c1af3/third_party/libpng/pnggccrd.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngget.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pnginfo.h
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pnglibconf.h
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngmem.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngpread.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngprefix.h
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngpriv.h
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngread.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngrio.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngrtran.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngrutil.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngset.c
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngstruct.h
[add] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngtest.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngtrans.c
[delete] https://crrev.com/71c71a677ae0a8e0004a561f6d558b33ae9c1af3/third_party/libpng/pngusr.h
[delete] https://crrev.com/71c71a677ae0a8e0004a561f6d558b33ae9c1af3/third_party/libpng/pngvcrd.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngwio.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngwrite.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngwtran.c
[modify] https://crrev.com/8c0ac8d882561cca77d5184248708b0ce9c851d4/third_party/libpng/pngwutil.c
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9

commit ffdedd97ebaf2df7537a66eb53ac94a2299de6e9
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Mon Jun 13 18:10:40 2016

Auto-rebaseline for r399464

https://chromium.googlesource.com/chromium/src/+/8c0ac8d88

BUG= 599917 
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/2066483003 .

Cr-Commit-Position: refs/heads/master@{#399485}

[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/fast/images/drag-image-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/fast/images/paint-subrect-grid-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/fast/images/repaint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/css2.1/20110323/inline-replaced-width-014-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/fast/images/drag-image-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/fast/images/paint-subrect-grid-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/fast/images/png-suite/test-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/fast/images/repaint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/paint/selection/selection-drag-image-in-iframe-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/drag-image-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/paint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/png-color-profile-ignore-gamma-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/png-suite/test-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/android/virtual/gpu-rasterization/fast/images/repaint-subrect-grid-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/inline-replaced-width-014-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/fast/images/png-suite/test-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/paint/selection/selection-drag-image-in-iframe-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/masking-path-04-b-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/png-suite/test-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/selection/selection-drag-image-in-iframe-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/selection/selection-drag-image-in-iframe-expected.txt
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/css2.1/20110323/inline-replaced-width-014-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/fast/images/png-suite/test-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/paint/selection/selection-drag-image-in-iframe-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/png-suite/test-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/css2.1/20110323/inline-replaced-width-014-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/fast/images/png-color-profile-ignore-gamma-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/fast/images/png-suite/test-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/paint/selection/selection-drag-image-in-iframe-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/masking-path-04-b-expected.png
[rename] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/png-color-profile-ignore-gamma-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/png-suite/test-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/fast/images/drag-image-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/fast/images/paint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/fast/images/png-color-profile-ignore-gamma-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/fast/images/png-suite/test-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/fast/images/repaint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/paint/selection/selection-drag-image-in-iframe-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/drag-image-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/paint-subrect-grid-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/png-color-profile-ignore-gamma-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/png-suite/test-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu-rasterization/fast/images/repaint-subrect-grid-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/drag-image-expected.png
[add] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/paint-subrect-grid-expected.png
[modify] https://crrev.com/ffdedd97ebaf2df7537a66eb53ac94a2299de6e9/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/fast/images/repaint-subrect-grid-expected.png
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66b307a3e6a01abc681849e161cd39299ddf3791

commit 66b307a3e6a01abc681849e161cd39299ddf3791
Author: msarett <msarett@google.com>
Date: Tue Jun 14 17:55:24 2016

Suppress libpng clang warning on GYP

The BUILD.gn already has this flag.

BUG= 599917 
NOTRY=true

Review-Url: https://codereview.chromium.org/2069593002
Cr-Commit-Position: refs/heads/master@{#399744}

[modify] https://crrev.com/66b307a3e6a01abc681849e161cd39299ddf3791/third_party/libpng/libpng.gyp
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfb7a92cc401f84284843a385de71ec75e306ea1

commit cfb7a92cc401f84284843a385de71ec75e306ea1
Author: msarett <msarett@google.com>
Date: Wed Jun 15 19:30:35 2016

Rebaseline after libpng update

BUG= 599917 
BUG= 619987 

Review-Url: https://codereview.chromium.org/2065413003
Cr-Commit-Position: refs/heads/master@{#399987}

[modify] https://crrev.com/cfb7a92cc401f84284843a385de71ec75e306ea1/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a6fd63502992f35689e4539cebfd4ae5b29fd54

commit 0a6fd63502992f35689e4539cebfd4ae5b29fd54
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Jun 17 04:42:41 2016

NeedsRebaseline for  crbug.com/599917 

BUG= 599917 

Review URL: https://codereview.chromium.org/2076863002 .

Cr-Commit-Position: refs/heads/master@{#400357}

[modify] https://crrev.com/0a6fd63502992f35689e4539cebfd4ae5b29fd54/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/320b6a99552ed004f62b384af43dbbada321c131

commit 320b6a99552ed004f62b384af43dbbada321c131
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Fri Jun 17 06:24:02 2016

Auto-rebaseline for r400357

https://chromium.googlesource.com/chromium/src/+/0a6fd6350

BUG= 599917 
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2079633003 .

Cr-Commit-Position: refs/heads/master@{#400377}

[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/e0afd0716fe7c94d890cf94b8771692bd827884e/third_party/WebKit/LayoutTests/platform/linux-precise/css3/filters/effect-brightness-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/background-image-paint-invalidation-large-abspos-div-expected.png
[add] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/createImageElement2-expected.png
[add] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/custom/pointer-events-image-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/compositing/masks/direct-image-mask-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/simple-composited-reflections-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/compositing/visibility/visibility-image-layers-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/background-blend-mode-crossfade-image-gradient-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/background-blend-mode-default-value-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/background-blend-mode-different-image-formats-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/background-blend-mode-gradient-image-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/background-blend-mode-image-color-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/background-blend-mode-image-image-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/background-blend-mode-image-svg-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/background-blend-mode-multiple-background-layers-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/background-blend-mode-single-layer-no-blending-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/background-blend-mode-tiled-gradient-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/effect-background-blend-mode-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/effect-background-blend-mode-stacking-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/effect-background-blend-mode-tiled-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/mix-blend-mode-isolated-group-1-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/mix-blend-mode-isolated-group-2-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/blending/mix-blend-mode-isolated-group-3-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/buffer-offset-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/composited-reflected-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/crash-filter-change-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-blur-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-blur-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-brightness-clamping-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-brightness-clamping-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-brightness-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-brightness-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-combined-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-combined-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-contrast-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-contrast-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-drop-shadow-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-drop-shadow-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-grayscale-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-grayscale-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-hue-rotate-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-invert-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-invert-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-opacity-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-opacity-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-colorspace-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-colorspace-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-composite-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-composite-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-external-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-hidpi-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-hidpi-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-ordering-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-ordering-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-subregion-chained-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-subregion-chained-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-subregion-colormatrix-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-subregion-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-subregion-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-tile-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-tile-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-zoom-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-zoom-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-saturate-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-saturate-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-sepia-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-sepia-hw-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/css3/filters/regions-expanding-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/fast/css/background-shorthand-invalid-url-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/fast/images/color-profile-border-image-source-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/fast/images/color-profile-image-profile-match-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/fast/reflections/reflection-direction-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/fast/reflections/reflection-masks-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/fast/reflections/reflection-masks-opacity-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/fast/reflections/reflection-masks-outset-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/fast/reflections/reflection-with-zoom-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/background-image-paint-invalidation-large-abspos-div-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/background-image-paint-invalidation-small-document-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/createImageElement-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/createImageElement2-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/focus-ring-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/image-parent-translation-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/image-small-width-height-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/image-with-transform-clip-filter-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/js-update-image-and-display-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/js-update-image-and-display2-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/js-update-image-and-display3-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/js-update-image-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/pointer-events-image-css-transform-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/pointer-events-image-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/text-image-opacity-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/transformed-outlines-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-border-image-source-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-image-profile-match-expected.png
[modify] https://crrev.com/320b6a99552ed004f62b384af43dbbada321c131/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d66b57b0f0f5e8673612fc58fe9656a6991d6a69

commit d66b57b0f0f5e8673612fc58fe9656a6991d6a69
Author: mostynb <mostynb@opera.com>
Date: Mon Jun 20 17:35:50 2016

skip neon intrinsics in libpng when neon is not available

Followup to https://codereview.chromium.org/2021403002

BUG= 599917 ,  618061 

Review-Url: https://codereview.chromium.org/2074363002
Cr-Commit-Position: refs/heads/master@{#400714}

[modify] https://crrev.com/d66b57b0f0f5e8673612fc58fe9656a6991d6a69/third_party/libpng/BUILD.gn
[modify] https://crrev.com/d66b57b0f0f5e8673612fc58fe9656a6991d6a69/third_party/libpng/libpng.gyp
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b43ad19eed3d9b660f2fc3e445e250a1b42b6b93

commit b43ad19eed3d9b660f2fc3e445e250a1b42b6b93
Author: msarett <msarett@google.com>
Date: Wed Jun 22 16:14:08 2016

Fix performance regression in png encoding caused by libpng update

libpng calculates "filter heuristics" to choose which png
filter to apply.  Chrome need not calculate these "filter
heuristics" because we always choose to use the SUB filter,
for speed.

libpng 1.6 refactors the SUB filter to share code, also
forcing us to calculate the filter heuristics, even though
we don't need to.  This caused a performance regression.

This CL cherry picks a fix from upstream that:
(1) Passes PNG_SIZE_MAX to the filter code.  This allows
the compiler to optimize out the heuristic calculation
code, fixing the performance regression.
(2) Fixes overflow handling in the calculation of filter
heuristics.  This won't affect Chrome.

BUG= 619850 
BUG= 599917 

Review-Url: https://codereview.chromium.org/2062423002
Cr-Commit-Position: refs/heads/master@{#401298}

[modify] https://crrev.com/b43ad19eed3d9b660f2fc3e445e250a1b42b6b93/third_party/WebKit/Source/platform/image-encoders/PNGImageEncoder.cpp
[modify] https://crrev.com/b43ad19eed3d9b660f2fc3e445e250a1b42b6b93/third_party/libpng/BUILD.gn
[modify] https://crrev.com/b43ad19eed3d9b660f2fc3e445e250a1b42b6b93/third_party/libpng/README.chromium
[modify] https://crrev.com/b43ad19eed3d9b660f2fc3e445e250a1b42b6b93/third_party/libpng/libpng.gyp
[modify] https://crrev.com/b43ad19eed3d9b660f2fc3e445e250a1b42b6b93/third_party/libpng/pngwutil.c

Comment 21 by mtklein@chromium.org, Jun 22 2016 

> libpng calculates "filter heuristics" to choose which png
filter to apply.  Chrome need not calculate these "filter
heuristics" because we always choose to use the SUB filter,
for speed.

Any idea where / when this decision got made?  I'm curious if they considered UP, which should be just about as fast to encode and a lot faster to decode.

Comment 22 by msarett@chromium.org, Jun 22 2016 

Very good question, I don't know, but it's something to look into...
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67058eff9c2a51e589388d7d494b1490530a1ec5

commit 67058eff9c2a51e589388d7d494b1490530a1ec5
Author: msarett <msarett@google.com>
Date: Fri Jul 08 14:29:14 2016

Fix for png encoding performance regressions - downstream diff

The original fix was:

> Fix performance regression in png encoding caused by libpng update
>
> libpng calculates "filter heuristics" to choose which png
> filter to apply.  Chrome need not calculate these "filter
> heuristics" because we always choose to use the SUB filter,
> for speed.
>
> libpng 1.6 refactors the SUB filter to share code, also
> forcing us to calculate the filter heuristics, even though
> we don't need to.  This caused a performance regression.
>
> This CL cherry picks a fix from upstream that:
> (1) Passes PNG_SIZE_MAX to the filter code.  This allows
> the compiler to optimize out the heuristic calculation
> code, fixing the performance regression.
> (2) Fixes overflow handling in the calculation of filter
> heuristics.  This won't affect Chrome.
>
> Review-Url: https://codereview.chromium.org/2062423002

This fix was effective everywhere we use clang, but did
not work on Android (GCC) or Windows (MSVS) because the
compiler was not applying the appropriate optimizations.

This CL contains a more portable fix.  This was briefly
landed by libpng, but backed out.  They fear it increases
code size and that the compiler can be forced to make
the same optimization.

FWIW, we have demonstrated that we can force the compiler
to make the same optimization.
https://codereview.chromium.org/2119813003/

But we feel that changing the compiler options is fragile
and it is better to just carry a diff.

BUG= 619850 
BUG= 599917 

Review-Url: https://codereview.chromium.org/2132783002
Cr-Commit-Position: refs/heads/master@{#404379}

[modify] https://crrev.com/67058eff9c2a51e589388d7d494b1490530a1ec5/third_party/libpng/README.chromium
[modify] https://crrev.com/67058eff9c2a51e589388d7d494b1490530a1ec5/third_party/libpng/pngwutil.c
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38bef90282b731572ca2fab9efaef54d7e3b3726

commit 38bef90282b731572ca2fab9efaef54d7e3b3726
Author: msarett <msarett@google.com>
Date: Mon Jul 11 14:53:49 2016

Update README.chromium in libpng

BUG= 599917 
BUG= 619850 

Review-Url: https://codereview.chromium.org/2138563002
Cr-Commit-Position: refs/heads/master@{#404658}

[modify] https://crrev.com/38bef90282b731572ca2fab9efaef54d7e3b3726/third_party/libpng/README.chromium

Comment 25 by msarett@chromium.org, Jul 12 2016

Status: Fixed (was: Started)
Project Member

Comment 26 by bugdroid1@chromium.org, Sep 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/frecon/+/006bdb2c68d9f0eb0a68cace02b953c11e5f630d

commit 006bdb2c68d9f0eb0a68cace02b953c11e5f630d
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Sep 14 17:43:48 2016

fix implicit decl errors

Some files use funcs but don't include the headers they need.
This works because some libpng headers include them implicitly,
but with newer libpng versions, that's no longer the case.

.../frecon/dbus.c:199:3: error: implicit declaration
      of function 'usleep' is invalid in C99
      [-Werror,-Wimplicit-function-declaration]
                usleep(DBUS_WAIT_DELAY_US);

.../frecon/dev.c:97:9: error: implicitly declaring
      library function 'strcmp' with type 'int (const char *, const char *)'
      [-Werror,-Wimplicit-function-declaration]
                        if (!strcmp("input", udev_device_get_subsystem(dev))) {

BUG= chromium:599917 
TEST=build works again

Change-Id: I3e74b6ccb6b9c6d22e7b0a7b1778576237412f85
Reviewed-on: https://chromium-review.googlesource.com/385656
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Dominik Behr <dbehr@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/006bdb2c68d9f0eb0a68cace02b953c11e5f630d/dbus.c
[modify] https://crrev.com/006bdb2c68d9f0eb0a68cace02b953c11e5f630d/dev.c
Project Member

Comment 27 by bugdroid1@chromium.org, Sep 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/13ff95fb51db47633240d761daa1651930131b60

commit 13ff95fb51db47633240d761daa1651930131b60
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Sep 14 16:57:57 2016

pnm2png: split into dedicated package

This is the only thing that we've done custom to the libpng ebuild, and
it's keeping us from easily upgrading to upstream unmodified.  Since the
code doesn't really need to be integrated into the libpng ebuild, and it
rarely changes (1.2.56 to 1.6.25 is entirely style updates), just create
a dedicated ebuild to hold it.  This will let us drop our custom version
of libpng from our repo and move to latest upstream.

BUG= chromium:599917 
TEST=precq passes (clean upgrade of libpng/pnm2png/lorgnette)

Change-Id: I2b31dcee4907509392cdab3ceac0909d51857063
Reviewed-on: https://chromium-review.googlesource.com/385596
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>

[rename] https://crrev.com/13ff95fb51db47633240d761daa1651930131b60/media-libs/libpng/libpng-1.2.56-r2.ebuild
[add] https://crrev.com/13ff95fb51db47633240d761daa1651930131b60/media-gfx/pnm2png/Manifest
[modify] https://crrev.com/13ff95fb51db47633240d761daa1651930131b60/media-libs/libpng/libpng-1.2.56.ebuild
[add] https://crrev.com/13ff95fb51db47633240d761daa1651930131b60/media-gfx/pnm2png/pnm2png-1.6.25.ebuild
[rename] https://crrev.com/13ff95fb51db47633240d761daa1651930131b60/media-gfx/pnm2png/files/pnm2png-1.2.56-pnm2png-truncate-get-token.patch
[modify] https://crrev.com/13ff95fb51db47633240d761daa1651930131b60/chromeos-base/lorgnette/lorgnette-9999.ebuild
[modify] https://crrev.com/13ff95fb51db47633240d761daa1651930131b60/profiles/targets/chromeos/package.use
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/7fd6a13abefb805806f4d41ef4e2ce89b638b699

commit 7fd6a13abefb805806f4d41ef4e2ce89b638b699
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Sep 14 14:24:45 2016

libpng: upgraded package to upstream

Upgraded media-libs/libpng to version 1.6.25 for all.
This is only used in the sdk atm.

BUG= chromium:599917 
TEST=precq is happy

Change-Id: I383a599aedd0c130e1acc12f59c3725345e3163a
Reviewed-on: https://chromium-review.googlesource.com/385616
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>

[modify] https://crrev.com/7fd6a13abefb805806f4d41ef4e2ce89b638b699/media-libs/libpng/Manifest
[rename] https://crrev.com/7fd6a13abefb805806f4d41ef4e2ce89b638b699/media-libs/libpng/libpng-1.6.25.ebuild
[modify] https://crrev.com/7fd6a13abefb805806f4d41ef4e2ce89b638b699/media-libs/libpng/metadata.xml
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6bc3bd3d0f50de086fd96bba070e615a44a57601

commit 6bc3bd3d0f50de086fd96bba070e615a44a57601
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Sep 14 17:21:15 2016

libpng: upgrade to 1.6 for boards

We've had libpng-1.6 installed for the sdk for a while, but kept boards
back on the 1.2 series to stay in sync with Chromium.  Since they have
upgraded to 1.6 now, we can stop holding CrOS boards back.  Dropping the
code here allows the existing libpng in portage-stable to work.

BUG= chromium:599917 
TEST=amd64-generic vmtest passes

Change-Id: Iaf952ee35449c199ba4cdc20e748c704e019b496
Reviewed-on: https://chromium-review.googlesource.com/388511
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Commit-Ready: Jungshik Shin <jshin@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>

[delete] https://crrev.com/7f645038999c8952478175b2e3e43f18297eced6/media-libs/libpng/Manifest
[delete] https://crrev.com/7f645038999c8952478175b2e3e43f18297eced6/media-libs/libpng/libpng-1.2.56-r2.ebuild
[modify] https://crrev.com/6bc3bd3d0f50de086fd96bba070e615a44a57601/profiles/targets/chromeos/package.mask
[delete] https://crrev.com/7f645038999c8952478175b2e3e43f18297eced6/media-libs/libpng/metadata.xml
[delete] https://crrev.com/7f645038999c8952478175b2e3e43f18297eced6/media-libs/libpng/libpng-1.2.56.ebuild
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 13 2016

Labels: merge-merged-release-R54-8743.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/frecon/+/df257b8ee0b5b6171703839fc0bbc9d0ca3d7aac

commit df257b8ee0b5b6171703839fc0bbc9d0ca3d7aac
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Sep 14 17:43:48 2016

fix implicit decl errors

Some files use funcs but don't include the headers they need.
This works because some libpng headers include them implicitly,
but with newer libpng versions, that's no longer the case.

.../frecon/dbus.c:199:3: error: implicit declaration
      of function 'usleep' is invalid in C99
      [-Werror,-Wimplicit-function-declaration]
                usleep(DBUS_WAIT_DELAY_US);

.../frecon/dev.c:97:9: error: implicitly declaring
      library function 'strcmp' with type 'int (const char *, const char *)'
      [-Werror,-Wimplicit-function-declaration]
                        if (!strcmp("input", udev_device_get_subsystem(dev))) {

BUG= chromium:599917 
TEST=build works again

Change-Id: I3e74b6ccb6b9c6d22e7b0a7b1778576237412f85
Previous-Reviewed-on: https://chromium-review.googlesource.com/385656
(cherry picked from commit 70ddfa9f0577d13eb994a08c1963fa50f9aa5692)
Reviewed-on: https://chromium-review.googlesource.com/398459
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Dominik Behr <dbehr@chromium.org>
Commit-Queue: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/df257b8ee0b5b6171703839fc0bbc9d0ca3d7aac/dbus.c
[modify] https://crrev.com/df257b8ee0b5b6171703839fc0bbc9d0ca3d7aac/dev.c
►

Sign in to add a comment