New issue
Advanced search Search tips

Issue 599905 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Implement UMA metrics for paint

Project Member Reported by chrishtr@chromium.org, Apr 1 2016

Issue description

Paint.

Paint invalidation.

Compositing.

With the launch of Synchronized Paint, we lost metrics for Paint. We
never had them for Paint Invalidation or Compositing.
 
Labels: ReleaseBlock-Beta
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19527e9d324c69604169e40c632a636a180ca58c

commit 19527e9d324c69604169e40c632a636a180ca58c
Author: chrishtr <chrishtr@chromium.org>
Date: Fri Apr 01 19:54:39 2016

Add UMA stats for time in paint+layout, compositing, paint invalidation and paint.

BUG= 599905 

Review URL: https://codereview.chromium.org/1852633002

Cr-Commit-Position: refs/heads/master@{#384666}

[modify] https://crrev.com/19527e9d324c69604169e40c632a636a180ca58c/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/19527e9d324c69604169e40c632a636a180ca58c/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/19527e9d324c69604169e40c632a636a180ca58c/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/19527e9d324c69604169e40c632a636a180ca58c/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h
[modify] https://crrev.com/19527e9d324c69604169e40c632a636a180ca58c/third_party/WebKit/Source/platform/DEPS
[modify] https://crrev.com/19527e9d324c69604169e40c632a636a180ca58c/third_party/WebKit/Source/platform/Histogram.h
[add] https://crrev.com/19527e9d324c69604169e40c632a636a180ca58c/third_party/WebKit/Source/platform/HistogramTest.cpp
[modify] https://crrev.com/19527e9d324c69604169e40c632a636a180ca58c/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/19527e9d324c69604169e40c632a636a180ca58c/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-50
I'd like to merge this in order to fix UMA data for paint in Chrome 50 before it
goes to stable.

Comment 4 by tin...@google.com, Apr 1 2016

Labels: -Merge-Request-50 Merge-Review-50 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.

Comment 5 by tin...@google.com, Apr 4 2016

Labels: -Merge-Review-50 Merge-Approved-50
Merge approved for M50 (branch: 2661), pls merge asap.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6ba6df77008784eb27336aa1f99e37bb0f3dfbd

commit d6ba6df77008784eb27336aa1f99e37bb0f3dfbd
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Tue Apr 05 15:49:05 2016

Add UMA stats for time in paint+layout, compositing, paint invalidation and paint.

BUG= 599905 

Review URL: https://codereview.chromium.org/1852633002

Cr-Commit-Position: refs/heads/master@{#384666}
(cherry picked from commit 19527e9d324c69604169e40c632a636a180ca58c)

Review URL: https://codereview.chromium.org/1864543002 .

Cr-Commit-Position: refs/branch-heads/2661@{#492}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/d6ba6df77008784eb27336aa1f99e37bb0f3dfbd/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/d6ba6df77008784eb27336aa1f99e37bb0f3dfbd/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/d6ba6df77008784eb27336aa1f99e37bb0f3dfbd/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/d6ba6df77008784eb27336aa1f99e37bb0f3dfbd/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h
[modify] https://crrev.com/d6ba6df77008784eb27336aa1f99e37bb0f3dfbd/third_party/WebKit/Source/platform/DEPS
[modify] https://crrev.com/d6ba6df77008784eb27336aa1f99e37bb0f3dfbd/third_party/WebKit/Source/platform/Histogram.h
[add] https://crrev.com/d6ba6df77008784eb27336aa1f99e37bb0f3dfbd/third_party/WebKit/Source/platform/HistogramTest.cpp
[modify] https://crrev.com/d6ba6df77008784eb27336aa1f99e37bb0f3dfbd/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/d6ba6df77008784eb27336aa1f99e37bb0f3dfbd/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment