New issue
Advanced search Search tips

Issue 599903 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clean up chrome/browser/memory_details*.cc now that chrome://memory is gone.

Project Member Reported by asvitk...@chromium.org, Apr 1 2016

Issue description

Clean up chrome/browser/memory_details*.cc now that chrome://memory is gone.


 
Context for chrome://memory removal: https://bugs.chromium.org/p/chromium/issues/detail?id=588790
Owner: ellyjo...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9

commit cd6e449de2bb5f8c4594ad0bb19225f77c89cea9
Author: ellyjones <ellyjones@chromium.org>
Date: Wed Apr 13 19:31:15 2016

This mode was only used in chrome://memory, which has been removed, so it's all dead code now, as is ProcessInfoSnapshot.

BUG= 599903 

Review URL: https://codereview.chromium.org/1874483002

Cr-Commit-Position: refs/heads/master@{#387067}

[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/browser/memory/oom_memory_details.cc
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/browser/memory_details.cc
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/browser/memory_details.h
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/browser/memory_details_android.cc
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/browser/memory_details_linux.cc
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/browser/memory_details_mac.cc
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/browser/memory_details_win.cc
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/browser/metrics/metrics_memory_details_browsertest.cc
[delete] https://crrev.com/cf3df483a780df28a47c4a70ef9c6311e7c3753b/chrome/browser/process_info_snapshot.h
[delete] https://crrev.com/cf3df483a780df28a47c4a70ef9c6311e7c3753b/chrome/browser/process_info_snapshot_mac.cc
[delete] https://crrev.com/cf3df483a780df28a47c4a70ef9c6311e7c3753b/chrome/browser/process_info_snapshot_mac_unittest.cc
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/browser/site_details_browsertest.cc
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/chrome_browser.gypi
[modify] https://crrev.com/cd6e449de2bb5f8c4594ad0bb19225f77c89cea9/chrome/chrome_tests_unit.gypi

Status: Fixed (was: Assigned)
:)

Sign in to add a comment