New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 599896 link

Starred by 1 user
Status: Fixed
Owner:
█ mcgrathr@chromium.org
Last visit 26 days ago
Closed: Apr 2016
Cc:
█ binji@chromium.org
█ bradnelson@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

NaCl SDK build failing with error about "arm_tune" in GN

Project Member Reported by mseaborn@chromium.org, Apr 1 2016 
The NaCl SDK build is currently failing with this error:

Running: /mnt/data/b/build/slave/sdk/build/src/buildtools/linux64/gn gen --args=is_debug=false nacl_sdk_untrusted=true target_cpu="x64" out/gnbuild-x64
ERROR at //build/config/compiler/BUILD.gn:439:11: Undefined identifier
      if (arm_tune != "") {
          ^-------

From https://build.chromium.org/p/client.nacl.sdk/builders/linux-sdk-multi/builds/12087/steps/SDK%20Items/logs/stdio

Comment 1 by mseaborn@chromium.org, Apr 1 2016 

This seems to have started in the Git revision range 90402631526ae56767c77720ee4e61bfe4b1c12a..c6e9ccf2ccb95f2643f5a914e77d5217261878d0.

From that, this change looks like the culprit:
https://codereview.chromium.org/1842833003 - "[GN] Declare arm arguments when target_cpu == "arm"."
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ad45bcd53fd0fe40c962ebff8dd7bc3b2d289c9

commit 9ad45bcd53fd0fe40c962ebff8dd7bc3b2d289c9
Author: mcgrathr <mcgrathr@chromium.org>
Date: Fri Apr 01 22:09:38 2016

GN: Declare ARM build arguments for either target_cpu or current_cpu == "arm"

The change in crrev.com/d2eec2ae67e1494bb3a9aa7e0f1c1612298cccc0 fixed
 crbug.com/592660  but caused  crbug.com/599896 .  The ARM build arguments are
relevant both in a build where target_cpu=="arm" and, in other builds, in
toolchain contexts where current_cpu=="arm".  For example, NaCl toolchains
for all different current_cpu values might be instantiated in a build where
target_cpu ist something else.

BUG= 592660 
BUG= 599896 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1847063006

Cr-Commit-Position: refs/heads/master@{#384703}

[modify] https://crrev.com/9ad45bcd53fd0fe40c962ebff8dd7bc3b2d289c9/build/config/arm.gni

Comment 3 by mseaborn@chromium.org, Apr 1 2016

Owner: mcgrathr@chromium.org
Status: Fixed (was: Untriaged)
Thanks for fixing this, Roland.
►

Sign in to add a comment