Show the unread-count button of the message center at all times |
||||||||||||||||||||||||||||
Issue description
This is requested by the UX (jennyschen@).
Currently, the unread-count button is shown only when the user logged-in and there are any notification(s).
In addition, we need to show the button:
- even when there is no notification ("0" on the button)
- even on the lock screen
Hiro, Jenn, please add additional information if you have.
,
Apr 1 2016
It may be helpful to have a bell instead of a 0 for no notifications. There definitely could be some fun treatments for the empty state as well which I am happy to take with design. On the lock screen, the user should have to authenticate before they can see notification content.
,
Apr 1 2016
,
Apr 1 2016
,
Apr 1 2016
> On the lock screen, the user should have to authenticate before they can see notification content. It might be helpful to show some message (or visible effect) to notify users that you need to authenticate to see notifications. So, I think it's better to do either: - Show some message (or visual effect) which tells user that you need to authenticate, just after user clicks the button - Make the button gray to tell user that the button is not clickable
,
Apr 2 2016
#CBC-RS/TC-watchlist So happy to see activity on this. We have received quite a few comments in CBC from users regarding their "missing" notifications icon. #2 - I especially appreciate "There definitely could be some fun treatments for the empty state as well which I am happy to take with design."
,
Apr 7 2016
Assigning to Jonny for design work.
,
Apr 7 2016
Internal issue: 28027495
,
Apr 8 2016
Here are some empty state and lock screen explorations: https://folio.googleplex.com/_/preview/0B29spHBLr1wTYkhnMlZYWEI0akU/01_notifications/02_empty-state I'm partial to 02 and 05. Thoughts?
,
Apr 13 2016
+1 to 02, since 05 is a little bit too simple I think. Hiro, any ideas?
,
Apr 13 2016
And could you prepare the following assets? - Large bell icon in 02 (if we go with 02) - Disabled-state bell icon at the bottom in 07. - Disabled-state setting icon at the bottom in 07.
,
Apr 13 2016
I'd like to have +Sebastien weigh in here before we finalize.
,
Apr 18 2016
Bell is my preference as well.
,
Apr 18 2016
Yoshiki, here's the bell asset in multiple sizes. Let me know if you need anything else. https://icons.googleplex.com/#icon=ic_notifications
,
Apr 18 2016
Careful, old chrome OS core ui uses a complete different icon grid than MD. It might render badly.
,
Apr 18 2016
Also: I'm assuming the empty state itself is still in-progress? It looks a little strange to have a menu that short. Meta comment: when this is more complete, please get design direction approval by us over at chromeos-ui-review@.
,
Apr 18 2016
Visuals are final. It's small to avoid taking screen space to display nothing.
,
Apr 19 2016
@mitsuji, as this becomes more complete, please make sure to take this through chromeos-ui-review@ so we can get agreement on design direction and avoid churn.
,
Apr 22 2016
Attached is the final direction (approved through Chrome OS UI review). Yoshiki, feel free to let me know if you have any questions. Thanks!
,
Apr 25 2016
Thank you for finalizing! How about the lock screen message? We use the same layout (like mock in comment #20)? Or like mock in comment #9?
,
Apr 25 2016
,
Apr 26 2016
No lock screen message necessary. See Kuscher's comment in the UI thread here: https://groups.google.com/a/google.com/forum/?hl=en#!topic/chromeos-ui-review/_Etpqb7N9qg
,
Apr 28 2016
Thanks, let me do this.
,
May 10 2016
See the notification bell assets attached for the current shelf design. I believe we only need the two states I included (normal and _p for pressed (white on blue). Let me know if you need anything else.
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65dafe01584f929280381544785961d5d5d26b3d commit 65dafe01584f929280381544785961d5d5d26b3d Author: yoshiki <yoshiki@chromium.org> Date: Thu May 12 02:29:51 2016 Show the unread button even without any unread notifications The unread button was shown only when there are any notifications. This patch shows it even when there is no notifications. BUG= 599891 Review-Url: https://codereview.chromium.org/1961793002 Cr-Commit-Position: refs/heads/master@{#393151} [modify] https://crrev.com/65dafe01584f929280381544785961d5d5d26b3d/ash/system/web_notification/web_notification_tray.cc
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/821655984efbc9151a6182e56854f6bc01856dc5 commit 821655984efbc9151a6182e56854f6bc01856dc5 Author: yoshiki <yoshiki@chromium.org> Date: Thu May 12 09:38:04 2016 Show the bell icon when no unread-notification state This patch shows the bell icon instead of the number "0" in the unread button in the status bar, when there are no unread notifications in message center. BUG= 599891 TEST=manually Review-Url: https://codereview.chromium.org/1958903003 Cr-Commit-Position: refs/heads/master@{#393215} [modify] https://crrev.com/821655984efbc9151a6182e56854f6bc01856dc5/ash/resources/ash_resources.grd [add] https://crrev.com/821655984efbc9151a6182e56854f6bc01856dc5/ash/resources/default_100_percent/common/shelf/notification_tray_bell.png [add] https://crrev.com/821655984efbc9151a6182e56854f6bc01856dc5/ash/resources/default_200_percent/common/shelf/notification_tray_bell.png [modify] https://crrev.com/821655984efbc9151a6182e56854f6bc01856dc5/ash/system/web_notification/web_notification_tray.cc
,
May 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e188badbc20ef3e535e706be977d199807047c6 commit 4e188badbc20ef3e535e706be977d199807047c6 Author: yoshiki <yoshiki@chromium.org> Date: Mon May 16 06:53:43 2016 Show no-notification message in the bottom label of message center This patch shows the no-notification message ("You have no notifications") in the bottom label of message center, which shows "Notification" in general. Previously, the message was shown at the other message view above the label. But it will be removed by the separated patch (crrev.com/1961803002). BUG= 599891 TEST=manually tested Review-Url: https://codereview.chromium.org/1961813002 Cr-Commit-Position: refs/heads/master@{#393798} [modify] https://crrev.com/4e188badbc20ef3e535e706be977d199807047c6/ui/message_center/views/message_center_bubble.cc [modify] https://crrev.com/4e188badbc20ef3e535e706be977d199807047c6/ui/message_center/views/message_center_bubble.h [modify] https://crrev.com/4e188badbc20ef3e535e706be977d199807047c6/ui/message_center/views/message_center_button_bar.cc [modify] https://crrev.com/4e188badbc20ef3e535e706be977d199807047c6/ui/message_center/views/message_center_button_bar.h [modify] https://crrev.com/4e188badbc20ef3e535e706be977d199807047c6/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/4e188badbc20ef3e535e706be977d199807047c6/ui/message_center/views/message_center_view.h [modify] https://crrev.com/4e188badbc20ef3e535e706be977d199807047c6/ui/message_center/views/message_center_view_unittest.cc [modify] https://crrev.com/4e188badbc20ef3e535e706be977d199807047c6/ui/strings/ui_strings.grd
,
May 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2768accc154d067704fb501967de68cba9fa4c3b commit 2768accc154d067704fb501967de68cba9fa4c3b Author: yoshiki <yoshiki@chromium.org> Date: Mon May 16 15:09:07 2016 Remove NoNotificationMessageView from message center This patch removes NoNotificationMessageView which is shown when the message center has no notification, and instead the separated patch (crrev.com/1961813002) will show the no-notification message at the bottom label. This patch also fixes the geometry bug, which calculated the height wrongly, in ui/message_center/views/message_center_view.cc:286. BUG= 599891 TEST=manually tested Review-Url: https://codereview.chromium.org/1961803002 Cr-Commit-Position: refs/heads/master@{#393833} [modify] https://crrev.com/2768accc154d067704fb501967de68cba9fa4c3b/ui/message_center/views/message_center_button_bar.cc [modify] https://crrev.com/2768accc154d067704fb501967de68cba9fa4c3b/ui/message_center/views/message_center_button_bar.h [modify] https://crrev.com/2768accc154d067704fb501967de68cba9fa4c3b/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/2768accc154d067704fb501967de68cba9fa4c3b/ui/message_center/views/message_center_view.h [modify] https://crrev.com/2768accc154d067704fb501967de68cba9fa4c3b/ui/message_center/views/message_center_view_unittest.cc
,
May 23 2016
FYI I am switching the bell icon to use the vectorized version: https://codereview.chromium.org/2005063002
,
May 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/faa0ab38631cf9aa7e369f7a3e34c1767a61726b commit faa0ab38631cf9aa7e369f7a3e34c1767a61726b Author: tdanderson <tdanderson@chromium.org> Date: Mon May 23 23:56:57 2016 Use vector icon for no unread notifications bell Use a vector icon instead of a PNG for the notifications icon shown when there are no unread notifications (bell). Delete the now-unsed image assets with id IDR_ASH_SHELF_NOTIFICATION_TRAY_BELL. BUG=595015, 599891 TEST=manual Review-Url: https://codereview.chromium.org/2005063002 Cr-Commit-Position: refs/heads/master@{#395470} [modify] https://crrev.com/faa0ab38631cf9aa7e369f7a3e34c1767a61726b/ash/resources/ash_resources.grd [delete] https://crrev.com/76a016568a6b224945dd21b04e3eb783673f0e37/ash/resources/default_100_percent/common/shelf/notification_tray_bell.png [delete] https://crrev.com/76a016568a6b224945dd21b04e3eb783673f0e37/ash/resources/default_200_percent/common/shelf/notification_tray_bell.png [modify] https://crrev.com/faa0ab38631cf9aa7e369f7a3e34c1767a61726b/ash/system/web_notification/web_notification_tray.cc
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50 commit 48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50 Author: yoshiki <yoshiki@chromium.org> Date: Fri May 27 05:49:50 2016 Show message center on lock screen This patch does: - Show the message center button on tray on the lock screen - Show the message to encourage user to log in when user opens message center on lock screen - Add SetLockedState(bool) and IsLockedState() method into MessageCenter class. - Don't make notifications read when opening the message center on lock screen - Add tests And this patch also fixes the bug that this makes blocked notifications read wrongly. BUG= 599891 TEST=manually tested Review-Url: https://codereview.chromium.org/1986493002 Cr-Commit-Position: refs/heads/master@{#396402} [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/fake_message_center.cc [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/fake_message_center.h [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/message_center.h [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/message_center_impl.cc [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/message_center_impl.h [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/message_center_observer.h [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/notification_list.cc [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/notification_list.h [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/notification_list_unittest.cc [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/views/message_center_view.h [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/message_center/views/message_center_view_unittest.cc [modify] https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50/ui/strings/ui_strings.grd
,
May 27 2016
,
May 27 2016
Does this need to be restricted?
,
May 27 2016
Issue 296041 has been merged into this issue.
,
May 27 2016
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d19388b6f1ca92183d28a7d4df9ceb9101309676 commit d19388b6f1ca92183d28a7d4df9ceb9101309676 Author: nednguyen <nednguyen@google.com> Date: Fri May 27 17:08:04 2016 Revert of Show message center on lock screen (patchset #2 id:120001 of https://codereview.chromium.org/1986493002/ ) Reason for revert: Speculative revert: this may cause message_center_unittests failure on Ubuntu-12.04 BUG= 615443 Original issue's description: > Show message center on lock screen > > This patch does: > - Show the message center button on tray on the lock screen > - Show the message to encourage user to log in when user opens message center on lock screen > - Add SetLockedState(bool) and IsLockedState() method into MessageCenter class. > - Don't make notifications read when opening the message center on lock screen > - Add tests > > And this patch also fixes the bug that this makes blocked notifications read wrongly. > > BUG= 599891 > TEST=manually tested > > Committed: https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50 > Cr-Commit-Position: refs/heads/master@{#396402} TBR=dewittj@chromium.org,skuhne@chromium.org,yoshiki@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 599891 Review-Url: https://codereview.chromium.org/2018063002 Cr-Commit-Position: refs/heads/master@{#396495} [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/fake_message_center.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/fake_message_center.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/message_center.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/message_center_impl.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/message_center_impl.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/message_center_observer.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/notification_list.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/notification_list.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/notification_list_unittest.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/views/message_center_view.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/views/message_center_view_unittest.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/strings/ui_strings.grd
,
May 29 2016
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d827a875b4c7a0063dc63ed336d3fb08fc0faec commit 2d827a875b4c7a0063dc63ed336d3fb08fc0faec Author: yoshiki <yoshiki@chromium.org> Date: Tue May 31 04:58:15 2016 Reland: Show message center on lock screen The original CL (crrev.com/396402) was comitted but reverted (crrev.com/396495) due to MSAN failure (forgetting free the instance). This patch relands it with changing it with unique_ptr. BUG= 615443 TEST=MSAN bot passes TBR=dewittj@chromium.org, skuhne@chromium.org This patch does: - Show the message center button on tray on the lock screen - Show the message to encourage user to log in when user opens message center on lock screen - Add SetLockedState(bool) and IsLockedState() method into MessageCenter class. - Don't make notifications read when opening the message center on lock screen - Add tests And this patch also fixes the bug that this makes blocked notifications read wrongly. BUG= 599891 TEST=manually tested Committed: https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50 Cr-Commit-Position: refs/heads/master@{#396402} Review-Url: https://codereview.chromium.org/2025613002 Cr-Commit-Position: refs/heads/master@{#396785} [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/fake_message_center.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/fake_message_center.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/message_center.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/message_center_impl.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/message_center_impl.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/message_center_observer.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/notification_list.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/notification_list.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/notification_list_unittest.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/views/message_center_view.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/views/message_center_view_unittest.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/strings/ui_strings.grd
,
May 31 2016
,
Jul 1 2016
,
Aug 29 2016
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||
Comment 1 by yoshiki@chromium.org
, Apr 1 2016