New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599888 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 584303



Sign in to add a comment

[tracking bug] The fakebox-to-omnibox transition animation is broken on the snippets UI

Project Member Reported by dgn@chromium.org, Apr 1 2016

Issue description

Demo1: master build with NTPSnippets enabled
Demo2: chrome stable

It looks like the value used for the vertical scroll position is not the right one.
 
demo1.mp4
4.9 MB Download
demo2.mp4
5.4 MB Download
I already looked into this before. The problem is that computeVerticalScroll() guesses how much you've scrolled by using (the currently visible RecyclerView items' average height) * (number of times in the adapter) as the height of the RecyclerVirw. In our case, since the first RecyclerView element is so huge, it throws off the calculation and cuases that jump in animation when computeVerticalScroll recalculates its estimate. 

(BTW,I really thought I already filed a tracking bug for this. I'll look for it when I get back)
Components: UI>Browser>NewTabPage
Owner: mcwilliams@chromium.org
Status: Started (was: Assigned)
Cc: rachelis@chromium.org
These is another issues, when in landscape mode, the text 'Search or type URL' is displayed, scrolling slowly, the text fades out - and then fades back in again from the side which is strange. I feel the text should not fade at all if it comes back. The alignment of the box is also about 2px out at one stage when scrolling up.
When the discard snippets cl lands - the search box scroll does not update so need to look at this too
Thanks Nicole. I'm in Australia today, so please feel free to ping me your Tuesday AM if you need input. It sounds like you're continuing to move forward and will grab me when you want eyes on this. :)
Re: Comment #1 - after looking at the video, it looks like the other bug I'm referencing (crbug/596420) is different. The other bug specifically refers to the jump the omnibox does when transitioning from above the fold to snippets.
There are a number of issues with the scroll and a bug raise for each. The initial bug intention has been fix, here are the follow up bugs:

Snapping to top or bottom: crbug/596416
Omnibox below the fold: crbug/596420
Mobile fake omnibox text fading and replacing with actual omnibox: crbug/600748

Learning tricks:
Snapping to top or bottom:  issue 596416 
Omnibox below the fold:  issue 596420 
Mobile fake omnibox text fading and replacing with actual omnibox:  issue 600748 
Labels: zine-mr-iter-9
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 8 2016

Status: Fixed (was: Started)
Labels: zine-mr-MVP
Labels: -zine-mr-mvp
Labels: zine-mr-MVP

Sign in to add a comment