Issue metadata
Sign in to add a comment
|
[Custom Formatters] 'bindRemoteObject' is missing
Reported by
antonin....@gmail.com,
Apr 1 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.110 Safari/537.36 Steps to reproduce the problem: 1. run cljs-devtools-sample web server by following: https://github.com/binaryage/cljs-devtools-sample#local-setup 2. navigate to http://localhost:7000 3. click a disclosure triangle to expand any custom formatted with green-ish background, for example the first one [nil 43 0.1 ...] What is the expected behavior? Custom-formatted item should get expanded. What went wrong? Javascript console errors with "... Custom Formatter Failed: ReferenceError: bindRemoteObject is not defined" Did this work before? Yes broke sometime mid March 2016 in canaries Chrome version: 51.0.2696.0 Channel: canary OS Version: OS X 10.11.4 Flash Version: Shockwave Flash 21.0 r0 possibly related to https://bugs.chromium.org/p/chromium/issues/detail?id=595206 This is not an isolated cljs-devtools issue, the same breakage is reported from immutable-devtools as well: https://github.com/andrewdavey/immutable-devtools/issues/19 https://github.com/binaryage/cljs-devtools/issues/14
,
Apr 4 2016
,
Apr 4 2016
,
Apr 4 2016
,
Apr 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dfa303ce1c90c4b0598239d88a1b02b4cc9fb8a commit 4dfa303ce1c90c4b0598239d88a1b02b4cc9fb8a Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Apr 06 04:51:17 2016 [DevTools] Fix custom formatters Added bindRemoteObject to whitelist for namedPropertyFromDebuggerScopeExtension. Inject remote object API on function call instead function compilation. BUG= 599884 R=dgozman@chromium.org,pfeldman@chromium.org Review URL: https://codereview.chromium.org/1855393003 Cr-Commit-Position: refs/heads/master@{#385383} [modify] https://crrev.com/4dfa303ce1c90c4b0598239d88a1b02b4cc9fb8a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp [modify] https://crrev.com/4dfa303ce1c90c4b0598239d88a1b02b4cc9fb8a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp [modify] https://crrev.com/4dfa303ce1c90c4b0598239d88a1b02b4cc9fb8a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp [modify] https://crrev.com/4dfa303ce1c90c4b0598239d88a1b02b4cc9fb8a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h [modify] https://crrev.com/4dfa303ce1c90c4b0598239d88a1b02b4cc9fb8a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
,
Apr 6 2016
,
Apr 7 2016
I confirm that it is fixed in 51.0.2702.0 canary (64-bit) [Mac]. Thank you for quick resolution.
,
May 30 2016
Unfortunately it seems not all cases got fixed by this. I'm getting bug reports from some users having this issue in more recent Chrome versions under some circumstances. It looks to me that there are still some code paths which end up with "bindRemoteObject is not defined". https://github.com/binaryage/dirac/issues/20 https://github.com/binaryage/cljs-devtools/issues/14 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kozyatinskiy@chromium.org
, Apr 4 2016Status: Assigned (was: Unconfirmed)