New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 599871 link

Starred by 4 users
Status: Archived
Owner:
█ mmo...@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
█ scottj@chromium.org
█ cco3@chromium.org
mattreynolds@chromium.org
█ animohan@chromium.org
█ mmo...@chromium.org
█ rzhao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add support for large icons to Physical Web Activity

Project Member Reported by mmo...@chromium.org, Apr 1 2016 
It looks like we are hard coding our layout to have icons be 16x16: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/java/res/layout/physical_web_list_item_nearby_url.xml&q=nearby_urls_icon&sq=package:chromium&type=cs&l=10

PWS is adding support for finding larger icons on the page.  Since we don't have a specific size target in mind, the actual size may vary.

We may even amend the PWS API to just return the full list of icons and their expected sizes (as specified by `sizes` attribute or by Web App Manifest).

Comment 1 by scottj@chromium.org, Apr 1 2016 

The icons are 16x16dp, which would LOVE to have higher resolution icons on newer android devices. Also, we're looking into making the icons 32x32 (taking up 2 lines) so there is value in getting the higher rez icons

Also, given that we had that privacy leak with the URL for the favicon earlier, does this mean we'd need to cache every icon we find (if we want to return a list?) I'm wondering if just returning the single highest rez would be enough for now?

Comment 2 by mmo...@chromium.org, Apr 1 2016 

The returned list would all use proxied URLs.  It's just a list, so Chrome wouldn't fetch any that it doesn't use.

The reason to use a list, much like with Web App Manifest, is that the ideal size may differ for different clients on different devices in different places.

For now, yes, we will try to just return the single highest resolution image, within reason.

However, it will probably just be shrunk down to 16x16 because of the current implementation (I haven't confirmed).

I can provide some URLs to low/high res icons which my local PWS is finding to help test:

Youtube:
  - low res: https://lh5.googleusercontent.com/proxy/XO6Fhu5s7Qa4yTLkmyjIiPqWKaUM9M1-bqU2TrqkV7meB7IWmyb3MNkx95as6fBv7XfpbBNSfOwTFSNZxq4pVmej
  - high res: https://lh4.googleusercontent.com/proxy/3bUF0kiCBpLkv75EgQl7KLrNsDJMAYUEne0LhE9f7crS-Mt3t3GXH5U2xIhuT2uzGdXA-irTofoUkrNqnp-z5_gw

Facebook:
  - low res: https://lh6.googleusercontent.com/proxy/xbPeFBXHs4TkjjXPTGSB6HDq7XT3Z4xfON8usawwXIQasyr0Bz_e7Cd46GBrjYtp9cA_bJPumuhonIX__e3p82Je1p8gXio1kK8
  - high res: https://lh5.googleusercontent.com/proxy/8SxsIM1mtisLdZ4NWUPSFfIXI-5urqmAHpvB-S3QEi43VNZ9Cmorgcsow1MLZoa_5yW3-pD0IRodlHpOlCsa7CohsIs

Comment 3 by mmo...@chromium.org, Apr 4 2016

Labels: M-52
Lets just try to increase to 32x32 or 48x48 always -- to investigate.

Comment 4 by kolos@chromium.org, Apr 5 2016

Components: Privacy

Comment 5 by cco3@chromium.org, May 24 2016 

It's currently at 32x32...anything else that's needed here?

Comment 6 by cco3@chromium.org, May 24 2016

Owner: mmo...@chromium.org
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 14 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by mmo...@chromium.org, Jan 9 2017

Status: Archived (was: Available)
►

Sign in to add a comment