New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 599844 link

Starred by 1 user
Status: Fixed
Owner:
treib@chromium.org
Closed: Apr 2016
Cc:
█ bauerb@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

chrome://popular-sites-internals: Show country and version

Project Member Reported by treib@chromium.org, Apr 1 2016 
On chrome://popular-sites-internals, after a successful download we should show which country and version was actually downloaded, because:
- It's not obvious which defaults got chosen, and
- even if you know the defaults or put in explicit values, a fallback might have kicked in.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12

commit f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12
Author: treib <treib@chromium.org>
Date: Thu Apr 07 14:44:11 2016

[NTP Popular Sites] Store country/version in prefs
...and show on chrome://popular-sites-internals

BUG= 599844 

Review URL: https://codereview.chromium.org/1851803002

Cr-Commit-Position: refs/heads/master@{#385753}

[modify] https://crrev.com/f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12/chrome/browser/android/ntp/popular_sites.cc
[modify] https://crrev.com/f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12/chrome/browser/android/ntp/popular_sites.h
[modify] https://crrev.com/f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12/chrome/browser/net/file_downloader.cc
[modify] https://crrev.com/f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12/chrome/browser/net/file_downloader.h
[modify] https://crrev.com/f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12/chrome/browser/net/file_downloader_unittest.cc
[modify] https://crrev.com/f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12/chrome/browser/resources/popular_sites_internals.html
[modify] https://crrev.com/f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12/chrome/browser/resources/popular_sites_internals.js
[modify] https://crrev.com/f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12/chrome/browser/supervised_user/supervised_user_service.h
[modify] https://crrev.com/f38cc25bf2d6fa2407d9b3fc7cbdc16836b5ee12/chrome/browser/ui/webui/popular_sites_internals_message_handler.cc

Comment 2 by treib@chromium.org, Apr 7 2016

Status: Fixed (was: Started)
►

Sign in to add a comment