New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599842 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Chrome browser crashes after clicking on back arrow button in chrome://md-settings page.

Reported by rk...@etouch.net, Apr 1 2016

Issue description

Chrome Version: 51.0.2696.0 Revision 39f619275ffbd984d94d17b7c5dbb01a875a38d2-refs/heads/master@{#384437}(32/64 bit)
OS: All(Win-7 Aero Enabled)

Precondition: Enable 'Material design in the browser's top chrome' by selecting 'Material' option.

What steps will reproduce the problem?
(1) Launch chrome,navigate to chrome://md-settings
(2) Click on 'Profile Avtar' icon, clear 'Person 1' text and click on back arrow near to the 'Edit person'.
(3) Observe

Chrome browser crashes after clicking on back arrow button.

Crash ID ca22e1f800000000 (40e39601-bd53-4f3a-bd20-e0905e8dfa70)

Chrome browser should not crash.

This is a regression issue,broken in 'M-49', below is bisect info:

Good Build: 49.0.2615.0
Bad Build: 49.0.2616.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/7b5d43b0e9474238a48be623cab9c5fa95ae2f42..4670776e23949822d6fc9ae94db5eeda1d007a7e?pretty=fuller&n=100

Suspecting: r368181
 
Actual_Crash.mp4
894 KB Download
Cc: dbeam@chromium.org
Labels: -Proj-MaterialDesign-NativeUI Proj-MaterialDesign-WebUI
crash is at:
settings_manage_profile_handler.cc:164
settings::ManageProfileHandler::SetProfileIconAndName(base::ListValue const*)

Thanks for the report and video. I was able to repro. I will fix this.

Nice wallpaper btw.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f97a714079d2dc126c0d818f7593137ab3b62557

commit f97a714079d2dc126c0d818f7593137ab3b62557
Author: tommycli <tommycli@chromium.org>
Date: Tue Apr 05 22:25:04 2016

Settings People Revamp: Fix Mange Profile empty name crash.

Prevents sending an empty string name to C++.

BUG= 597868 , 599842 

Review URL: https://codereview.chromium.org/1857203003

Cr-Commit-Position: refs/heads/master@{#385305}

[modify] https://crrev.com/f97a714079d2dc126c0d818f7593137ab3b62557/chrome/browser/resources/settings/people_page/manage_profile.html
[modify] https://crrev.com/f97a714079d2dc126c0d818f7593137ab3b62557/chrome/browser/resources/settings/people_page/manage_profile.js

Comment 6 by rk...@etouch.net, Apr 14 2016

Just to update:

Issue is fixed in latest canary  build i.e. 52.0.2708.0, kindly refer the attached video.
Actual_Fix.mp4
406 KB Download

Comment 7 by dbeam@chromium.org, Apr 19 2016

Status: Fixed (was: Assigned)

Sign in to add a comment