An old credential never becomes the auto sign-in one |
|||
Issue descriptionVersion: 51 OS: desktop What steps will reproduce the problem? (1 )Go to https://9bf5d6a9ae58c0976f64da8a482db42e19365982.googledrive.com/host/0B4ln_TN4AjcNbzd3RDNQYlJRVG8 and save a credential using the form. (2) Go to https://9bf5d6a9ae58c0976f64da8a482db42e19365982.googledrive.com/host/0B4ln_TN4AjcNbzd3RDNQYlJRVG8 (3) In the console type function processResponse(cred) { window.location = '/'; } navigator.credentials.get({password: true}) .then(processResponse) .catch(function (e) { console.log(e); }); (4) The account chooser appears (correct), click the credential. (5) Go to the page again and repeat. The account chooser appears (wrong, the credential should have became an "auto sign-in" one). Basically, the site will never be able to get a user auto signed-in. The bug is that the autofill password manager detected successful login and "updated" the credential in the store wrongly. A solution approved by Vaclav: Once we return a non-empty credential either via auto-sign-in or the account chooser we should drop all the PasswordFormManager instances for the page. If the returned credential is wrong the Password Manager still should be able to autofill on the fallback form which appears after navigation.
,
Apr 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8290aba0af11ae589b30209ddb570202a93b5cf commit e8290aba0af11ae589b30209ddb570202a93b5cf Author: vasilii <vasilii@chromium.org> Date: Tue Apr 05 14:04:05 2016 Disable the autofill password manager when a credential is sent via CM API. BUG= 599836 Review URL: https://codereview.chromium.org/1850923004 Cr-Commit-Position: refs/heads/master@{#385164} [modify] https://crrev.com/e8290aba0af11ae589b30209ddb570202a93b5cf/chrome/browser/password_manager/chrome_password_manager_client.cc [modify] https://crrev.com/e8290aba0af11ae589b30209ddb570202a93b5cf/chrome/browser/password_manager/chrome_password_manager_client.h [add] https://crrev.com/e8290aba0af11ae589b30209ddb570202a93b5cf/chrome/browser/password_manager/credential_manager_browsertest.cc [modify] https://crrev.com/e8290aba0af11ae589b30209ddb570202a93b5cf/chrome/chrome_tests.gypi [modify] https://crrev.com/e8290aba0af11ae589b30209ddb570202a93b5cf/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/e8290aba0af11ae589b30209ddb570202a93b5cf/components/password_manager/core/browser/password_manager.h [modify] https://crrev.com/e8290aba0af11ae589b30209ddb570202a93b5cf/components/password_manager/core/browser/password_manager_unittest.cc
,
Apr 5 2016
,
Nov 29
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vasi...@chromium.org
, Apr 1 2016Labels: OS-Chrome OS-Linux OS-Mac OS-Windows