New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 599832 link

Starred by 1 user
Status: Fixed
Owner:
█ sh...@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
█ sh...@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

"TwoClientAppListSyncTest.UpdateEnableDisableApp" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Apr 1 2016 
"TwoClientAppListSyncTest.UpdateEnableDisableApp" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOgsSBUZsYWtlIi9Ud29DbGllbnRBcHBMaXN0U3luY1Rlc3QuVXBkYXRlRW5hYmxlRGlzYWJsZUFwcAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by lukasza@chromium.org, Apr 1 2016

Labels: -Sheriff-Chromium OS-Mac
Owner: sh...@chromium.org
This seems to be caused by https://codereview.chromium.org/1834323004, which has introduced the new test assert that is flaky:

shadi	d2ab74f	2016-04-01 01:17:04	[diff] [blame]:
324	  ASSERT_TRUE(AwaitAllProfilesHaveSameApps());
325	  ASSERT_TRUE(AllProfilesHaveSameAppList());
326	  ASSERT_TRUE(HasSameApps(GetProfile(0), GetProfile(1)));
327	  ASSERT_FALSE(IsAppEnabled(GetProfile(0), 0));  <--- FLAKY
328	  ASSERT_FALSE(IsAppEnabled(GetProfile(1), 0));

Example of a flaky failure:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/203813/steps/sync_integration_tests%20%28with%20patch%29%20on%20Mac-10.9/logs/stdio
../../chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc:327: Failure
Value of: IsAppEnabled(GetProfile(0), 0)
  Actual: true
Expected: false

Comment 2 by tapted@chromium.org, Apr 1 2016

Components: Platform>Apps>AppLauncher
Labels: OS-Linux OS-Windows
Status: Assigned (was: Untriaged)
[mac triage] Flakes appear on windows and linux as well. AppList is going away in M32 everywhere except ChromeOS though. Maybe ChromeOS will flake, maybe it won't.

Comment 3 by sh...@chromium.org, Apr 1 2016

Components: Services>Sync
Status: Started (was: Assigned)
The change I committed removed the call to AwaitQuiescence() which is needed. I will fix those tests to fix the flaky issue. 

A subsequent change would be to get rid of AwaitQuiescence() in general as well.

Comment 4 by sh...@chromium.org, Apr 1 2016

Cc: sh...@chromium.org
 Issue 599787  has been merged into this issue.
Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, Apr 2 2016

Labels: Sheriff-Chromium
Detected 6 new flakes for test/step "TwoClientAppListSyncTest.UpdateIncognitoEnableDisable". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQAsSBUZsYWtlIjVUd29DbGllbnRBcHBMaXN0U3luY1Rlc3QuVXBkYXRlSW5jb2duaXRvRW5hYmxlRGlzYWJsZQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 6 by lukasza@chromium.org, Apr 4 2016

Labels: -Sheriff-Chromium
No new flakes since 2016-04-01 - let's hope this is fixed?

Comment 7 by sh...@chromium.org, Apr 4 2016 

Well the original CL was reverted and I just landed it again without the change that could have caused extra flakiness.

Comment 8 by maxbogue@chromium.org, Apr 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment