New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599812 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 621355
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Pull retrieval from PasswordStore out from PasswordFormManager

Project Member Reported by vabr@chromium.org, Apr 1 2016

Issue description

PasswordFormManager currently does too many things: represents forms on the site, facilitates filling and saving, and also fetches data from the PasswordStore.

There might be multiple forms on the page, and all the forms on the same origin will request the same data from the PasswordStore. Doing this repeatedly for each form is wasteful of resources, and an unnecessary complication.

We should pull the credentials-fetching part out of PFM into a dedicated class. The PasswordManager should keep one such class for every relevant origin, and the PFMs could, e.g., reference-count it in some way to indicate which origin is still relevant.

We should make sure that the new class also observes changes in the PasswordStore and notifies PFM if necessary, to avoid bugs like  issue 472088 .

Cc-ing dvadym@, because we have talked about this already.
 

Comment 1 by vabr@chromium.org, Apr 1 2016

Cc: msrchandra@chromium.org smokana@chromium.org
 Issue 472088  has been merged into this issue.

Comment 2 by vabr@chromium.org, Jun 6 2016

Labels: -refactoring Hotlist-Refactoring
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 6 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by vabr@chromium.org, Jun 7 2017

Labels: -Hotlist-Recharge-Cold
Mergedinto: 621355
Status: Duplicate (was: Untriaged)
Turns out I filed this twice.

Sign in to add a comment