New issue
Advanced search Search tips

Issue 599771 link

Starred by 2 users
Status: Archived
Owner:
steve...@chromium.org
Closed: Feb 2017
Cc:
llozano@chromium.org
akes...@chromium.org
derat@chromium.org
achuith@chromium.org
ihf@chromium.org
hashimoto@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Simplify cros chrome-sdk

Project Member Reported by hashimoto@chromium.org, Apr 1 2016 
Remove unused parts to simplify cros chrome-sdk.

Comment 1 by steve...@chromium.org, Apr 5 2016

Cc: achuith@chromium.org ihf@chromium.org akes...@chromium.org
Labels: -Pri-3 Pri-2
Owner: steve...@chromium.org
Assigning this to me so that it does not get lost.

My suggestion here would be:
* Switch chromeos over to GN completely.
* Remove GYP support from Simple Chrome.
* Audit special configuration support in Simple Chrome and eliminate anything that is unused or not worth the maintenance cost.

With GN, developers can easily modify their GN configurations and add additional directories for custom configurations. I think we should be able to take advantage of this to reduce the special case support built into Simple Chrome.

Comment 2 by davidjames@chromium.org, Dec 22 2016

Cc: -davidjames@chromium.org

Comment 3 by steve...@chromium.org, Dec 28 2016

Labels: Pri-3

Comment 4 by steve...@chromium.org, Dec 28 2016

Cc: hashimoto@chromium.org
Labels: Hotlist-CrOS-Gardener
We have switched completely to GN and removed GYP support.

Now, we should:

Deprecate --clang, --component, and --fastbuild; devs who want to use these options can modify GN_ARGS and rerun 'gn gen' themselves.

Comment 5 by steve...@chromium.org, Feb 6 2017

Cc: derat@chromium.org llozano@chromium.org
+llozano@ WRT if/when we should deprecate --clang from Simple Chrome.

--fastbuild now just sets 'symbol_level = 1' in $GN_ARGS, but we should probably remove it (see  issue 689090  for concerns that Simple Chrome does not automatically run 'gn gen').

--component now just sets 'is_component_build = true' in $GN_ARGS, which has the same concerns.

Comment 6 by steve...@chromium.org, Feb 6 2017 

Also note: 'is_component_build = True' may not even work and is probably not something we should try to support in Simple Chrome.

Comment 7 by llozano@chromium.org, Feb 6 2017 

regarding #5

we should be able to deprecate --clang in a few weeks (~3)

I will do that once we have totally migrated to clang.

Comment 8 by steve...@chromium.org, Feb 22 2017 

llozano@ - I just sent out a PSA to chromium-os-dev@chromium.org, and have a CL up to stop passing --fastbuild in the CQ builders (which just caused a build failure in the PFQ, see  issue 695086 ). I plan to deprecate --component and --fastbuild once that lands. Let me know if we are ready to remove --clang also.

Comment 9 by steve...@chromium.org, Feb 22 2017

Status: Started (was: Available)

Comment 10 by posciak@chromium.org, Feb 23 2017 

Building a Debug chrome binary without component build with simplechrome fails for ARM builds:

error: PLT offset too large, try linking with --long-plt

Should is_component_build = true be still used for Debug builds?

Comment 11 by llozano@chromium.org, Feb 23 2017 

I just posted a workaround for the --long-plt issue in https://bugs.chromium.org/p/chromium/issues/detail?id=583532. 
Can you give it a try? If it works, you should not need to build using is_component_build.
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c

commit b7669c091d6fd92890e9e88b8fd3be0ac8eae96c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 27 18:15:58 2017

cros_chrome_sdk: Elim --fastbuild and --component

BUG= chromium:599771 
TEST=cli/cros/cros_chrome_sdk_unittest

Change-Id: Ia9c4888f13783b6835e486a5b9e640f16633ba84
Reviewed-on: https://chromium-review.googlesource.com/445972
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c/cli/cros/cros_chrome_sdk.py
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c

commit b7669c091d6fd92890e9e88b8fd3be0ac8eae96c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 27 18:15:58 2017

cros_chrome_sdk: Elim --fastbuild and --component

BUG= chromium:599771 
TEST=cli/cros/cros_chrome_sdk_unittest

Change-Id: Ia9c4888f13783b6835e486a5b9e640f16633ba84
Reviewed-on: https://chromium-review.googlesource.com/445972
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c/cli/cros/cros_chrome_sdk.py
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c

commit b7669c091d6fd92890e9e88b8fd3be0ac8eae96c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 27 18:15:58 2017

cros_chrome_sdk: Elim --fastbuild and --component

BUG= chromium:599771 
TEST=cli/cros/cros_chrome_sdk_unittest

Change-Id: Ia9c4888f13783b6835e486a5b9e640f16633ba84
Reviewed-on: https://chromium-review.googlesource.com/445972
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c/cli/cros/cros_chrome_sdk.py

Comment 15 by steve...@chromium.org, Feb 27 2017

Status: Fixed (was: Started)
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c

commit b7669c091d6fd92890e9e88b8fd3be0ac8eae96c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 27 18:15:58 2017

cros_chrome_sdk: Elim --fastbuild and --component

BUG= chromium:599771 
TEST=cli/cros/cros_chrome_sdk_unittest

Change-Id: Ia9c4888f13783b6835e486a5b9e640f16633ba84
Reviewed-on: https://chromium-review.googlesource.com/445972
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c/cli/cros/cros_chrome_sdk.py
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c

commit b7669c091d6fd92890e9e88b8fd3be0ac8eae96c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 27 18:15:58 2017

cros_chrome_sdk: Elim --fastbuild and --component

BUG= chromium:599771 
TEST=cli/cros/cros_chrome_sdk_unittest

Change-Id: Ia9c4888f13783b6835e486a5b9e640f16633ba84
Reviewed-on: https://chromium-review.googlesource.com/445972
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c/cli/cros/cros_chrome_sdk.py
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c

commit b7669c091d6fd92890e9e88b8fd3be0ac8eae96c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 27 18:15:58 2017

cros_chrome_sdk: Elim --fastbuild and --component

BUG= chromium:599771 
TEST=cli/cros/cros_chrome_sdk_unittest

Change-Id: Ia9c4888f13783b6835e486a5b9e640f16633ba84
Reviewed-on: https://chromium-review.googlesource.com/445972
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c/cli/cros/cros_chrome_sdk.py
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c

commit b7669c091d6fd92890e9e88b8fd3be0ac8eae96c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 27 18:15:58 2017

cros_chrome_sdk: Elim --fastbuild and --component

BUG= chromium:599771 
TEST=cli/cros/cros_chrome_sdk_unittest

Change-Id: Ia9c4888f13783b6835e486a5b9e640f16633ba84
Reviewed-on: https://chromium-review.googlesource.com/445972
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c/cli/cros/cros_chrome_sdk.py
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c

commit b7669c091d6fd92890e9e88b8fd3be0ac8eae96c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 27 18:15:58 2017

cros_chrome_sdk: Elim --fastbuild and --component

BUG= chromium:599771 
TEST=cli/cros/cros_chrome_sdk_unittest

Change-Id: Ia9c4888f13783b6835e486a5b9e640f16633ba84
Reviewed-on: https://chromium-review.googlesource.com/445972
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c/cli/cros/cros_chrome_sdk.py
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c

commit b7669c091d6fd92890e9e88b8fd3be0ac8eae96c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 27 18:15:58 2017

cros_chrome_sdk: Elim --fastbuild and --component

BUG= chromium:599771 
TEST=cli/cros/cros_chrome_sdk_unittest

Change-Id: Ia9c4888f13783b6835e486a5b9e640f16633ba84
Reviewed-on: https://chromium-review.googlesource.com/445972
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c/cli/cros/cros_chrome_sdk.py
Project Member

Comment 22 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c

commit b7669c091d6fd92890e9e88b8fd3be0ac8eae96c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 27 18:15:58 2017

cros_chrome_sdk: Elim --fastbuild and --component

BUG= chromium:599771 
TEST=cli/cros/cros_chrome_sdk_unittest

Change-Id: Ia9c4888f13783b6835e486a5b9e640f16633ba84
Reviewed-on: https://chromium-review.googlesource.com/445972
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/b7669c091d6fd92890e9e88b8fd3be0ac8eae96c/cli/cros/cros_chrome_sdk.py

Comment 23 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 24 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 25 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 26 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
►

Sign in to add a comment