jam@ if you checkout older depot_tools, say this https://chromium.googlesource.com/chromium/tools/depot_tools/+/dc58a97f0240622323bc22a8a4054f27fe58ce68 , does this problem still persist?

Also, can you re-run the command with "-v -v" flags and paste fuller output?

On one hand, I don't understand what does this have to do git upgrade. On the other, I don't think I ever touched the code that runs the editor.

I tried that and it still persists. running with -v -v

DEBUG:root:git symbolic-ref HEAD
DEBUG:root:git config --int --get branch.testgit.git-cl-similarity
DEBUG:root:git symbolic-ref HEAD
DEBUG:root:git config --int --get branch.testgit.git-find-copies
Using 50% similarity for rename/copy detection. Override with --similarity.
DEBUG:root:C:\src\depot_tools\git.bat -c color.ui=never update-index --refresh -q
DEBUG:root:C:\src\depot_tools\git.bat -c color.ui=never diff-index --name-status HEAD
DEBUG:root:git config rietveld.autoupdate
DEBUG:root:Failed running ['git', 'config', 'rietveld.autoupdate']
DEBUG:root:git rev-parse --show-cdup
DEBUG:root:git config rietveld.server https://codereview.chromium.org
DEBUG:root:git config rietveld.cc chromium-reviews@chromium.org
DEBUG:root:git config --unset-all rietveld.private
DEBUG:root:Failed running ['git', 'config', '--unset-all', 'rietveld.private']
DEBUG:root:git config rietveld.tree-status-url http://chromium-status.appspot.com/status
DEBUG:root:git config rietveld.viewvc-url https://chromium.googlesource.com/chromium/src/+/
DEBUG:root:git config --unset-all rietveld.bug-prefix
DEBUG:root:Failed running ['git', 'config', '--unset-all', 'rietveld.bug-prefix']
DEBUG:root:git config --unset-all rietveld.cpplint-regex
DEBUG:root:Failed running ['git', 'config', '--unset-all', 'rietveld.cpplint-regex']
DEBUG:root:git config --unset-all rietveld.force-https-commit-url
DEBUG:root:Failed running ['git', 'config', '--unset-all', 'rietveld.force-https-commit-url']
DEBUG:root:git config rietveld.cpplint-ignore-regex webkit/api/.*
DEBUG:root:git config rietveld.project chromium
DEBUG:root:git config rietveld.pending-ref-prefix refs/pending/
DEBUG:root:git config rietveld.run-post-upload-hook True
DEBUG:root:git config gerrit.host
DEBUG:root:Failed running ['git', 'config', 'gerrit.host']
DEBUG:root:git symbolic-ref HEAD
DEBUG:root:git config branch.testgit.rietveldissue
DEBUG:root:Failed running ['git', 'config', 'branch.testgit.rietveldissue']
DEBUG:root:git config branch.testgit.gerritissue
DEBUG:root:Failed running ['git', 'config', 'branch.testgit.gerritissue']
DEBUG:root:git config rietveld.server
DEBUG:root:git config branch.testgit.merge
DEBUG:root:Failed running ['git', 'config', 'branch.testgit.merge']
DEBUG:root:git config rietveld.upstream-branch
DEBUG:root:Failed running ['git', 'config', 'rietveld.upstream-branch']
DEBUG:root:git config rietveld.pending-ref-prefix
DEBUG:root:git branch -r
DEBUG:root:git rev-parse --verify refs/remotes/origin/master
DEBUG:root:C:\src\depot_tools\git.bat -c color.ui=never config --get branch.testgit.base
DEBUG:root:C:\src\depot_tools\git.bat -c color.ui=never config --get branch.testgit.base-upstream
DEBUG:root:C:\src\depot_tools\git.bat -c color.ui=never merge-base refs/remotes/origin/master testgit
DEBUG:root:C:\src\depot_tools\git.bat -c color.ui=never merge-base --is-ancestor 8d484368f9d4013effeee0e078fbe7039254cd45 testgit
DEBUG:root:C:\src\depot_tools\git.bat -c color.ui=never merge-base --is-ancestor 8d484368f9d4013effeee0e078fbe7039254cd45 8d484368f9d4013eff
eee0e078fbe7039254cd45
DEBUG:root:Found OLD pre-set merge-base for testgit: 8d484368f9d4013effeee0e078fbe7039254cd45
DEBUG:root:C:\src\depot_tools\git.bat -c color.ui=never config --local branch.testgit.base 8d484368f9d4013effeee0e078fbe7039254cd45
DEBUG:root:C:\src\depot_tools\git.bat -c color.ui=never config --local branch.testgit.base-upstream refs/remotes/origin/master
DEBUG:root:Using auth config AuthConfig(use_oauth2=True, save_cookies=False, use_local_webserver=True, webserver_port=8090, refresh_token_js
on='')
DEBUG:root:Using token storage 'C:\\Users\\jabdelmalek\\.depot_tools_oauth2_tokens' (cache key 'codereview.chromium.org')
DEBUG:root:cached token info: {'token_expiry': datetime.datetime(2016, 4, 2, 1, 1, 14), 'has_access_token': True, 'utcnow': datetime.datetim
e(2016, 4, 2, 0, 4, 13, 669000), 'invalid': False, 'access_token_expired': False}
DEBUG:root:git rev-parse --verify 8d484368f9d4013effeee0e078fbe7039254cd45
DEBUG:root:git merge-base 8d484368f9d4013effeee0e078fbe7039254cd45 HEAD
DEBUG:root:git rev-list ^8d484368f9d4013effeee0e078fbe7039254cd45 HEAD
DEBUG:root:git config gitcl.remotebranch
DEBUG:root:git config branch.testgit.merge
DEBUG:root:Failed running ['git', 'config', 'branch.testgit.merge']
DEBUG:root:git config rietveld.upstream-branch
DEBUG:root:Failed running ['git', 'config', 'rietveld.upstream-branch']
DEBUG:root:git branch -r
DEBUG:root:git rev-list ^8d484368f9d4013effeee0e078fbe7039254cd45 refs/remotes/origin/master
DEBUG:root:git rev-parse --show-cdup
DEBUG:root:git rev-parse HEAD
DEBUG:root:git diff --name-status --no-renames -r 8d484368f9d4013effeee0e078fbe7039254cd45... .;  cwd=.
DEBUG:root:git config branch.testgit.rietveldpatchset
DEBUG:root:Failed running ['git', 'config', 'branch.testgit.rietveldpatchset']
DEBUG:root:git log --pretty=format:%s%n%n%b 8d484368f9d4013effeee0e078fbe7039254cd45...
DEBUG:root:git config user.email
DEBUG:root:GitAffectedFile(PRESUBMIT.py)
DEBUG:root:git diff --no-ext-diff --stat --find-copies-harder -l100000 -C50 8d484368f9d4013effeee0e078fbe7039254cd45 HEAD
 PRESUBMIT.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
DEBUG:root:git log --pretty=format:%s

%b 8d484368f9d4013effeee0e078fbe7039254cd45..HEAD
DEBUG:root:git config rietveld.bug-prefix
DEBUG:root:Failed running ['git', 'config', 'rietveld.bug-prefix']
DEBUG:root:git config core.editor
DEBUG:root:'c:/program files/sublime text 2/sublime_text.exe' -w c:\users\jabdel~1\appdata\local\temp\cl_descriptionfahpkg
''c:' is not recognized as an internal or external command,
operable program or batch file.
Running editor failed

D:\src\chrome1\src>

Gah, nuts. How did I only see this bug now?

If sublime is in your path, `EDITOR=sublime_text` may work. I'll see what can be done about paths with spaces in them (I'm sure it's some dumb quoting thing).

How are you setting your EDITOR environment variable right now?

Oh, I see how you're setting editor now (actually read the whole thread now).

Ok I just found a workaround, thanks to the tip to use -v -v which showed me the error.

changing the gitconfig line to
	editor = \"c:/program files/sublime text 2/sublime_text.exe\" -w
i.e. just changing the string quote to be " instead of '. No idea why this suddenly stopped failing.

Hm... I just installed sublime text 3 and did

[core]
  editor = 'C:\\Program Files\\Sublime Text 3\\sublime_text.exe' -w

And it seems to work for me. I'll try with forward slashes next.

FWIW, it works for me with single quotes and forward slashes. However, with double quotes and forward slashes it fails.

That's quite strange that it works for you and not me. Should we debug this further?

Not opposed to digging into this, but I haven't heard any other reports of this problem either (which is also not necessarily an indicator of much). Which version of windows are you using?

Windows 7.

Alright, I was trying from win10 (upgraded from 7). I'm actually not sure what other details would be pertinent?