New issue
Advanced search Search tips

Issue 599755 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Uninitialized read in LayerTreeSettingsTest.AllMembersChanged under DrMemory

Project Member Reported by benwells@chromium.org, Apr 1 2016

Issue description

Looks to be introduced by https://crrev.com/6e7fec1054456994b333257bcb1fb68c7212b31a

First build: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/6932

Sample output isn't very helpful:
UNINITIALIZED READ: reading 0x002af7dc-0x002af7dd 1 byte(s)
# 0 cc::`anonymous namespace'::LayerTreeSettingsTest_AllMembersChanged_Test::TestBody [cc\trees\layer_tree_settings_unittest.cc:77]
# 1 testing::internal::HandleExceptionsInMethodIfSupported<>                   [testing\gtest\src\gtest.cc:2458]
Note: @0:06:54.125 in thread 888
Note: instruction: cmp    0xffffffb0(%ebp) $0x00
Suppression (error hash=#72621E8C109BDCA7#):
For more info on using suppressions see http://dev.chromium.org/developers/how-tos/using-drmemory#TOC-Suppressing-error-reports-from-the-
{
UNINITIALIZED READ
name=<insert_a_suppression_name_here>
*!cc::`anonymous namespace'::LayerTreeSettingsTest_AllMembersChanged_Test::TestBody
*!testing::internal::HandleExceptionsInMethodIfSupported<>
}

Am guessing it is the now redundant proto field.
 
Hmmm, the proto field is optional so not it, turns out its the LayerTreeSettings field which isn't set anymore.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a513c0f094c9e81a7b88d5b6681804937dfb258

commit 3a513c0f094c9e81a7b88d5b6681804937dfb258
Author: benwells <benwells@chromium.org>
Date: Fri Apr 01 03:37:11 2016

cc: Remove fields unused now that strict property checking is always on.

TBR=enne@chromium.org
BUG= 599755 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1854553002

Cr-Commit-Position: refs/heads/master@{#384476}

[modify] https://crrev.com/3a513c0f094c9e81a7b88d5b6681804937dfb258/cc/proto/layer_tree_settings.proto
[modify] https://crrev.com/3a513c0f094c9e81a7b88d5b6681804937dfb258/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/3a513c0f094c9e81a7b88d5b6681804937dfb258/cc/trees/layer_tree_settings_unittest.cc

Labels: Stability-Memory-DrMemory
Owner: benwells@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment