New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599743 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Implement Node.isConnected

Project Member Reported by kochi@chromium.org, Apr 1 2016

Issue description

Implement Node.isConnected, as a part of Shadow DOM V1 implementation.

Discussion:
https://github.com/w3c/webcomponents/issues/81

Spec:
https://dom.spec.whatwg.org/#dom-node-isconnected

 
Blocking: -531990
This is a utility function.
No need to implement this as a part of Shadow DOM v1.

Labels: -Pri-1 Pri-2

Comment 3 by yuzus@chromium.org, Apr 4 2016

Status: Started (was: Assigned)

Comment 4 by yuzus@chromium.org, Apr 8 2016

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b05e567bbdffc0bd099ab835cdbcbded909550da

commit b05e567bbdffc0bd099ab835cdbcbded909550da
Author: yuzus <yuzus@chromium.org>
Date: Fri Apr 08 05:00:46 2016

Implement Node.isConnected

This CL implements a Node atrribute Node.isConnected. Node.isConnected returns true when a context object is in a shadow-including document, and false otherwise.
See the spec here: https://dom.spec.whatwg.org/#dom-node-isconnected
See the discussion here: https://github.com/w3c/webcomponents/issues/81

BUG= 599743 

Review URL: https://codereview.chromium.org/1855823003

Cr-Commit-Position: refs/heads/master@{#385990}

[add] https://crrev.com/b05e567bbdffc0bd099ab835cdbcbded909550da/third_party/WebKit/LayoutTests/shadow-dom/node-isConnected.html
[modify] https://crrev.com/b05e567bbdffc0bd099ab835cdbcbded909550da/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/b05e567bbdffc0bd099ab835cdbcbded909550da/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b05e567bbdffc0bd099ab835cdbcbded909550da/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/b05e567bbdffc0bd099ab835cdbcbded909550da/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b05e567bbdffc0bd099ab835cdbcbded909550da/third_party/WebKit/Source/core/dom/Node.idl

Sign in to add a comment