New issue
Advanced search Search tips

Issue 599714 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

code->kind() == Code::OPTIMIZED_FUNCTION in src/frames.cc

Project Member Reported by ClusterFuzz, Mar 31 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4622612042350592

Fuzzer: decoder_langfuzz
Job Type: linux_asan_d8_v8_arm64_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  code->kind() == Code::OPTIMIZED_FUNCTION in src/frames.cc
  
Regressed: V8: r35151:35152

Minimized Testcase (10.27 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97b9aaz6PAV5kOyE3g-YpDbgtCzFRvTzSEMp8Tqay1au_CSoGilzV04ehoFTvrOKl1BYCtwcfWi8Gfg4A3qmytJeviUv7HqfkiWz6wDm826CeP_YMvIipVphn5cUZak4h0VBmyvxetYMOyLTtZZvSeEJ5cxDQ

Filer: manoranjanr

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Labels: Te-Logged

Comment 2 by ajha@chromium.org, Apr 1 2016

Cc: ajha@chromium.org
Owner: danno@chromium.org
Status: Assigned (was: Available)
danno@: Could you please help in investigating this further for related work in https://codereview.chromium.org/1696043002
Cc: bmeu...@chromium.org verwa...@chromium.org
bmeurer@: Could be related to builtins being compiled by TurboFan now.
Owner: verwa...@chromium.org
Reproduces on TOT, caused by https://codereview.chromium.org/1843613002

out/x64.debug/d8 test.js

===== test.js =====
var custom_toString = function() {
  var boom = custom_toString.caller;
  return boom;
}

var object = {};
object.toString = custom_toString;

Object.hasOwnProperty(object);


Comment 5 Deleted

Status: Started (was: Assigned)
Yep, oversight from previous fix.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e5724d958bdca95ec92c19060da88c895fca97e8

commit e5724d958bdca95ec92c19060da88c895fca97e8
Author: bmeurer <bmeurer@chromium.org>
Date: Tue Apr 05 06:40:59 2016

[frames] Also properly deal with TF builtins in OptimizedFrame::GetFunctions().

This was missing from the previous fix.

R=ishell@chromium.org
BUG= chromium:599714 
LOG=n

Review URL: https://codereview.chromium.org/1861583002

Cr-Commit-Position: refs/heads/master@{#35249}

[modify] https://crrev.com/e5724d958bdca95ec92c19060da88c895fca97e8/src/frames.cc
[add] https://crrev.com/e5724d958bdca95ec92c19060da88c895fca97e8/test/mjsunit/regress/regress-crbug-599714.js

Status: Fixed (was: Started)
Project Member

Comment 9 by ClusterFuzz, Apr 5 2016

ClusterFuzz has detected this issue as fixed in range 35248:35249.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4622612042350592

Fuzzer: decoder_langfuzz
Job Type: linux_asan_d8_v8_arm64_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  code->kind() == Code::OPTIMIZED_FUNCTION in src/frames.cc
  
Regressed: V8: r35151:35152
Fixed: V8: r35248:35249

Minimized Testcase (10.27 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97b9aaz6PAV5kOyE3g-YpDbgtCzFRvTzSEMp8Tqay1au_CSoGilzV04ehoFTvrOKl1BYCtwcfWi8Gfg4A3qmytJeviUv7HqfkiWz6wDm826CeP_YMvIipVphn5cUZak4h0VBmyvxetYMOyLTtZZvSeEJ5cxDQ

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment