New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599709 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Implement disabling audio/video in media::RendererImpl

Project Member Reported by servolk@chromium.org, Mar 31 2016

Issue description

Now that we have media tracks, applications can select/deselect video tracks and enable/disable audio tracks and media::Renderer gets notifications about that. media::RendererImpl should stop audio/video processing (decoding, rendering) when a corresponding media track is disabled/deselected. But at the moment I've implemented only a much simpler solution - muting audio renderer by setting volume to 0.
To fix this we'll need to extend audio/video renderers to support suspending decoding/rendering. And we'll need to switch time source dynamically in RendererImpl (and ensure that's safe to do in the middle of playback).
 
Do you have a CL somewhere? I don't think we want to land anything that silently starts up unused tracks for decoding.
The CL that I'm currently working on is: https://codereview.chromium.org/1812543003

But it achieves muting/unmuting through setting audio renderer volume atm.
I don't understand your concern about unused tracks. My CL shouldn't cause anything like that to happen, because
1. Even if there are multiple audio tracks, only the first one is enabled by default.
2. I don't think we allow multiple audio tracks atm anyway.
Status: Fixed (was: Available)

Sign in to add a comment